Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1581043 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-02-15 05:00 +0100 |
| Last post | 2017-02-15 11:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] usb: class: remove logically dead code "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-02-15 05:00 +0100
Re: [PATCH] usb: class: remove logically dead code Peter Senna Tschudin <peter.senna@gmail.com> - 2017-02-15 10:10 +0100
Re: [PATCH] usb: class: remove logically dead code Oliver Neukum <oneukum@suse.com> - 2017-02-15 11:00 +0100
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-02-15 05:00 +0100 |
| Subject | [PATCH] usb: class: remove logically dead code |
| Message-ID | <taYV3-2vE-3@gated-at.bofh.it> |
Remove logically dead code.
'cntr' is always equal to zero when the following line of code is executed:
rv = cntr ? cntr : -EAGAIN;
Addresses-Coverity-ID: 113227
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/usb/class/cdc-wdm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
index 0a63695..8fda45a 100644
--- a/drivers/usb/class/cdc-wdm.c
+++ b/drivers/usb/class/cdc-wdm.c
@@ -531,7 +531,7 @@ static ssize_t wdm_read
i++;
if (file->f_flags & O_NONBLOCK) {
if (!test_bit(WDM_READ, &desc->flags)) {
- rv = cntr ? cntr : -EAGAIN;
+ rv = -EAGAIN;
goto err;
}
rv = 0;
--
2.5.0
[toc] | [next] | [standalone]
| From | Peter Senna Tschudin <peter.senna@gmail.com> |
|---|---|
| Date | 2017-02-15 10:10 +0100 |
| Message-ID | <tb3L4-6qS-25@gated-at.bofh.it> |
| In reply to | #1581043 |
On Tue, Feb 14, 2017 at 09:10:52PM -0600, Gustavo A. R. Silva wrote:
> Remove logically dead code.
> 'cntr' is always equal to zero when the following line of code is executed:
> rv = cntr ? cntr : -EAGAIN;
>
> Addresses-Coverity-ID: 113227
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
> drivers/usb/class/cdc-wdm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
> index 0a63695..8fda45a 100644
> --- a/drivers/usb/class/cdc-wdm.c
> +++ b/drivers/usb/class/cdc-wdm.c
> @@ -531,7 +531,7 @@ static ssize_t wdm_read
> i++;
> if (file->f_flags & O_NONBLOCK) {
> if (!test_bit(WDM_READ, &desc->flags)) {
> - rv = cntr ? cntr : -EAGAIN;
> + rv = -EAGAIN;
> goto err;
> }
> rv = 0;
> --
> 2.5.0
>
[toc] | [prev] | [next] | [standalone]
| From | Oliver Neukum <oneukum@suse.com> |
|---|---|
| Date | 2017-02-15 11:00 +0100 |
| Message-ID | <tb4xs-6HC-15@gated-at.bofh.it> |
| In reply to | #1581043 |
Am Dienstag, den 14.02.2017, 21:10 -0600 schrieb Gustavo A. R. Silva: > Remove logically dead code. > 'cntr' is always equal to zero when the following line of code is > executed: > rv = cntr ? cntr : -EAGAIN; > > Addresses-Coverity-ID: 113227 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > Acked-by: Oliver Neukum <oneukum@suse.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web