Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580881 > unrolled thread

[PATCH] arm64: include asm/assembler.h in entry-ftrace.S

Back to article view | Back to linux.kernel

Contents

  [PATCH] arm64: include asm/assembler.h in entry-ftrace.S Arnd Bergmann <arnd@arndb.de> - 2017-02-14 22:40 +0100
    Re: [PATCH] arm64: include asm/assembler.h in entry-ftrace.S Will Deacon <will.deacon@arm.com> - 2017-02-15 12:40 +0100

#1580881 — [PATCH] arm64: include asm/assembler.h in entry-ftrace.S

In a randconfig build I ran into this build error:

arch/arm64/kernel/entry-ftrace.S: Assembler messages:
arch/arm64/kernel/entry-ftrace.S:101: Error: unknown mnemonic `ldr_l' -- `ldr_l x2,ftrace_trace_function'

The macro is defined in asm/assembler.h, so we should include that file.

Fixes: 829d2bd13392 ("arm64: entry-ftrace.S: avoid open-coded {adr,ldr}_l")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm64/kernel/entry-ftrace.S | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/kernel/entry-ftrace.S b/arch/arm64/kernel/entry-ftrace.S
index 8f1905b795f3..e1be42e11ff5 100644
--- a/arch/arm64/kernel/entry-ftrace.S
+++ b/arch/arm64/kernel/entry-ftrace.S
@@ -10,6 +10,7 @@
  */
 
 #include <linux/linkage.h>
+#include <asm/assembler.h>
 #include <asm/ftrace.h>
 #include <asm/insn.h>
 
-- 
2.9.0

[toc] | [next] | [standalone]

#1581237

On Tue, Feb 14, 2017 at 10:32:58PM +0100, Arnd Bergmann wrote:
> In a randconfig build I ran into this build error:
> 
> arch/arm64/kernel/entry-ftrace.S: Assembler messages:
> arch/arm64/kernel/entry-ftrace.S:101: Error: unknown mnemonic `ldr_l' -- `ldr_l x2,ftrace_trace_function'
> 
> The macro is defined in asm/assembler.h, so we should include that file.
> 
> Fixes: 829d2bd13392 ("arm64: entry-ftrace.S: avoid open-coded {adr,ldr}_l")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I've picked this one up too.

Will

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web