Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1579505 > unrolled thread
| Started by | Nicholas Mc Guire <der.herr@hofr.at> |
|---|---|
| First post | 2017-02-13 09:20 +0100 |
| Last post | 2017-02-14 11:10 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] mtd: spi-nor: intel: use ERR_CAST in return statement Nicholas Mc Guire <der.herr@hofr.at> - 2017-02-13 09:20 +0100
Re: [PATCH] mtd: spi-nor: intel: use ERR_CAST in return statement Marek Vasut <marek.vasut@gmail.com> - 2017-02-14 06:10 +0100
Re: [PATCH] mtd: spi-nor: intel: use ERR_CAST in return statement Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-02-14 11:10 +0100
Re: [PATCH] mtd: spi-nor: intel: use ERR_CAST in return statement Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-14 11:10 +0100
| From | Nicholas Mc Guire <der.herr@hofr.at> |
|---|---|
| Date | 2017-02-13 09:20 +0100 |
| Subject | [PATCH] mtd: spi-nor: intel: use ERR_CAST in return statement |
| Message-ID | <tak1A-18Q-3@gated-at.bofh.it> |
This fixes a sparse warning about incorrect type in retrun expression
Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---
V2: fixed prefix and the truncated commit message noted by Boris Brezillon
<boris.brezillon@free-electrons.com> - thanks!
sparse complained about:
drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return expression (different address spaces)
drivers/mtd/spi-nor/intel-spi.c:731:28: expected struct intel_spi *
drivers/mtd/spi-nor/intel-spi.c:731:28: got void [noderef] <asn:2>*base
Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
Patch is against 4.10-rc7 (localversion-next is next-20170213)
drivers/mtd/spi-nor/intel-spi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
index 2956f2c..1a6de4b 100644
--- a/drivers/mtd/spi-nor/intel-spi.c
+++ b/drivers/mtd/spi-nor/intel-spi.c
@@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev,
ispi->base = devm_ioremap_resource(dev, mem);
if (IS_ERR(ispi->base))
- return ispi->base;
+ return ERR_CAST(ispi->base);
ispi->dev = dev;
ispi->info = info;
--
2.1.4
[toc] | [next] | [standalone]
| From | Marek Vasut <marek.vasut@gmail.com> |
|---|---|
| Date | 2017-02-14 06:10 +0100 |
| Message-ID | <taDxf-5GH-1@gated-at.bofh.it> |
| In reply to | #1579505 |
On 02/13/2017 09:14 AM, Nicholas Mc Guire wrote: > This fixes a sparse warning about incorrect type in retrun expression > > Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at> > --- > > V2: fixed prefix and the truncated commit message noted by Boris Brezillon > <boris.brezillon@free-electrons.com> - thanks! > > sparse complained about: > drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return expression (different address spaces) > drivers/mtd/spi-nor/intel-spi.c:731:28: expected struct intel_spi * > drivers/mtd/spi-nor/intel-spi.c:731:28: got void [noderef] <asn:2>*base > > Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y) Was this driver even enabled with multi_v7 and MTD_SPI_NOR=y ? Nonetheless, the patch is correct: Acked-by: Marek Vasut <marek.vasut@gmail.com> > Patch is against 4.10-rc7 (localversion-next is next-20170213) > > drivers/mtd/spi-nor/intel-spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c > index 2956f2c..1a6de4b 100644 > --- a/drivers/mtd/spi-nor/intel-spi.c > +++ b/drivers/mtd/spi-nor/intel-spi.c > @@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev, > > ispi->base = devm_ioremap_resource(dev, mem); > if (IS_ERR(ispi->base)) > - return ispi->base; > + return ERR_CAST(ispi->base); > > ispi->dev = dev; > ispi->info = info; > -- Best regards, Marek Vasut
[toc] | [prev] | [next] | [standalone]
| From | Mika Westerberg <mika.westerberg@linux.intel.com> |
|---|---|
| Date | 2017-02-14 11:10 +0100 |
| Message-ID | <taIdz-sN-1@gated-at.bofh.it> |
| In reply to | #1579505 |
On Mon, Feb 13, 2017 at 09:14:21AM +0100, Nicholas Mc Guire wrote: > This fixes a sparse warning about incorrect type in retrun expression > > Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
[toc] | [prev] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2017-02-14 11:10 +0100 |
| Message-ID | <taIdA-sN-27@gated-at.bofh.it> |
| In reply to | #1579505 |
On Mon, 13 Feb 2017 09:14:21 +0100 Nicholas Mc Guire <der.herr@hofr.at> wrote: > This fixes a sparse warning about incorrect type in retrun expression ^return and you miss a comma at the end of this sentence. > > Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at> You forgot to add my ack (same comment on your other patches). > --- > > V2: fixed prefix and the truncated commit message noted by Boris Brezillon > <boris.brezillon@free-electrons.com> - thanks! > > sparse complained about: > drivers/mtd/spi-nor/intel-spi.c:731:28: warning: incorrect type in return expression (different address spaces) > drivers/mtd/spi-nor/intel-spi.c:731:28: expected struct intel_spi * > drivers/mtd/spi-nor/intel-spi.c:731:28: got void [noderef] <asn:2>*base > > Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y) > > Patch is against 4.10-rc7 (localversion-next is next-20170213) > > drivers/mtd/spi-nor/intel-spi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c > index 2956f2c..1a6de4b 100644 > --- a/drivers/mtd/spi-nor/intel-spi.c > +++ b/drivers/mtd/spi-nor/intel-spi.c > @@ -728,7 +728,7 @@ struct intel_spi *intel_spi_probe(struct device *dev, > > ispi->base = devm_ioremap_resource(dev, mem); > if (IS_ERR(ispi->base)) > - return ispi->base; > + return ERR_CAST(ispi->base); > > ispi->dev = dev; > ispi->info = info;
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web