Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580464 > unrolled thread

[PATCH v1 0/2] Add pinctrl input schmitt support

Back to article view | Back to linux.kernel

Contents

  [PATCH v1 0/2] Add pinctrl input schmitt support David Wu <david.wu@rock-chips.com> - 2017-02-14 11:40 +0100
    [PATCH v1 2/2] pinctrl: rockchip: Add input schmitt support for rk3328 David Wu <david.wu@rock-chips.com> - 2017-02-14 11:40 +0100
      Re: [PATCH v1 2/2] pinctrl: rockchip: Add input schmitt support for rk3328 Heiko Stuebner <heiko@sntech.de> - 2017-02-23 18:00 +0100
    Re: [PATCH v1 0/2] Add pinctrl input schmitt support Linus Walleij <linus.walleij@linaro.org> - 2017-02-22 16:10 +0100

#1580464 — [PATCH v1 0/2] Add pinctrl input schmitt support

From: "david.wu" <david.wu@rock-chips.com>

Some pins need to enable Schmitt triggers which are used
in open loop configurations for noise immunity and closed
loop configurations to implement function generators.

david.wu (2):
  pinctrl: rockchip：Add input schmitt support
  pinctrl: rockchip: Add input schmitt support for rk3328

 drivers/pinctrl/pinctrl-rockchip.c | 90 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 90 insertions(+)

-- 
1.9.1

[toc] | [next] | [standalone]

#1580468 — [PATCH v1 2/2] pinctrl: rockchip: Add input schmitt support for rk3328

From: "david.wu" <david.wu@rock-chips.com>

Signed-off-by: david.wu <david.wu@rock-chips.com>
---
 drivers/pinctrl/pinctrl-rockchip.c | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index 6a071b1..6206e1e 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -1358,6 +1358,26 @@ static int rockchip_set_pull(struct rockchip_pin_bank *bank,
 	return ret;
 }
 
+#define RK3328_SCHMITT_BITS_PER_PIN		1
+#define RK3328_SCHMITT_PINS_PER_REG		16
+#define RK3328_SCHMITT_BANK_STRIDE		8
+#define RK3328_SCHMITT_GRF_OFFSET		0x380
+
+static void rk3328_calc_schmitt_reg_and_bit(struct rockchip_pin_bank *bank,
+					    int pin_num,
+					    struct regmap **regmap,
+					    int *reg, u8 *bit)
+{
+	struct rockchip_pinctrl *info = bank->drvdata;
+
+	*regmap = info->regmap_base;
+	*reg = RK3328_SCHMITT_GRF_OFFSET;
+
+	*reg += bank->bank_num * RK3328_SCHMITT_BANK_STRIDE;
+	*reg += ((pin_num / RK3328_SCHMITT_PINS_PER_REG) * 4);
+	*bit = pin_num % RK3328_SCHMITT_PINS_PER_REG;
+}
+
 static int rockchip_get_schmitt(struct rockchip_pin_bank *bank, int pin_num)
 {
 	struct rockchip_pinctrl *info = bank->drvdata;
@@ -2857,6 +2877,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
 		.pull_calc_reg		= rk3228_calc_pull_reg_and_bit,
 		.drv_calc_reg		= rk3228_calc_drv_reg_and_bit,
 		.iomux_recalc		= rk3328_recalc_mux,
+		.schmitt_calc_reg	= rk3328_calc_schmitt_reg_and_bit,
 };
 
 static struct rockchip_pin_bank rk3368_pin_banks[] = {
-- 
1.9.1

[toc] | [prev] | [next] | [standalone]

#1587025 — Re: [PATCH v1 2/2] pinctrl: rockchip: Add input schmitt support for rk3328

Am Dienstag, 14. Februar 2017, 18:35:41 CET schrieb David Wu:
> From: "david.wu" <david.wu@rock-chips.com>
> 
> Signed-off-by: david.wu <david.wu@rock-chips.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

[toc] | [prev] | [next] | [standalone]

#1586238

On Tue, Feb 14, 2017 at 11:35 AM, David Wu <david.wu@rock-chips.com> wrote:

> From: "david.wu" <david.wu@rock-chips.com>
>
> Some pins need to enable Schmitt triggers which are used
> in open loop configurations for noise immunity and closed
> loop configurations to implement function generators.

Just waiting for Heiko's review on this series before I queue it.

Yours,
Linus Walleij

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web