Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580404 > unrolled thread

[tip:timers/core] math64, tile: Fix build failure

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [tip:timers/core] math64, tile: Fix build failure tip-bot for Sudip Mukherjee <tipbot@zytor.com> - 2017-02-14 09:50 +0100

#1580404 — [tip:timers/core] math64, tile: Fix build failure

Commit-ID:  dba9a0babdd938a51d11ae81f9c40d07ca613f43
Gitweb:     http://git.kernel.org/tip/dba9a0babdd938a51d11ae81f9c40d07ca613f43
Author:     Sudip Mukherjee <sudipm.mukherjee@gmail.com>
AuthorDate: Tue, 24 Jan 2017 16:39:21 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 14 Feb 2017 09:39:13 +0100

math64, tile: Fix build failure

The build of tilegx allmodconfig fails with:
../arch/tile/include/asm/div64.h:5:15: error: unknown type name 'u64'
 static inline u64 mul_u32_u32(u32 a, u32 b)
               ^~~
../arch/tile/include/asm/div64.h:5:31: error: unknown type name 'u32'
 static inline u64 mul_u32_u32(u32 a, u32 b)
                               ^~~
../arch/tile/include/asm/div64.h:5:38: error: unknown type name 'u32'
 static inline u64 mul_u32_u32(u32 a, u32 b)
                                      ^~~
In file included from ../fs/ubifs/ubifs.h:26:0,
                 from ../fs/ubifs/shrinker.c:42:
../include/linux/math64.h: In function 'mul_u64_u32_shr':
../arch/tile/include/asm/div64.h:9:21: error: implicit declaration of
	function 'mul_u32_u32' [-Werror=implicit-function-declaration]

Include the linux/types.h in tiles div64.h to slve the problem.

Fixes: 9e3d6223d209 ("math64, timers: Fix 32bit mul_u64_u32_shr() and friends")
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Acked-by: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: http://lkml.kernel.org/r/1485275961-20112-1-git-send-email-sudip.mukherjee@codethink.co.uk
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/tile/include/asm/div64.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/tile/include/asm/div64.h b/arch/tile/include/asm/div64.h
index bf61619..9f765cd 100644
--- a/arch/tile/include/asm/div64.h
+++ b/arch/tile/include/asm/div64.h
@@ -1,6 +1,8 @@
 #ifndef _ASM_TILE_DIV64_H
 #define _ASM_TILE_DIV64_H
 
+#include <linux/types.h>
+
 #ifdef __tilegx__
 static inline u64 mul_u32_u32(u32 a, u32 b)
 {

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web