Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1680843 > unrolled thread
| Started by | Chunyan Zhang <chunyan.zhang@spreadtrum.com> |
|---|---|
| First post | 2017-07-04 12:30 +0200 |
| Last post | 2017-07-05 12:40 +0200 |
| Articles | 6 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] add support for Spreadtrum's FM driver Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-07-04 12:30 +0200
[PATCH 1/2] arm64: dts: add Spreadtrum's fm support Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-07-04 12:30 +0200
Re: [PATCH 1/2] arm64: dts: add Spreadtrum's fm support Mark Rutland <mark.rutland@arm.com> - 2017-07-04 14:40 +0200
Re: [PATCH 2/2] misc: added Spreadtrum's radio driver Chunyan Zhang <zhang.lyra@gmail.com> - 2017-07-05 12:20 +0200
Re: [PATCH 2/2] misc: added Spreadtrum's radio driver Arnd Bergmann <arnd@arndb.de> - 2017-07-05 13:50 +0200
[PATCH 0/2] add support for Spreadtrum's FM driver Chunyan Zhang <chunyan.zhang@spreadtrum.com> - 2017-07-05 12:40 +0200
| From | Chunyan Zhang <chunyan.zhang@spreadtrum.com> |
|---|---|
| Date | 2017-07-04 12:30 +0200 |
| Subject | [PATCH 0/2] add support for Spreadtrum's FM driver |
| Message-ID | <tZtfI-6Ye-7@gated-at.bofh.it> |
According to GregKH's suggestion [1], we tried to simply sort out the FM driver source code which has been using in the internal projects. Hopes it can help for fixing the problem raised in [1]. [1] https://lkml.org/lkml/2017/6/28/222 Chunyan Zhang (2): arm64: dts: add Spreadtrum's fm support misc: added Spreadtrum's radio driver arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 4 + drivers/misc/Kconfig | 1 + drivers/misc/Makefile | 1 + drivers/misc/sprd-wcn/Kconfig | 14 + drivers/misc/sprd-wcn/Makefile | 1 + drivers/misc/sprd-wcn/radio/Kconfig | 8 + drivers/misc/sprd-wcn/radio/Makefile | 2 + drivers/misc/sprd-wcn/radio/fmdrv.h | 595 +++++++++++ drivers/misc/sprd-wcn/radio/fmdrv_main.c | 1245 ++++++++++++++++++++++++ drivers/misc/sprd-wcn/radio/fmdrv_main.h | 117 +++ drivers/misc/sprd-wcn/radio/fmdrv_ops.c | 447 +++++++++ drivers/misc/sprd-wcn/radio/fmdrv_ops.h | 17 + drivers/misc/sprd-wcn/radio/fmdrv_rds_parser.c | 753 ++++++++++++++ drivers/misc/sprd-wcn/radio/fmdrv_rds_parser.h | 103 ++ 14 files changed, 3308 insertions(+) create mode 100644 drivers/misc/sprd-wcn/Kconfig create mode 100644 drivers/misc/sprd-wcn/Makefile create mode 100644 drivers/misc/sprd-wcn/radio/Kconfig create mode 100644 drivers/misc/sprd-wcn/radio/Makefile create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv.h create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv_main.c create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv_main.h create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv_ops.c create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv_ops.h create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv_rds_parser.c create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv_rds_parser.h -- 2.7.4
[toc] | [next] | [standalone]
| From | Chunyan Zhang <chunyan.zhang@spreadtrum.com> |
|---|---|
| Date | 2017-07-04 12:30 +0200 |
| Subject | [PATCH 1/2] arm64: dts: add Spreadtrum's fm support |
| Message-ID | <tZtfI-6Ye-13@gated-at.bofh.it> |
| In reply to | #1680843 |
Added FM support for Spreadtrum's SP9860 board.
Signed-off-by: Songhe Wei <songhe.wei@spreadtrum.com>
Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
---
arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
index 0362ecd..6fe052d 100644
--- a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
+++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
@@ -39,6 +39,10 @@
#size-cells = <2>;
ranges;
};
+
+ sprd-fm {
+ compatible = "sprd,marlin2-fm";
+ };
};
&uart0 {
--
2.7.4
[toc] | [prev] | [next] | [standalone]
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Date | 2017-07-04 14:40 +0200 |
| Subject | Re: [PATCH 1/2] arm64: dts: add Spreadtrum's fm support |
| Message-ID | <tZvhw-8cI-21@gated-at.bofh.it> |
| In reply to | #1680845 |
On Tue, Jul 04, 2017 at 06:15:07PM +0800, Chunyan Zhang wrote:
> Added FM support for Spreadtrum's SP9860 board.
>
> Signed-off-by: Songhe Wei <songhe.wei@spreadtrum.com>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
> ---
> arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
> index 0362ecd..6fe052d 100644
> --- a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
> +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
> @@ -39,6 +39,10 @@
> #size-cells = <2>;
> ranges;
> };
> +
> + sprd-fm {
> + compatible = "sprd,marlin2-fm";
> + };
What kind of device is this? MMIO?
It seems to be sitting directly under the root node, but has no reg or
relationship with another bus defined, so something is missing.
This will need binding documentation.
Thanks,
Mark.
> };
>
> &uart0 {
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | Chunyan Zhang <zhang.lyra@gmail.com> |
|---|---|
| Date | 2017-07-05 12:20 +0200 |
| Subject | Re: [PATCH 2/2] misc: added Spreadtrum's radio driver |
| Message-ID | <tZPzA-4Wj-13@gated-at.bofh.it> |
| In reply to | #1680843 |
On 4 July 2017 at 18:51, Arnd Bergmann <arnd@arndb.de> wrote: > On Tue, Jul 4, 2017 at 12:15 PM, Chunyan Zhang > <chunyan.zhang@spreadtrum.com> wrote: >> This patch added FM radio driver for Spreadtrum's SC2342, which's >> a WCN SoC, also added a new directory for Spreadtrum's WCN SoCs. >> >> Signed-off-by: Songhe Wei <songhe.wei@spreadtrum.com> >> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> > > (adding linux-media folks to Cc) (You forgot to add them in :)) > > Hi Chunyan, Hi Arnd, > > Thanks for posting this for inclusion as Greg asked for. I'm not sure what > the policy is for new radio drivers, but I assume this would have to go > to drivers/staging/media/ as it is a driver for hardware that fits into > drivers/media/radio but doesn't use the respective APIs. Ok, I agree to let it go to drivers/staging/media/. Like I mentioned, SC2342 includes many functions, this patch is only adding FM radio function included in SC2342 to the kernel tree. So I figure that its lifetime probably will not be too long, will remove it from the kernel tree when we have a clean enough version of the whole SC2342 drivers for the official upstreaming. Thanks, Chunyan > > Arnd > --- > end of message, full patch quoted for reference below >
[toc] | [prev] | [next] | [standalone]
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-07-05 13:50 +0200 |
| Subject | Re: [PATCH 2/2] misc: added Spreadtrum's radio driver |
| Message-ID | <tZQYG-5GJ-11@gated-at.bofh.it> |
| In reply to | #1681429 |
On Wed, Jul 5, 2017 at 12:18 PM, Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> On 4 July 2017 at 18:51, Arnd Bergmann <arnd@arndb.de> wrote:
>> On Tue, Jul 4, 2017 at 12:15 PM, Chunyan Zhang
> Like I mentioned, SC2342 includes many functions, this patch is only
> adding FM radio function included in SC2342 to the kernel tree. So I
> figure that its lifetime probably will not be too long, will remove it
> from the kernel tree when we have a clean enough version of the whole
> SC2342 drivers for the official upstreaming.
Would it make sense to add some or all of the other drivers to drivers/staging/
as well in the meantime?
Arnd
[toc] | [prev] | [next] | [standalone]
| From | Chunyan Zhang <chunyan.zhang@spreadtrum.com> |
|---|---|
| Date | 2017-07-05 12:40 +0200 |
| Message-ID | <tZPSW-537-11@gated-at.bofh.it> |
| In reply to | #1680843 |
[add linux-media list and Mauro Carvalho Chehab] According to GregKH's suggestion [1], we tried to simply sort out the FM driver source code which has been using in the internal projects. Hopes it can help for fixing the problem raised in [1]. [1] https://lkml.org/lkml/2017/6/28/222 Chunyan Zhang (2): arm64: dts: add Spreadtrum's fm support misc: added Spreadtrum's radio driver arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 4 + drivers/misc/Kconfig | 1 + drivers/misc/Makefile | 1 + drivers/misc/sprd-wcn/Kconfig | 14 + drivers/misc/sprd-wcn/Makefile | 1 + drivers/misc/sprd-wcn/radio/Kconfig | 8 + drivers/misc/sprd-wcn/radio/Makefile | 2 + drivers/misc/sprd-wcn/radio/fmdrv.h | 595 +++++++++++ drivers/misc/sprd-wcn/radio/fmdrv_main.c | 1245 ++++++++++++++++++++++++ drivers/misc/sprd-wcn/radio/fmdrv_main.h | 117 +++ drivers/misc/sprd-wcn/radio/fmdrv_ops.c | 447 +++++++++ drivers/misc/sprd-wcn/radio/fmdrv_ops.h | 17 + drivers/misc/sprd-wcn/radio/fmdrv_rds_parser.c | 753 ++++++++++++++ drivers/misc/sprd-wcn/radio/fmdrv_rds_parser.h | 103 ++ 14 files changed, 3308 insertions(+) create mode 100644 drivers/misc/sprd-wcn/Kconfig create mode 100644 drivers/misc/sprd-wcn/Makefile create mode 100644 drivers/misc/sprd-wcn/radio/Kconfig create mode 100644 drivers/misc/sprd-wcn/radio/Makefile create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv.h create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv_main.c create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv_main.h create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv_ops.c create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv_ops.h create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv_rds_parser.c create mode 100644 drivers/misc/sprd-wcn/radio/fmdrv_rds_parser.h -- 2.7.4
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web