Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1681039 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-07-04 17:20 +0200 |
| Last post | 2017-07-05 10:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH][-next] net: macb: remove extraneous return when MACB_EXT_DESC is defined Colin King <colin.king@canonical.com> - 2017-07-04 17:20 +0200
Re: [PATCH][-next] net: macb: remove extraneous return when MACB_EXT_DESC is defined Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-07-05 10:10 +0200
Re: [PATCH][-next] net: macb: remove extraneous return when MACB_EXT_DESC is defined David Miller <davem@davemloft.net> - 2017-07-05 10:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-07-04 17:20 +0200 |
| Subject | [PATCH][-next] net: macb: remove extraneous return when MACB_EXT_DESC is defined |
| Message-ID | <tZxMl-1ET-15@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
When macro MACB_EXT_DESC is defined we end up with two identical
return statements and just one is sufficient. Remove the extra
return.
Detected by CoverityScan, CID#1449361 ("Structurally dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/cadence/macb_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 41e5711544fc..e69ebdd65658 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -146,7 +146,6 @@ static unsigned int macb_adj_dma_desc_idx(struct macb *bp, unsigned int desc_idx
default:
break;
}
- return desc_idx;
#endif
return desc_idx;
}
--
2.11.0
[toc] | [next] | [standalone]
| From | Nicolas Ferre <nicolas.ferre@microchip.com> |
|---|---|
| Date | 2017-07-05 10:10 +0200 |
| Subject | Re: [PATCH][-next] net: macb: remove extraneous return when MACB_EXT_DESC is defined |
| Message-ID | <tZNxL-3Ho-19@gated-at.bofh.it> |
| In reply to | #1681039 |
On 04/07/2017 at 17:09, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> When macro MACB_EXT_DESC is defined we end up with two identical
> return statements and just one is sufficient. Remove the extra
> return.
>
> Detected by CoverityScan, CID#1449361 ("Structurally dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> ---
> drivers/net/ethernet/cadence/macb_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
> index 41e5711544fc..e69ebdd65658 100644
> --- a/drivers/net/ethernet/cadence/macb_main.c
> +++ b/drivers/net/ethernet/cadence/macb_main.c
> @@ -146,7 +146,6 @@ static unsigned int macb_adj_dma_desc_idx(struct macb *bp, unsigned int desc_idx
> default:
> break;
> }
> - return desc_idx;
> #endif
> return desc_idx;
> }
>
--
Nicolas Ferre
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-07-05 10:20 +0200 |
| Subject | Re: [PATCH][-next] net: macb: remove extraneous return when MACB_EXT_DESC is defined |
| Message-ID | <tZNHr-3KF-5@gated-at.bofh.it> |
| In reply to | #1681039 |
From: Colin King <colin.king@canonical.com>
Date: Tue, 4 Jul 2017 16:09:59 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> When macro MACB_EXT_DESC is defined we end up with two identical
> return statements and just one is sufficient. Remove the extra
> return.
>
> Detected by CoverityScan, CID#1449361 ("Structurally dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web