Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1681198 > unrolled thread

[PATCH] sgi-xpc: remove unnecessary static in xpc_setup_msg_structures_uv()

Back to article view | Back to linux.kernel

Contents

  [PATCH] sgi-xpc: remove unnecessary static in  xpc_setup_msg_structures_uv() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-05 00:00 +0200
    Re: [PATCH] sgi-xpc: remove unnecessary static in xpc_setup_msg_structures_uv() Robin Holt <robinmholt@gmail.com> - 2017-07-11 11:20 +0200

#1681198 — [PATCH] sgi-xpc: remove unnecessary static in xpc_setup_msg_structures_uv()

Remove unnecessary static on local variable _ret_.
Such variable is initialized before being used,
on every execution path throughout the function.
The static has no benefit and, removing it reduces
the code size.

This issue was detected using Coccinelle and the following semantic patch:

@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
     when strict
?x = e;

In the following log you can see the difference in the code size.
This log is the output of the size command, before and after the
code change:

before:
   text    data     bss     dec     hex filename
  25457    3056     448   28961    7121 drivers/misc/sgi-xp/xpc_uv.o

after:
   text    data     bss     dec     hex filename
  25405    3000     384   28789    7075 drivers/misc/sgi-xp/xpc_uv.o

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/misc/sgi-xp/xpc_uv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/sgi-xp/xpc_uv.c b/drivers/misc/sgi-xp/xpc_uv.c
index 340b44d..6581eba 100644
--- a/drivers/misc/sgi-xp/xpc_uv.c
+++ b/drivers/misc/sgi-xp/xpc_uv.c
@@ -1151,7 +1151,7 @@ xpc_allocate_recv_msg_slot_uv(struct xpc_channel *ch)
 static enum xp_retval
 xpc_setup_msg_structures_uv(struct xpc_channel *ch)
 {
-	static enum xp_retval ret;
+	enum xp_retval ret;
 	struct xpc_channel_uv *ch_uv = &ch->sn.uv;
 
 	DBUG_ON(ch->flags & XPC_C_SETUP);
-- 
2.5.0

[toc] | [next] | [standalone]

#1684911 — Re: [PATCH] sgi-xpc: remove unnecessary static in xpc_setup_msg_structures_uv()

Acked-by: Robin Holt <robinmholt@gmail.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web