Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677966 > unrolled thread

[RFC PATCH 0/5] vtime: Fix wrong user and system time accounting

Started byFrederic Weisbecker <fweisbec@gmail.com>
First post2017-06-29 19:20 +0200
Last post2017-07-05 15:20 +0200
Articles 5 on this page of 25 — 8 participants

Back to article view | Back to linux.kernel

Contents

  [RFC PATCH 0/5] vtime: Fix wrong user and system time accounting Frederic Weisbecker <fweisbec@gmail.com> - 2017-06-29 19:20 +0200
    [PATCH 2/5] sched: Always set vtime_snap_whence after accounting vtime Frederic Weisbecker <fweisbec@gmail.com> - 2017-06-29 19:20 +0200
      Re: [PATCH 2/5] sched: Always set vtime_snap_whence after  accounting vtime Rik van Riel <riel@redhat.com> - 2017-06-30 01:10 +0200
      [tip:sched/urgent] sched/cputime: Always set tsk->vtime_snap_whence  after accounting vtime tip-bot for Frederic Weisbecker <tipbot@zytor.com> - 2017-07-05 12:40 +0200
    [PATCH 5/5] sched: Accumulate vtime on top of nsec clocksource Frederic Weisbecker <fweisbec@gmail.com> - 2017-06-29 19:20 +0200
      Re: [PATCH 5/5] sched: Accumulate vtime on top of nsec clocksource Rik van Riel <riel@redhat.com> - 2017-06-30 01:30 +0200
        Re: [PATCH 5/5] sched: Accumulate vtime on top of nsec clocksource Frederic Weisbecker <fweisbec@gmail.com> - 2017-07-05 15:30 +0200
      Re: [PATCH 5/5] sched: Accumulate vtime on top of nsec clocksource Wanpeng Li <kernellwp@gmail.com> - 2017-06-30 04:00 +0200
      [tip:sched/urgent] sched/cputime: Accumulate vtime on top of nsec  clocksource tip-bot for Wanpeng Li <tipbot@zytor.com> - 2017-07-05 12:40 +0200
      Re: [PATCH 5/5] sched: Accumulate vtime on top of nsec clocksource "Levin, Alexander (Sasha Levin)" <alexander.levin@verizon.com> - 2017-07-15 05:40 +0200
        Re: [PATCH 5/5] sched: Accumulate vtime on top of nsec clocksource Wanpeng Li <kernellwp@gmail.com> - 2017-07-15 07:30 +0200
    [PATCH 4/5] sched: Move vtime task fields to their own struct Frederic Weisbecker <fweisbec@gmail.com> - 2017-06-29 19:20 +0200
      Re: [PATCH 4/5] sched: Move vtime task fields to their own struct Rik van Riel <riel@redhat.com> - 2017-06-30 01:10 +0200
      [tip:sched/urgent] sched/cputime: Move the vtime task fields to  their own struct tip-bot for Frederic Weisbecker <tipbot@zytor.com> - 2017-07-05 12:40 +0200
    [PATCH 1/5] vtime: Remove vtime_account_user() Frederic Weisbecker <fweisbec@gmail.com> - 2017-06-29 19:20 +0200
      Re: [PATCH 1/5] vtime: Remove vtime_account_user() Rik van Riel <riel@redhat.com> - 2017-06-30 01:10 +0200
      [tip:sched/urgent] vtime, sched/cputime: Remove  vtime_account_user() tip-bot for Frederic Weisbecker <tipbot@zytor.com> - 2017-07-05 12:40 +0200
    [PATCH 3/5] sched: Rename vtime fields Frederic Weisbecker <fweisbec@gmail.com> - 2017-06-29 19:20 +0200
      Re: [PATCH 3/5] sched: Rename vtime fields Rik van Riel <riel@redhat.com> - 2017-06-30 01:10 +0200
      [tip:sched/urgent] sched/cputime: Rename vtime fields tip-bot for Frederic Weisbecker <tipbot@zytor.com> - 2017-07-05 12:40 +0200
    Re: [RFC PATCH 0/5] vtime: Fix wrong user and system time accounting Wanpeng Li <kernellwp@gmail.com> - 2017-06-30 03:50 +0200
      Re: [RFC PATCH 0/5] vtime: Fix wrong user and system time  accounting Luiz Capitulino <lcapitulino@redhat.com> - 2017-06-30 19:40 +0200
    Re: [RFC PATCH 0/5] vtime: Fix wrong user and system time  accounting Thomas Gleixner <tglx@linutronix.de> - 2017-07-03 12:30 +0200
    Re: [RFC PATCH 0/5] vtime: Fix wrong user and system time  accounting Luiz Capitulino <lcapitulino@redhat.com> - 2017-07-04 19:00 +0200
      Re: [RFC PATCH 0/5] vtime: Fix wrong user and system time accounting Frederic Weisbecker <fweisbec@gmail.com> - 2017-07-05 15:20 +0200

Page 2 of 2 — ← Prev page 1 [2]

#1678393

FromWanpeng Li <kernellwp@gmail.com>
Date2017-06-30 03:50 +0200
Message-ID<tXTei-7bI-27@gated-at.bofh.it>
In reply to#1677966
Hi Luiz,

2017-06-30 1:15 GMT+08:00 Frederic Weisbecker <fweisbec@gmail.com>:
> Hi,
>
> This is a proposition to fix
> "[BUG nohz]: wrong user and system time accounting":
>         http://lkml.kernel.org/r/20170323165512.60945ac6@redhat.com
>
> I took Wanpeng Li's last patch and enhanced around it.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
>         sched/core
>
> HEAD: 9c7442613755e0ee0fc915ac876d88d4d2c7385e

Could you have a try?

Regards,
Wanpeng Li

>
> Thanks,
>         Frederic
> ---
>
> Frederic Weisbecker (4):
>       vtime: Remove vtime_account_user()
>       sched: Always set vtime_snap_whence after accounting vtime
>       sched: Rename vtime fields
>       sched: Move vtime task fields to their own struct
>
> Wanpeng Li (1):
>       sched: Accumulate vtime on top of nsec clocksource
>
>
>  include/linux/init_task.h |   6 +-
>  include/linux/sched.h     |  29 ++++++---
>  include/linux/vtime.h     |   9 +--
>  kernel/fork.c             |   6 +-
>  kernel/sched/cputime.c    | 158 ++++++++++++++++++++++++++++------------------
>  5 files changed, 123 insertions(+), 85 deletions(-)

[toc] | [prev] | [next] | [standalone]

#1679027 — Re: [RFC PATCH 0/5] vtime: Fix wrong user and system time accounting

FromLuiz Capitulino <lcapitulino@redhat.com>
Date2017-06-30 19:40 +0200
SubjectRe: [RFC PATCH 0/5] vtime: Fix wrong user and system time accounting
Message-ID<tY83E-8nx-21@gated-at.bofh.it>
In reply to#1678393
On Fri, 30 Jun 2017 09:41:18 +0800
Wanpeng Li <kernellwp@gmail.com> wrote:

> Hi Luiz,
> 
> 2017-06-30 1:15 GMT+08:00 Frederic Weisbecker <fweisbec@gmail.com>:
> > Hi,
> >
> > This is a proposition to fix
> > "[BUG nohz]: wrong user and system time accounting":
> >         http://lkml.kernel.org/r/20170323165512.60945ac6@redhat.com
> >
> > I took Wanpeng Li's last patch and enhanced around it.
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> >         sched/core
> >
> > HEAD: 9c7442613755e0ee0fc915ac876d88d4d2c7385e  
> 
> Could you have a try?

Yes, I'll do this shortly. But I'll be a few days off, so I may
have the results only on next week.

[toc] | [prev] | [next] | [standalone]

#1679866 — Re: [RFC PATCH 0/5] vtime: Fix wrong user and system time accounting

FromThomas Gleixner <tglx@linutronix.de>
Date2017-07-03 12:30 +0200
SubjectRe: [RFC PATCH 0/5] vtime: Fix wrong user and system time accounting
Message-ID<tZ6Ma-8r6-5@gated-at.bofh.it>
In reply to#1677966
On Thu, 29 Jun 2017, Frederic Weisbecker wrote:

> Hi,
> 
> This is a proposition to fix
> "[BUG nohz]: wrong user and system time accounting":
>         http://lkml.kernel.org/r/20170323165512.60945ac6@redhat.com
> 
> I took Wanpeng Li's last patch and enhanced around it.
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/frederic/linux-dynticks.git
> 	sched/core

For the series:

Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

[toc] | [prev] | [next] | [standalone]

#1681092 — Re: [RFC PATCH 0/5] vtime: Fix wrong user and system time accounting

FromLuiz Capitulino <lcapitulino@redhat.com>
Date2017-07-04 19:00 +0200
SubjectRe: [RFC PATCH 0/5] vtime: Fix wrong user and system time accounting
Message-ID<tZzl7-2yf-1@gated-at.bofh.it>
In reply to#1677966
On Thu, 29 Jun 2017 19:15:06 +0200
Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Hi,
> 
> This is a proposition to fix
> "[BUG nohz]: wrong user and system time accounting":
>         http://lkml.kernel.org/r/20170323165512.60945ac6@redhat.com

Amazing series Frederic! This fixes all instances of the issue
for me on bare-metal and KVM guests, even acct-bug[1] is fixed.

Tested-by: Luiz Capitulino <lcapitulino@redhat.com>

[1] http://people.redhat.com/~lcapitul/real-time/acct-bug.c

[toc] | [prev] | [next] | [standalone]

#1681533

FromFrederic Weisbecker <fweisbec@gmail.com>
Date2017-07-05 15:20 +0200
Message-ID<tZSnL-6FR-9@gated-at.bofh.it>
In reply to#1681092
On Tue, Jul 04, 2017 at 12:52:00PM -0400, Luiz Capitulino wrote:
> On Thu, 29 Jun 2017 19:15:06 +0200
> Frederic Weisbecker <fweisbec@gmail.com> wrote:
> 
> > Hi,
> > 
> > This is a proposition to fix
> > "[BUG nohz]: wrong user and system time accounting":
> >         http://lkml.kernel.org/r/20170323165512.60945ac6@redhat.com
> 
> Amazing series Frederic! This fixes all instances of the issue
> for me on bare-metal and KVM guests, even acct-bug[1] is fixed.
> 
> Tested-by: Luiz Capitulino <lcapitulino@redhat.com>
> 
> [1] http://people.redhat.com/~lcapitul/real-time/acct-bug.c

I'm glad it worked out! Thanks a lot for your testing. Now let's see
if someone stumbles upon a new bug introduced by this series. Given how
sensitive it can be.

[toc] | [prev] | [standalone]

Page 2 of 2 — ← Prev page 1 [2]

Back to top | Article view | linux.kernel

csiph-web