Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679662 > unrolled thread

[PATCH] mmc: mediatek: add ops->get_cd() support

Back to article view | Back to linux.kernel

Contents

  [PATCH] mmc: mediatek: add ops->get_cd() support Chaotian Jing <chaotian.jing@mediatek.com> - 2017-07-03 08:30 +0200
    Re: [PATCH] mmc: mediatek: add ops->get_cd() support Ulf Hansson <ulf.hansson@linaro.org> - 2017-07-11 16:50 +0200

#1679662 — [PATCH] mmc: mediatek: add ops->get_cd() support

if user plug out sd card slowly, finally card is plugged out but
cat /proc/partitions can find that card is still exist in kernel.
that's because alougth get card detect interrupt but CMD13 still
can get correct response(all other pins are connected expect card
detect pin).
add ops->get_cd() can avoid this issue.

Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
---
 drivers/mmc/host/mtk-sd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 5c1e178..975c765 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -1585,6 +1585,7 @@ static void msdc_hw_reset(struct mmc_host *mmc)
 	.request = msdc_ops_request,
 	.set_ios = msdc_ops_set_ios,
 	.get_ro = mmc_gpio_get_ro,
+	.get_cd = mmc_gpio_get_cd,
 	.start_signal_voltage_switch = msdc_ops_switch_volt,
 	.card_busy = msdc_card_busy,
 	.execute_tuning = msdc_execute_tuning,
-- 
1.8.1.1.dirty

[toc] | [next] | [standalone]

#1685101

On 3 July 2017 at 08:24, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
> if user plug out sd card slowly, finally card is plugged out but
> cat /proc/partitions can find that card is still exist in kernel.
> that's because alougth get card detect interrupt but CMD13 still
> can get correct response(all other pins are connected expect card
> detect pin).
> add ops->get_cd() can avoid this issue.
>
> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/mtk-sd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 5c1e178..975c765 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1585,6 +1585,7 @@ static void msdc_hw_reset(struct mmc_host *mmc)
>         .request = msdc_ops_request,
>         .set_ios = msdc_ops_set_ios,
>         .get_ro = mmc_gpio_get_ro,
> +       .get_cd = mmc_gpio_get_cd,
>         .start_signal_voltage_switch = msdc_ops_switch_volt,
>         .card_busy = msdc_card_busy,
>         .execute_tuning = msdc_execute_tuning,
> --
> 1.8.1.1.dirty
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web