Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1677470 > unrolled thread
| Started by | Abhishek Sahu <absahu@codeaurora.org> |
|---|---|
| First post | 2017-06-29 09:20 +0200 |
| Last post | 2017-07-03 08:30 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 03/14] qcom: mtd: nand: Fixed config error for BCH Abhishek Sahu <absahu@codeaurora.org> - 2017-06-29 09:20 +0200
Re: [PATCH 03/14] qcom: mtd: nand: Fixed config error for BCH Marek Vasut <marek.vasut@gmail.com> - 2017-06-29 12:00 +0200
Re: [PATCH 03/14] qcom: mtd: nand: Fixed config error for BCH Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-07-03 21:50 +0200
Re: [PATCH 03/14] qcom: mtd: nand: Fixed config error for BCH Abhishek Sahu <absahu@codeaurora.org> - 2017-07-17 08:40 +0200
Re: [PATCH 03/14] qcom: mtd: nand: Fixed config error for BCH Sricharan R <sricharan@codeaurora.org> - 2017-07-03 08:30 +0200
| From | Abhishek Sahu <absahu@codeaurora.org> |
|---|---|
| Date | 2017-06-29 09:20 +0200 |
| Subject | [PATCH 03/14] qcom: mtd: nand: Fixed config error for BCH |
| Message-ID | <tXBU8-4BD-37@gated-at.bofh.it> |
The configuration for BCH is not correct in the current driver so this patch fixed the same. Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> --- drivers/mtd/nand/qcom_nandc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c index 520add9..410ee53 100644 --- a/drivers/mtd/nand/qcom_nandc.c +++ b/drivers/mtd/nand/qcom_nandc.c @@ -1919,7 +1919,7 @@ static int qcom_nand_host_setup(struct qcom_nand_host *host) | wide_bus << WIDE_FLASH | 1 << DEV0_CFG1_ECC_DISABLE; - host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE + host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE | 0 << ECC_SW_RESET | host->cw_data << ECC_NUM_DATA_BYTES | 1 << ECC_FORCE_CLK_OPEN -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
[toc] | [next] | [standalone]
| From | Marek Vasut <marek.vasut@gmail.com> |
|---|---|
| Date | 2017-06-29 12:00 +0200 |
| Message-ID | <tXEoW-5YO-17@gated-at.bofh.it> |
| In reply to | #1677470 |
On 06/29/2017 09:15 AM, Abhishek Sahu wrote: > The configuration for BCH is not correct in the current > driver so this patch fixed the same. Fix the commit message, I have no idea what this patch does or fixes. > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> > --- > drivers/mtd/nand/qcom_nandc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c > index 520add9..410ee53 100644 > --- a/drivers/mtd/nand/qcom_nandc.c > +++ b/drivers/mtd/nand/qcom_nandc.c > @@ -1919,7 +1919,7 @@ static int qcom_nand_host_setup(struct qcom_nand_host *host) > | wide_bus << WIDE_FLASH > | 1 << DEV0_CFG1_ECC_DISABLE; > > - host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE > + host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE > | 0 << ECC_SW_RESET > | host->cw_data << ECC_NUM_DATA_BYTES > | 1 << ECC_FORCE_CLK_OPEN > -- Best regards, Marek Vasut
[toc] | [prev] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2017-07-03 21:50 +0200 |
| Message-ID | <tZfw7-65U-21@gated-at.bofh.it> |
| In reply to | #1677579 |
On Thu, 29 Jun 2017 11:49:07 +0200 Marek Vasut <marek.vasut@gmail.com> wrote: > On 06/29/2017 09:15 AM, Abhishek Sahu wrote: > > The configuration for BCH is not correct in the current > > driver so this patch fixed the same. > > Fix the commit message, I have no idea what this patch does or fixes. And please add a Fixes tag and Cc stable. > > > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> > > --- > > drivers/mtd/nand/qcom_nandc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c > > index 520add9..410ee53 100644 > > --- a/drivers/mtd/nand/qcom_nandc.c > > +++ b/drivers/mtd/nand/qcom_nandc.c > > @@ -1919,7 +1919,7 @@ static int qcom_nand_host_setup(struct qcom_nand_host *host) > > | wide_bus << WIDE_FLASH > > | 1 << DEV0_CFG1_ECC_DISABLE; > > > > - host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE > > + host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE > > | 0 << ECC_SW_RESET > > | host->cw_data << ECC_NUM_DATA_BYTES > > | 1 << ECC_FORCE_CLK_OPEN > > > >
[toc] | [prev] | [next] | [standalone]
| From | Abhishek Sahu <absahu@codeaurora.org> |
|---|---|
| Date | 2017-07-17 08:40 +0200 |
| Message-ID | <u47Rf-1rS-9@gated-at.bofh.it> |
| In reply to | #1680551 |
On 2017-07-04 01:17, Boris Brezillon wrote: > On Thu, 29 Jun 2017 11:49:07 +0200 > Marek Vasut <marek.vasut@gmail.com> wrote: > >> On 06/29/2017 09:15 AM, Abhishek Sahu wrote: >> > The configuration for BCH is not correct in the current >> > driver so this patch fixed the same. >> >> Fix the commit message, I have no idea what this patch does or fixes. > > And please add a Fixes tag and Cc stable. > Sure. I will amend the commit message to make it more clear and will include these tags. >> >> > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> >> > --- >> > drivers/mtd/nand/qcom_nandc.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/mtd/nand/qcom_nandc.c > b/drivers/mtd/nand/qcom_nandc.c >> > index 520add9..410ee53 100644 >> > --- a/drivers/mtd/nand/qcom_nandc.c >> > +++ b/drivers/mtd/nand/qcom_nandc.c >> > @@ -1919,7 +1919,7 @@ static int qcom_nand_host_setup(struct > qcom_nand_host *host) >> > | wide_bus << WIDE_FLASH >> > | 1 << DEV0_CFG1_ECC_DISABLE; >> > >> > - host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE >> > + host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE >> > | 0 << ECC_SW_RESET >> > | host->cw_data << ECC_NUM_DATA_BYTES >> > | 1 << ECC_FORCE_CLK_OPEN >> > >> >> -- Abhishek Sahu
[toc] | [prev] | [next] | [standalone]
| From | Sricharan R <sricharan@codeaurora.org> |
|---|---|
| Date | 2017-07-03 08:30 +0200 |
| Message-ID | <tZ31U-5Fr-15@gated-at.bofh.it> |
| In reply to | #1677470 |
Hi Abhishek, On 6/29/2017 12:45 PM, Abhishek Sahu wrote: > The configuration for BCH is not correct in the current > driver so this patch fixed the same. > > Signed-off-by: Abhishek Sahu <absahu@codeaurora.org> > --- > drivers/mtd/nand/qcom_nandc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c > index 520add9..410ee53 100644 > --- a/drivers/mtd/nand/qcom_nandc.c > +++ b/drivers/mtd/nand/qcom_nandc.c > @@ -1919,7 +1919,7 @@ static int qcom_nand_host_setup(struct qcom_nand_host *host) > | wide_bus << WIDE_FLASH > | 1 << DEV0_CFG1_ECC_DISABLE; > > - host->ecc_bch_cfg = host->bch_enabled << ECC_CFG_ECC_DISABLE > + host->ecc_bch_cfg = !host->bch_enabled << ECC_CFG_ECC_DISABLE > | 0 << ECC_SW_RESET > | host->cw_data << ECC_NUM_DATA_BYTES > | 1 << ECC_FORCE_CLK_OPEN > This could be patch #1, so basically all fixes first and then support for bam after that. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web