Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1679650 > unrolled thread

[PATCH] PCI: mediatek: Remove unnecessary PCI_REASSIGN_* flags

Started byRyder Lee <ryder.lee@mediatek.com>
First post2017-07-03 08:00 +0200
Last post2017-07-03 15:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] PCI: mediatek: Remove unnecessary PCI_REASSIGN_* flags Ryder Lee <ryder.lee@mediatek.com> - 2017-07-03 08:00 +0200
    Re: [PATCH] PCI: mediatek: Remove unnecessary PCI_REASSIGN_* flags Bjorn Helgaas <helgaas@kernel.org> - 2017-07-03 15:10 +0200

#1679650 — [PATCH] PCI: mediatek: Remove unnecessary PCI_REASSIGN_* flags

FromRyder Lee <ryder.lee@mediatek.com>
Date2017-07-03 08:00 +0200
Subject[PATCH] PCI: mediatek: Remove unnecessary PCI_REASSIGN_* flags
Message-ID<tZ2yR-5fc-5@gated-at.bofh.it>
The PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS flags are not needed,
since we should automatically assign resources if the firmware hasn't done it.

Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
---
 drivers/pci/host/pcie-mediatek.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c
index 51c6118..5a9d858 100644
--- a/drivers/pci/host/pcie-mediatek.c
+++ b/drivers/pci/host/pcie-mediatek.c
@@ -478,7 +478,6 @@ static int mtk_pcie_register_host(struct pci_host_bridge *host)
 	struct pci_bus *child;
 	int err;
 
-	pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
 	host->busnr = pcie->busn.start;
 	host->dev.parent = pcie->dev;
 	host->ops = &mtk_pcie_ops;
-- 
1.9.1

[toc] | [next] | [standalone]


#1679991

FromBjorn Helgaas <helgaas@kernel.org>
Date2017-07-03 15:10 +0200
Message-ID<tZ9h1-1TK-29@gated-at.bofh.it>
In reply to#1679650
On Mon, Jul 03, 2017 at 01:55:00PM +0800, Ryder Lee wrote:
> The PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS flags are not needed,
> since we should automatically assign resources if the firmware hasn't done it.
> 
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>

Folded into pci/host-mediatek, thanks!

> ---
>  drivers/pci/host/pcie-mediatek.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/host/pcie-mediatek.c b/drivers/pci/host/pcie-mediatek.c
> index 51c6118..5a9d858 100644
> --- a/drivers/pci/host/pcie-mediatek.c
> +++ b/drivers/pci/host/pcie-mediatek.c
> @@ -478,7 +478,6 @@ static int mtk_pcie_register_host(struct pci_host_bridge *host)
>  	struct pci_bus *child;
>  	int err;
>  
> -	pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS);
>  	host->busnr = pcie->busn.start;
>  	host->dev.parent = pcie->dev;
>  	host->ops = &mtk_pcie_ops;
> -- 
> 1.9.1
> 

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web