Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679336 > unrolled thread

[PATCH] media: vb2 dma-contig: Constify dma_buf_ops structures.

Back to article view | Back to linux.kernel

Contents

  [PATCH] media: vb2 dma-contig: Constify dma_buf_ops structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-01 13:30 +0200

#1679336 — [PATCH] media: vb2 dma-contig: Constify dma_buf_ops structures.

dma_buf_ops are not supposed to change at runtime. All functions
working with dma_buf_ops provided by <linux/dma-buf.h> work with
const dma_buf_ops. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
   6035	    272	      0	   6307	   18a3 drivers/media/v4l2-core/videobuf2-dma-contig.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   6155	    160	      0	   6315	   18ab drivers/media/v4l2-core/videobuf2-dma-contig.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/media/v4l2-core/videobuf2-dma-contig.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/v4l2-core/videobuf2-dma-contig.c b/drivers/media/v4l2-core/videobuf2-dma-contig.c
index 4f246d1..5b90a66 100644
--- a/drivers/media/v4l2-core/videobuf2-dma-contig.c
+++ b/drivers/media/v4l2-core/videobuf2-dma-contig.c
@@ -352,7 +352,7 @@ static int vb2_dc_dmabuf_ops_mmap(struct dma_buf *dbuf,
 	return vb2_dc_mmap(dbuf->priv, vma);
 }
 
-static struct dma_buf_ops vb2_dc_dmabuf_ops = {
+static const struct dma_buf_ops vb2_dc_dmabuf_ops = {
 	.attach = vb2_dc_dmabuf_ops_attach,
 	.detach = vb2_dc_dmabuf_ops_detach,
 	.map_dma_buf = vb2_dc_dmabuf_ops_map,
-- 
2.7.4

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web