Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1679188 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-07-01 00:40 +0200 |
| Last post | 2017-07-01 08:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-01 00:40 +0200
Re: [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe() Takashi Iwai <tiwai@suse.de> - 2017-07-01 08:10 +0200
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-07-01 00:40 +0200 |
| Subject | [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe() |
| Message-ID | <tYcJX-2TB-1@gated-at.bofh.it> |
platform_get_irq() returns an error code, but the ac97c
driver ignores it and always returns -ENXIO. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.
Notice that platform_get_irq() no longer returns 0 on error.
Print and propagate the return value of platform_get_irq on failure.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
sound/atmel/ac97c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index 65e6948..9d2c9d9 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -774,8 +774,8 @@ static int atmel_ac97c_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_dbg(&pdev->dev, "could not get irq\n");
- return -ENXIO;
+ dev_dbg(&pdev->dev, "could not get irq: %d\n", irq);
+ return irq;
}
pclk = clk_get(&pdev->dev, "ac97_clk");
--
2.5.0
[toc] | [next] | [standalone]
| From | Takashi Iwai <tiwai@suse.de> |
|---|---|
| Date | 2017-07-01 08:10 +0200 |
| Subject | Re: [PATCH] ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe() |
| Message-ID | <tYjLs-7JF-7@gated-at.bofh.it> |
| In reply to | #1679188 |
On Sat, 01 Jul 2017 00:34:23 +0200, Gustavo A. R. Silva wrote: > > platform_get_irq() returns an error code, but the ac97c > driver ignores it and always returns -ENXIO. This is not correct, > and prevents -EPROBE_DEFER from being propagated properly. > Notice that platform_get_irq() no longer returns 0 on error. > > Print and propagate the return value of platform_get_irq on failure. > > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Applied, thanks. Takashi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web