Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1679141 > unrolled thread
| Started by | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| First post | 2017-06-30 23:40 +0200 |
| Last post | 2017-07-01 00:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-06-30 23:40 +0200
Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 23:50 +0200
[PATCH v3] pata_imx: print error message on platform_get_irq failure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-01 00:10 +0200
| From | Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> |
|---|---|
| Date | 2017-06-30 23:40 +0200 |
| Subject | Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure |
| Message-ID | <tYbNT-2ht-7@gated-at.bofh.it> |
On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote:
> Print error message on platform_get_irq failure before return.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> Changes in v2:
> Print the return value of platform_get_irq on failure.
>
> drivers/ata/pata_imx.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c
> index d4caa23..66fb1ab 100644
> --- a/drivers/ata/pata_imx.c
> +++ b/drivers/ata/pata_imx.c
> @@ -132,9 +132,10 @@ static int pata_imx_probe(struct platform_device *pdev)
> int ret;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0)
> + if (irq < 0) {
> + dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq);
> return irq;
> -
> + }
Removing empty line here doesn't seem a good idea...
> priv = devm_kzalloc(&pdev->dev,
> sizeof(struct pata_imx_priv), GFP_KERNEL);
> if (!priv)
MBR, Sergei
[toc] | [next] | [standalone]
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-06-30 23:50 +0200 |
| Message-ID | <tYbXz-2kz-5@gated-at.bofh.it> |
| In reply to | #1679141 |
Quoting Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>:
> On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote:
>
>> Print error message on platform_get_irq failure before return.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>> Changes in v2:
>> Print the return value of platform_get_irq on failure.
>>
>> drivers/ata/pata_imx.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c
>> index d4caa23..66fb1ab 100644
>> --- a/drivers/ata/pata_imx.c
>> +++ b/drivers/ata/pata_imx.c
>> @@ -132,9 +132,10 @@ static int pata_imx_probe(struct platform_device *pdev)
>> int ret;
>>
>> irq = platform_get_irq(pdev, 0);
>> - if (irq < 0)
>> + if (irq < 0) {
>> + dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq);
>> return irq;
>> -
>> + }
>
> Removing empty line here doesn't seem a good idea...
>
Oh yeah, I agree.
I'll send v3 shortly.
Thanks!
--
Gustavo A. R. Silva
[toc] | [prev] | [next] | [standalone]
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-07-01 00:10 +0200 |
| Subject | [PATCH v3] pata_imx: print error message on platform_get_irq failure |
| Message-ID | <tYcgW-2I1-9@gated-at.bofh.it> |
| In reply to | #1679150 |
Print error message on platform_get_irq failure before return.
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
Changes in v2:
Print the return value of platform_get_irq on failure.
Changes in v3:
Put back the blank line after the IF closing brace,
which was accidentally removed in v2.
drivers/ata/pata_imx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c
index d4caa23..cdae3c0 100644
--- a/drivers/ata/pata_imx.c
+++ b/drivers/ata/pata_imx.c
@@ -132,8 +132,10 @@ static int pata_imx_probe(struct platform_device *pdev)
int ret;
irq = platform_get_irq(pdev, 0);
- if (irq < 0)
+ if (irq < 0) {
+ dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq);
return irq;
+ }
priv = devm_kzalloc(&pdev->dev,
sizeof(struct pata_imx_priv), GFP_KERNEL);
--
2.5.0
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web