Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679573 > unrolled thread

[PATCH] netxen_nic: Remove unused pointer hdr in netxen_setup_minidump()

Back to article view | Back to linux.kernel

Contents

  [PATCH] netxen_nic: Remove unused pointer hdr in netxen_setup_minidump() Christos Gkekas <chris.gekas@gmail.com> - 2017-07-03 00:20 +0200
    Re: [PATCH] netxen_nic: Remove unused pointer hdr in  netxen_setup_minidump() David Miller <davem@davemloft.net> - 2017-07-03 11:40 +0200

#1679573 — [PATCH] netxen_nic: Remove unused pointer hdr in netxen_setup_minidump()

Pointer hdr in netxen_setup_minidump() is set but never used, thus
should be removed.

Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
 drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c
index e306765..6cec2a6 100644
--- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c
+++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_ctx.c
@@ -174,7 +174,6 @@ netxen_setup_minidump(struct netxen_adapter *adapter)
 {
 	int err = 0, i;
 	u32 *template, *tmp_buf;
-	struct netxen_minidump_template_hdr *hdr;
 	err = netxen_get_minidump_template_size(adapter);
 	if (err) {
 		adapter->mdump.fw_supports_md = 0;
@@ -218,8 +217,6 @@ netxen_setup_minidump(struct netxen_adapter *adapter)
 	template = (u32 *) adapter->mdump.md_template;
 	for (i = 0; i < adapter->mdump.md_template_size/sizeof(u32); i++)
 		*template++ = __le32_to_cpu(*tmp_buf++);
-	hdr = (struct netxen_minidump_template_hdr *)
-				adapter->mdump.md_template;
 	adapter->mdump.md_capture_buff = NULL;
 	adapter->mdump.fw_supports_md = 1;
 	adapter->mdump.md_enabled = 0;
-- 
2.7.4

[toc] | [next] | [standalone]

#1679840 — Re: [PATCH] netxen_nic: Remove unused pointer hdr in netxen_setup_minidump()

From: Christos Gkekas <chris.gekas@gmail.com>
Date: Sun,  2 Jul 2017 23:16:11 +0100

> Pointer hdr in netxen_setup_minidump() is set but never used, thus
> should be removed.
> 
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>

Applied, thanks.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web