Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679513 > unrolled thread

[PATCH] Make Common clock framework a menuconfig to ease disabling it all

Back to article view | Back to linux.kernel

Contents

  [PATCH] Make Common clock framework a menuconfig to ease disabling it all Vincent Legoll <vincent.legoll@gmail.com> - 2017-07-02 18:10 +0200
    Re: [PATCH] Make Common clock framework a menuconfig to ease  disabling it all Stephen Boyd <sboyd@codeaurora.org> - 2017-07-05 23:20 +0200
      Re: [PATCH] Make Common clock framework a menuconfig to ease  disabling it all Vincent Legoll <vincent.legoll@gmail.com> - 2017-07-06 09:30 +0200

#1679513 — [PATCH] Make Common clock framework a menuconfig to ease disabling it all

No need to get into the submenu to disable all common clock framework
-related config entries

Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
---
 drivers/clk/Kconfig | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index 36cfea3..a1b174c 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -19,9 +19,12 @@ config COMMON_CLK
 	  Architectures utilizing the common struct clk should select
 	  this option.
 
-menu "Common Clock Framework"
+menuconfig COMMON_CLK_FRAMEWORK
+	tristate "Common Clock Framework"
 	depends on COMMON_CLK
 
+if COMMON_CLK_FRAMEWORK
+
 config COMMON_CLK_WM831X
 	tristate "Clock driver for WM831x/2x PMICs"
 	depends on MFD_WM831X
@@ -230,4 +233,4 @@ source "drivers/clk/tegra/Kconfig"
 source "drivers/clk/ti/Kconfig"
 source "drivers/clk/uniphier/Kconfig"
 
-endmenu
+endif # COMMON_CLK_FRAMEWORK
-- 
2.7.4

[toc] | [next] | [standalone]

#1681815 — Re: [PATCH] Make Common clock framework a menuconfig to ease disabling it all

On 07/02, Vincent Legoll wrote:
> No need to get into the submenu to disable all common clock framework
> -related config entries
> 
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
> ---
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 36cfea3..a1b174c 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -19,9 +19,12 @@ config COMMON_CLK
>  	  Architectures utilizing the common struct clk should select
>  	  this option.
>  
> -menu "Common Clock Framework"
> +menuconfig COMMON_CLK_FRAMEWORK
> +	tristate "Common Clock Framework"
>  	depends on COMMON_CLK

Wouldn't this put the clk drivers inside the drivers menu? Which
is already quite large right now. Plus this makes common clk
tristate which so far we haven't supported. No thanks.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [next] | [standalone]

#1682121 — Re: [PATCH] Make Common clock framework a menuconfig to ease disabling it all

Hello,

On Wed, Jul 5, 2017 at 11:15 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 07/02, Vincent Legoll wrote:
>> -menu "Common Clock Framework"
>> +menuconfig COMMON_CLK_FRAMEWORK
>> +     tristate "Common Clock Framework"
>>       depends on COMMON_CLK
>
> Wouldn't this put the clk drivers inside the drivers menu?

This does not move anything (at least I think), it just change the
already existing submenu into a menuconfig, which you can
choose to disable as a whole, which disable everything inside
that menuconfig. Maybe there are side effects visible outside
of this menu.

> Which is already quite large right now.

That's right, and I'm willing to tackle at least a part of this
problem, first by making it easier to disable whole chunks
at once.

> Plus this makes common clk
> tristate which so far we haven't supported. No thanks.

OK that was an oversight, I'll revisit later (going for the low
hanging fruits). But this is moot anyways, you should drop
that patch because it introduces new compile warnings on
ARM.

Sorry

-- 
Vincent Legoll

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web