Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1679436 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-07-02 11:10 +0200 |
| Last post | 2017-07-03 09:20 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] drm: radeon: radeon_ttm: constify ttm_place structures. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-07-02 11:10 +0200
Re: [PATCH] drm: radeon: radeon_ttm: constify ttm_place structures. Christian König <deathsimple@vodafone.de> - 2017-07-02 14:50 +0200
Re: [PATCH] drm: radeon: radeon_ttm: constify ttm_place structures. Christian König <deathsimple@vodafone.de> - 2017-07-03 09:20 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-07-02 11:10 +0200 |
| Subject | [PATCH] drm: radeon: radeon_ttm: constify ttm_place structures. |
| Message-ID | <tYJ3c-7OG-13@gated-at.bofh.it> |
ttm_place are not supposed to change at runtime. All functions
working with ttm_place provided by <drm/ttm/ttm_placement.h> work
with const ttm_place. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
9235 344 136 9715 25f3 drivers/gpu/drm/radeon/radeon_ttm.o
File size After adding 'const':
text data bss dec hex filename
9267 312 136 9715 25f3 drivers/gpu/drm/radeon/radeon_ttm.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 8b7623b..6499832 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -178,7 +178,7 @@ static int radeon_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
static void radeon_evict_flags(struct ttm_buffer_object *bo,
struct ttm_placement *placement)
{
- static struct ttm_place placements = {
+ static const struct ttm_place placements = {
.fpfn = 0,
.lpfn = 0,
.flags = TTM_PL_MASK_CACHING | TTM_PL_FLAG_SYSTEM
--
2.7.4
[toc] | [next] | [standalone]
| From | Christian König <deathsimple@vodafone.de> |
|---|---|
| Date | 2017-07-02 14:50 +0200 |
| Message-ID | <tYMu6-1Un-7@gated-at.bofh.it> |
| In reply to | #1679436 |
Am 02.07.2017 um 11:06 schrieb Arvind Yadav:
> ttm_place are not supposed to change at runtime. All functions
> working with ttm_place provided by <drm/ttm/ttm_placement.h> work
> with const ttm_place. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 9235 344 136 9715 25f3 drivers/gpu/drm/radeon/radeon_ttm.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 9267 312 136 9715 25f3 drivers/gpu/drm/radeon/radeon_ttm.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 8b7623b..6499832 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -178,7 +178,7 @@ static int radeon_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
> static void radeon_evict_flags(struct ttm_buffer_object *bo,
> struct ttm_placement *placement)
> {
> - static struct ttm_place placements = {
> + static const struct ttm_place placements = {
> .fpfn = 0,
> .lpfn = 0,
> .flags = TTM_PL_MASK_CACHING | TTM_PL_FLAG_SYSTEM
[toc] | [prev] | [next] | [standalone]
| From | Christian König <deathsimple@vodafone.de> |
|---|---|
| Date | 2017-07-03 09:20 +0200 |
| Message-ID | <tZ3Oh-6fi-3@gated-at.bofh.it> |
| In reply to | #1679436 |
Am 02.07.2017 um 11:06 schrieb Arvind Yadav:
> ttm_place are not supposed to change at runtime. All functions
> working with ttm_place provided by <drm/ttm/ttm_placement.h> work
> with const ttm_place. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 9235 344 136 9715 25f3 drivers/gpu/drm/radeon/radeon_ttm.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 9267 312 136 9715 25f3 drivers/gpu/drm/radeon/radeon_ttm.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 8b7623b..6499832 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -178,7 +178,7 @@ static int radeon_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
> static void radeon_evict_flags(struct ttm_buffer_object *bo,
> struct ttm_placement *placement)
> {
> - static struct ttm_place placements = {
> + static const struct ttm_place placements = {
> .fpfn = 0,
> .lpfn = 0,
> .flags = TTM_PL_MASK_CACHING | TTM_PL_FLAG_SYSTEM
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web