Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1678530 > unrolled thread

Question regarding MAX_ARG_STRLEN with execve()

Started byAnshuman Khandual <khandual@linux.vnet.ibm.com>
First post2017-06-30 08:40 +0200
Last post2017-07-03 11:30 +0200
Articles 4 — 2 participants

Back to article view | Back to linux.kernel

Contents

  Question regarding MAX_ARG_STRLEN with execve() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-06-30 08:40 +0200
    Re: Question regarding MAX_ARG_STRLEN with execve() Michal Hocko <mhocko@kernel.org> - 2017-06-30 16:30 +0200
      Re: Question regarding MAX_ARG_STRLEN with execve() Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-07-03 10:30 +0200
        Re: Question regarding MAX_ARG_STRLEN with execve() Michal Hocko <mhocko@kernel.org> - 2017-07-03 11:30 +0200

#1678530 — Question regarding MAX_ARG_STRLEN with execve()

FromAnshuman Khandual <khandual@linux.vnet.ibm.com>
Date2017-06-30 08:40 +0200
SubjectQuestion regarding MAX_ARG_STRLEN with execve()
Message-ID<tXXKV-1TC-5@gated-at.bofh.it>
Hello,

execve() system call should support argument length of
MAX_ARG_STRLEN (PAGE_SIZE * 32). On 64K page size systems, we
are not able to pass 32 * PAGE_SIZE arguments into the execve()
system call because of the following reasons.

* struct linux_binprm's vma starts with a size of PAGE_SIZE

	vma->vm_end = STACK_TOP_MAX;
	vma->vm_start = vma->vm_end - PAGE_SIZE;

* The VMA expands as much depending upon the argument size. So
  for 32 * PAGE_SIZE argument, it becomes 33 * PAGE_SIZE.

* 33 * PAGE_SIZE with 64K pages fails the following test in
  get_arg_page() function. 33 * PAGE_SIZE is more than 2MB
  (8 MB /4) with 64K page size.

   if (size > READ_ONCE(rlim[RLIMIT_STACK].rlim_cur) / 4)

* Right now RLIMIT_STACK is hard coded 8MB which does not take
  PAGE_SIZE into account. 

Wondering what should be the solution for this problem ?

* Change the default stack size from 8MB ?
* Change the ratio test from 1/4th ?

Thoughts ?

Regards
Anshuman

[toc] | [next] | [standalone]

#1678878

FromMichal Hocko <mhocko@kernel.org>
Date2017-06-30 16:30 +0200
Message-ID<tY55M-6Ah-11@gated-at.bofh.it>
In reply to#1678530
On Fri 30-06-17 11:59:37, Anshuman Khandual wrote:
> Hello,
> 
> execve() system call should support argument length of
> MAX_ARG_STRLEN (PAGE_SIZE * 32). On 64K page size systems, we
> are not able to pass 32 * PAGE_SIZE arguments into the execve()
> system call because of the following reasons.
> 
> * struct linux_binprm's vma starts with a size of PAGE_SIZE
> 
> 	vma->vm_end = STACK_TOP_MAX;
> 	vma->vm_start = vma->vm_end - PAGE_SIZE;
> 
> * The VMA expands as much depending upon the argument size. So
>   for 32 * PAGE_SIZE argument, it becomes 33 * PAGE_SIZE.
> 
> * 33 * PAGE_SIZE with 64K pages fails the following test in
>   get_arg_page() function. 33 * PAGE_SIZE is more than 2MB
>   (8 MB /4) with 64K page size.
> 
>    if (size > READ_ONCE(rlim[RLIMIT_STACK].rlim_cur) / 4)
> 
> * Right now RLIMIT_STACK is hard coded 8MB which does not take
>   PAGE_SIZE into account. 
> 
> Wondering what should be the solution for this problem ?
> 
> * Change the default stack size from 8MB ?

just increase the ulimit if you want to use such a large arguments.

> * Change the ratio test from 1/4th ?

-- 
Michal Hocko
SUSE Labs

[toc] | [prev] | [next] | [standalone]

#1679757

FromAnshuman Khandual <khandual@linux.vnet.ibm.com>
Date2017-07-03 10:30 +0200
Message-ID<tZ4U3-6WV-21@gated-at.bofh.it>
In reply to#1678878
On 06/30/2017 07:52 PM, Michal Hocko wrote:
> On Fri 30-06-17 11:59:37, Anshuman Khandual wrote:
>> Hello,
>>
>> execve() system call should support argument length of
>> MAX_ARG_STRLEN (PAGE_SIZE * 32). On 64K page size systems, we
>> are not able to pass 32 * PAGE_SIZE arguments into the execve()
>> system call because of the following reasons.
>>
>> * struct linux_binprm's vma starts with a size of PAGE_SIZE
>>
>> 	vma->vm_end = STACK_TOP_MAX;
>> 	vma->vm_start = vma->vm_end - PAGE_SIZE;
>>
>> * The VMA expands as much depending upon the argument size. So
>>   for 32 * PAGE_SIZE argument, it becomes 33 * PAGE_SIZE.
>>
>> * 33 * PAGE_SIZE with 64K pages fails the following test in
>>   get_arg_page() function. 33 * PAGE_SIZE is more than 2MB
>>   (8 MB /4) with 64K page size.
>>
>>    if (size > READ_ONCE(rlim[RLIMIT_STACK].rlim_cur) / 4)
>>
>> * Right now RLIMIT_STACK is hard coded 8MB which does not take
>>   PAGE_SIZE into account. 
>>
>> Wondering what should be the solution for this problem ?
>>
>> * Change the default stack size from 8MB ?
> just increase the ulimit if you want to use such a large arguments.
> 

Yeah that is possible but it does not still offset the fact that
the calculation is broken on the page size of 64K. I mean, yeah
its not practical to have such a large argument. But the point
is whether we would want to support the MAX_ARG_STRLEN semantic
for execve system call or not. At present its broken for 64K
and I am asking whether we will be willing to revisit the
'1/4th of the stack' condition.

[toc] | [prev] | [next] | [standalone]

#1679818

FromMichal Hocko <mhocko@kernel.org>
Date2017-07-03 11:30 +0200
Message-ID<tZ5Q7-7za-15@gated-at.bofh.it>
In reply to#1679757
On Mon 03-07-17 13:58:59, Anshuman Khandual wrote:
> On 06/30/2017 07:52 PM, Michal Hocko wrote:
> > On Fri 30-06-17 11:59:37, Anshuman Khandual wrote:
> >> Hello,
> >>
> >> execve() system call should support argument length of
> >> MAX_ARG_STRLEN (PAGE_SIZE * 32). On 64K page size systems, we
> >> are not able to pass 32 * PAGE_SIZE arguments into the execve()
> >> system call because of the following reasons.
> >>
> >> * struct linux_binprm's vma starts with a size of PAGE_SIZE
> >>
> >> 	vma->vm_end = STACK_TOP_MAX;
> >> 	vma->vm_start = vma->vm_end - PAGE_SIZE;
> >>
> >> * The VMA expands as much depending upon the argument size. So
> >>   for 32 * PAGE_SIZE argument, it becomes 33 * PAGE_SIZE.
> >>
> >> * 33 * PAGE_SIZE with 64K pages fails the following test in
> >>   get_arg_page() function. 33 * PAGE_SIZE is more than 2MB
> >>   (8 MB /4) with 64K page size.
> >>
> >>    if (size > READ_ONCE(rlim[RLIMIT_STACK].rlim_cur) / 4)
> >>
> >> * Right now RLIMIT_STACK is hard coded 8MB which does not take
> >>   PAGE_SIZE into account. 
> >>
> >> Wondering what should be the solution for this problem ?
> >>
> >> * Change the default stack size from 8MB ?
> > just increase the ulimit if you want to use such a large arguments.
> > 
> 
> Yeah that is possible but it does not still offset the fact that
> the calculation is broken on the page size of 64K. I mean, yeah
> its not practical to have such a large argument. But the point
> is whether we would want to support the MAX_ARG_STRLEN semantic
> for execve system call or not. At present its broken for 64K
> and I am asking whether we will be willing to revisit the
> '1/4th of the stack' condition.

I dunno. We have this 1/4 of RLIMIT semantic for years and it doesn't
seem there were any bug reports. Yes, MAX_ARG_STRLEN being PAGE_SIZE
dependent is unfortunate because it makes an arch independent default
ulimit hard to get right but I am not sure we actually have to lose
sleep over this.

Or do you have any specific proposal how to "fix" this limitation which
wouldn't break other userspace?
-- 
Michal Hocko
SUSE Labs

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web