Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1675933 > unrolled thread

[PATCHv2 9/9] spi: spidev: add Aardvark to device tree compatibility list

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCHv2 9/9] spi: spidev: add Aardvark to device tree compatibility list Amelie Delaunay <amelie.delaunay@st.com> - 2017-06-27 17:50 +0200
    Re: [PATCHv2 9/9] spi: spidev: add Aardvark to device tree  compatibility list Mark Brown <broonie@kernel.org> - 2017-06-28 21:30 +0200
      Re: [PATCHv2 9/9] spi: spidev: add Aardvark to device tree  compatibility list Amelie DELAUNAY <amelie.delaunay@st.com> - 2017-06-29 15:00 +0200
        Re: [PATCHv2 9/9] spi: spidev: add Aardvark to device tree  compatibility list Mark Brown <broonie@kernel.org> - 2017-06-30 14:00 +0200

#1675933 — [PATCHv2 9/9] spi: spidev: add Aardvark to device tree compatibility list

This patch adds an entry for the TotalPhase Aardvark SPI Host Adapter,
which can operate as an SPI Slave.

Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
---
 drivers/spi/spidev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c
index 9a2a79a..8093885 100644
--- a/drivers/spi/spidev.c
+++ b/drivers/spi/spidev.c
@@ -698,6 +698,7 @@ static int spidev_release(struct inode *inode, struct file *filp)
 	{ .compatible = "lineartechnology,ltc2488" },
 	{ .compatible = "ge,achc" },
 	{ .compatible = "semtech,sx1301" },
+	{ .compatible = "totalphase,aardvark" },
 	{},
 };
 MODULE_DEVICE_TABLE(of, spidev_dt_ids);
-- 
1.9.1

[toc] | [next] | [standalone]

#1677102 — Re: [PATCHv2 9/9] spi: spidev: add Aardvark to device tree compatibility list

[Multipart message — attachments visible in raw view] — view raw

On Tue, Jun 27, 2017 at 05:45:21PM +0200, Amelie Delaunay wrote:
> This patch adds an entry for the TotalPhase Aardvark SPI Host Adapter,
> which can operate as an SPI Slave.

What does this device actually do and why is spidev a sensible fit for
it?

[toc] | [prev] | [next] | [standalone]

#1677725 — Re: [PATCHv2 9/9] spi: spidev: add Aardvark to device tree compatibility list

On 06/28/2017 08:54 PM, Mark Brown wrote:
> On Tue, Jun 27, 2017 at 05:45:21PM +0200, Amelie Delaunay wrote:
>> This patch adds an entry for the TotalPhase Aardvark SPI Host Adapter,
>> which can operate as an SPI Slave.
> 
> What does this device actually do and why is spidev a sensible fit for
> it?
> 
This device is actually a debugging tool [1] which can work on SPI bus 
(and also I2C). Connected via USB on a PC, it can either acts as an SPI 
master or SPI slave and it can transmit/receive serial data using SPI 
protocol. Polarity, Phase, Bit Order, Frequency can be configured. So 
this tool is really useful during SPI driver development to 
troubleshoot. And that's why spidev driver totally fit for it when used 
as an SPI slave, for the reason described in spidev Documentation: 
"Developing simple protocols used to talk to" Aardvark "acting as SPI 
slaves, which you may need to change quite often".

[1] https://www.totalphase.com/products/aardvark-i2cspi/

[toc] | [prev] | [next] | [standalone]

#1678729 — Re: [PATCHv2 9/9] spi: spidev: add Aardvark to device tree compatibility list

[Multipart message — attachments visible in raw view] — view raw

On Thu, Jun 29, 2017 at 02:58:43PM +0200, Amelie DELAUNAY wrote:
> On 06/28/2017 08:54 PM, Mark Brown wrote:

> > What does this device actually do and why is spidev a sensible fit for
> > it?

> This device is actually a debugging tool [1] which can work on SPI bus (and
> also I2C). Connected via USB on a PC, it can either acts as an SPI master or
> SPI slave and it can transmit/receive serial data using SPI protocol.
> Polarity, Phase, Bit Order, Frequency can be configured. So this tool is
> really useful during SPI driver development to troubleshoot. And that's why
> spidev driver totally fit for it when used as an SPI slave, for the reason
> described in spidev Documentation: "Developing simple protocols used to talk
> to" Aardvark "acting as SPI slaves, which you may need to change quite
> often".

This doesn't seem like something that should be in DT, it's a tool used
to implement or emulate other things and is no more specific than spidev
itself is.  Whatever it is implementing or emulating should be in DT
instead.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web