Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1675610 > unrolled thread

[PATCH] dma: fsl_raid: make of_device_ids const.

Back to article view | Back to linux.kernel

Contents

  [PATCH] dma: fsl_raid: make of_device_ids const. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-27 14:10 +0200
    Re: [PATCH] dma: fsl_raid: make of_device_ids const. Vinod Koul <vinod.koul@intel.com> - 2017-06-29 06:00 +0200

#1675610 — [PATCH] dma: fsl_raid: make of_device_ids const.

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
   3981	    608	      0	   4589	   11ed	drivers/dma/fsl_raid.o

File size after constify:
   text	   data	    bss	    dec	    hex	filename
   4381	    192	      0	   4573	   11dd	drivers/dma/fsl_raid.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/dma/fsl_raid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/fsl_raid.c b/drivers/dma/fsl_raid.c
index 90d29f9..493dc6c 100644
--- a/drivers/dma/fsl_raid.c
+++ b/drivers/dma/fsl_raid.c
@@ -877,7 +877,7 @@ static int fsl_re_remove(struct platform_device *ofdev)
 	return 0;
 }
 
-static struct of_device_id fsl_re_ids[] = {
+static const struct of_device_id fsl_re_ids[] = {
 	{ .compatible = "fsl,raideng-v1.0", },
 	{}
 };
-- 
1.9.1

[toc] | [next] | [standalone]

#1677366

On Tue, Jun 27, 2017 at 05:38:27PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.

Please ensure you use the right subsystem tags for sending a patch, Git log
for that file or dir should tell you the convention to use, fixed that and
applied now, thanks

-- 
~Vinod

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web