Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677124 > unrolled thread

[PATCH] sched/numa: fix build without CONFIG_NUMA_BALANCING

Back to article view | Back to linux.kernel

Contents

  [PATCH] sched/numa: fix build without CONFIG_NUMA_BALANCING Arnd Bergmann <arnd@arndb.de> - 2017-06-28 22:10 +0200
    Re: [PATCH] sched/numa: fix build without CONFIG_NUMA_BALANCING Rik van Riel <riel@redhat.com> - 2017-06-28 22:50 +0200

#1677124 — [PATCH] sched/numa: fix build without CONFIG_NUMA_BALANCING

I ran into a build error:

kernel/sched/fair.c:2655:44: error: 'struct sched_domain' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]

Adding a forward declaration for the struct name is sufficient
to avoid it.

Fixes: 3fed382b46ba ("sched/numa: Implement NUMA node level wake_affine()")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 kernel/sched/fair.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 6f4f155adf5f..eea8f0b7d9c0 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2652,6 +2652,7 @@ static inline void account_numa_dequeue(struct rq *rq, struct task_struct *p)
 {
 }
 
+struct sched_domain;
 static inline bool numa_wake_affine(struct sched_domain *sd,
 				    struct task_struct *p, int this_cpu,
 				    int prev_cpu, int sync)
-- 
2.9.0

[toc] | [next] | [standalone]

#1677159

[Multipart message — attachments visible in raw view] — view raw

On Wed, 2017-06-28 at 22:05 +0200, Arnd Bergmann wrote:
> I ran into a build error:
> 
> kernel/sched/fair.c:2655:44: error: 'struct sched_domain' declared
> inside parameter list will not be visible outside of this definition
> or declaration [-Werror]
> 
> Adding a forward declaration for the struct name is sufficient
> to avoid it.
> 
> Fixes: 3fed382b46ba ("sched/numa: Implement NUMA node level
> wake_affine()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Peter pointed out another problem with that patch.

I am running a few tests now on a kernel with that
other bug fixed, which should also magically get
rid of this compiler warning.

-- 
All rights reversed

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web