Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1671545 > unrolled thread
| Started by | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| First post | 2017-06-21 11:30 +0200 |
| Last post | 2017-06-28 20:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ath10k: add const to thermal_cooling_device_ops structure Bhumika Goyal <bhumirks@gmail.com> - 2017-06-21 11:30 +0200
Re: ath10k: add const to thermal_cooling_device_ops structure Kalle Valo <kvalo@qca.qualcomm.com> - 2017-06-28 20:00 +0200
| From | Bhumika Goyal <bhumirks@gmail.com> |
|---|---|
| Date | 2017-06-21 11:30 +0200 |
| Subject | [PATCH] ath10k: add const to thermal_cooling_device_ops structure |
| Message-ID | <tUK7x-4ih-51@gated-at.bofh.it> |
Declare thermal_cooling_device_ops structure as const as it is only passed
as an argument to the function thermal_cooling_device_register and this
argument is of type const. So, declare the structure as const.
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/net/wireless/ath/ath10k/thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/thermal.c b/drivers/net/wireless/ath/ath10k/thermal.c
index 87948af..ef717b6 100644
--- a/drivers/net/wireless/ath/ath10k/thermal.c
+++ b/drivers/net/wireless/ath/ath10k/thermal.c
@@ -63,7 +63,7 @@ ath10k_thermal_set_cur_throttle_state(struct thermal_cooling_device *cdev,
return 0;
}
-static struct thermal_cooling_device_ops ath10k_thermal_ops = {
+static const struct thermal_cooling_device_ops ath10k_thermal_ops = {
.get_max_state = ath10k_thermal_get_max_throttle_state,
.get_cur_state = ath10k_thermal_get_cur_throttle_state,
.set_cur_state = ath10k_thermal_set_cur_throttle_state,
--
2.7.4
[toc] | [next] | [standalone]
| From | Kalle Valo <kvalo@qca.qualcomm.com> |
|---|---|
| Date | 2017-06-28 20:00 +0200 |
| Subject | Re: ath10k: add const to thermal_cooling_device_ops structure |
| Message-ID | <tXpq4-t5-199@gated-at.bofh.it> |
| In reply to | #1671545 |
Bhumika Goyal <bhumirks@gmail.com> wrote: > Declare thermal_cooling_device_ops structure as const as it is only passed > as an argument to the function thermal_cooling_device_register and this > argument is of type const. So, declare the structure as const. > > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com> > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 1cdb6c9fd433 ath10k: add const to thermal_cooling_device_ops structure -- https://patchwork.kernel.org/patch/9801291/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web