Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1678566 > unrolled thread

[PATCH] dmaengine: idma64: print error message on platform_get_irq failure

Back to article view | Back to linux.kernel

Contents

  [PATCH] dmaengine: idma64: print error message on platform_get_irq  failure "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 09:40 +0200
    Re: [PATCH] dmaengine: idma64: print error message on  platform_get_irq failure Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2017-06-30 10:20 +0200

#1678566 — [PATCH] dmaengine: idma64: print error message on platform_get_irq failure

Print error message on platform_get_irq failure before return.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/dma/idma64.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c
index 1953e57..08ade66 100644
--- a/drivers/dma/idma64.c
+++ b/drivers/dma/idma64.c
@@ -637,8 +637,10 @@ static int idma64_platform_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	chip->irq = platform_get_irq(pdev, 0);
-	if (chip->irq < 0)
+	if (chip->irq < 0) {
+		dev_err(dev, "failed to get IRQ: %d\n", chip->irq);
 		return chip->irq;
+	}
 
 	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	chip->regs = devm_ioremap_resource(dev, mem);
-- 
2.5.0

[toc] | [next] | [standalone]

#1678590 — Re: [PATCH] dmaengine: idma64: print error message on platform_get_irq failure

Hello Gustavo,

On 06/30/2017 10:34 AM, Gustavo A. R. Silva wrote:
> Print error message on platform_get_irq failure before return.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/dma/idma64.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c
> index 1953e57..08ade66 100644
> --- a/drivers/dma/idma64.c
> +++ b/drivers/dma/idma64.c
> @@ -637,8 +637,10 @@ static int idma64_platform_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  
>  	chip->irq = platform_get_irq(pdev, 0);
> -	if (chip->irq < 0)
> +	if (chip->irq < 0) {
> +		dev_err(dev, "failed to get IRQ: %d\n", chip->irq);
>  		return chip->irq;
> +	}
>  
>  	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	chip->regs = devm_ioremap_resource(dev, mem);
> 

you do it wrong, please *immedately* stop sending this kind of patches
and revoke all the ones which you have sent so far, one revoke message
for each sent patch is expected.

1) there must be no error level message printed out, if the returned
   by platform_get_irq() value is -EPROBE_DEFER, this notice makes
   all your patches *invalid*,

2) if you wish it, add the error message directly into platform_get_irq(),
   then *remove* any similar error messages from the individual drivers.

--
With best wishes,
Vladimir

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web