Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1678447 > unrolled thread

linux-next: build warning after merge of the drivers-x86 tree

Started byStephen Rothwell <sfr@canb.auug.org.au>
First post2017-06-30 06:10 +0200
Last post2017-07-01 05:40 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  linux-next: build warning after merge of the drivers-x86 tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-30 06:10 +0200
    Re: linux-next: build warning after merge of the drivers-x86 tree Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-30 07:20 +0200
    Re: linux-next: build warning after merge of the drivers-x86 tree Darren Hart <dvhart@infradead.org> - 2017-07-01 05:40 +0200

#1678447 — linux-next: build warning after merge of the drivers-x86 tree

FromStephen Rothwell <sfr@canb.auug.org.au>
Date2017-06-30 06:10 +0200
Subjectlinux-next: build warning after merge of the drivers-x86 tree
Message-ID<tXVpM-np-3@gated-at.bofh.it>
Hi Darren,

After merging the drivers-x86 tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
  key_dev->keycode = &sony_laptop_input_keycode_map;
                   ^

Introduced by commit

  a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")

-- 
Cheers,
Stephen Rothwell

[toc] | [next] | [standalone]


#1678480

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-06-30 07:20 +0200
Message-ID<tXWvw-1aa-9@gated-at.bofh.it>
In reply to#1678447
Hi,
      I have push one more patch which does not have this warning.
please avoid my first patch.

Thanks
~ arvind

On Friday 30 June 2017 09:30 AM, Stephen Rothwell wrote:
> Hi Darren,
>
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
> drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
>    key_dev->keycode = &sony_laptop_input_keycode_map;
>                     ^
>
> Introduced by commit
>
>    a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")
>

[toc] | [prev] | [next] | [standalone]


#1679260

FromDarren Hart <dvhart@infradead.org>
Date2017-07-01 05:40 +0200
Message-ID<tYhqk-5Tv-57@gated-at.bofh.it>
In reply to#1678447
On Fri, Jun 30, 2017 at 02:00:54PM +1000, Stephen Rothwell wrote:
> Hi Darren,
> 
> After merging the drivers-x86 tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
> drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
>   key_dev->keycode = &sony_laptop_input_keycode_map;
>                    ^
> 
> Introduced by commit
> 
>   a0f0a5e1978b ("platform/x86: sony-laptop: constify few static structures")

Apologies, and thanks for the catch. Rolled the fix from Arnd together with this
and the new one from Arvind. for-next had to be rebased to avoid introducing
this error into mainline.

-- 
Darren Hart
VMware Open Source Technology Center

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web