Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1678223 > unrolled thread
| Started by | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| First post | 2017-06-29 23:50 +0200 |
| Last post | 2017-06-30 01:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[RESEND PATCH] spmi: Include OF based modalias in device uevent Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-06-29 23:50 +0200
Re: [RESEND PATCH] spmi: Include OF based modalias in device uevent Rob Clark <robdclark@gmail.com> - 2017-06-30 01:10 +0200
| From | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| Date | 2017-06-29 23:50 +0200 |
| Subject | [RESEND PATCH] spmi: Include OF based modalias in device uevent |
| Message-ID | <tXPu2-4Pd-15@gated-at.bofh.it> |
Include the OF-based modalias in the uevent sent when registering SPMI
devices, so that user space has a chance to autoload the kernel module
for the device.
Tested-by: Rob Clark <robdclark@gmail.com>
Reported-by: Rob Clark <robdclark@gmail.com>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Resend to collect Rob's T-b and Stephen's R-b, and add Greg as recipient.
drivers/spmi/spmi.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index 2b9b0941d9eb..6d23226e5f69 100644
--- a/drivers/spmi/spmi.c
+++ b/drivers/spmi/spmi.c
@@ -365,11 +365,23 @@ static int spmi_drv_remove(struct device *dev)
return 0;
}
+static int spmi_drv_uevent(struct device *dev, struct kobj_uevent_env *env)
+{
+ int ret;
+
+ ret = of_device_uevent_modalias(dev, env);
+ if (ret != -ENODEV)
+ return ret;
+
+ return 0;
+}
+
static struct bus_type spmi_bus_type = {
.name = "spmi",
.match = spmi_device_match,
.probe = spmi_drv_probe,
.remove = spmi_drv_remove,
+ .uevent = spmi_drv_uevent,
};
/**
--
2.12.0
[toc] | [next] | [standalone]
| From | Rob Clark <robdclark@gmail.com> |
|---|---|
| Date | 2017-06-30 01:10 +0200 |
| Message-ID | <tXQJr-5OH-7@gated-at.bofh.it> |
| In reply to | #1678223 |
On Thu, Jun 29, 2017 at 5:46 PM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> Include the OF-based modalias in the uevent sent when registering SPMI
> devices, so that user space has a chance to autoload the kernel module
> for the device.
>
> Tested-by: Rob Clark <robdclark@gmail.com>
> Reported-by: Rob Clark <robdclark@gmail.com>
> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
And probably make sense to:
Cc: <stable@vger.kernel.org>
> ---
>
> Resend to collect Rob's T-b and Stephen's R-b, and add Greg as recipient.
>
> drivers/spmi/spmi.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
> index 2b9b0941d9eb..6d23226e5f69 100644
> --- a/drivers/spmi/spmi.c
> +++ b/drivers/spmi/spmi.c
> @@ -365,11 +365,23 @@ static int spmi_drv_remove(struct device *dev)
> return 0;
> }
>
> +static int spmi_drv_uevent(struct device *dev, struct kobj_uevent_env *env)
> +{
> + int ret;
> +
> + ret = of_device_uevent_modalias(dev, env);
> + if (ret != -ENODEV)
> + return ret;
> +
> + return 0;
> +}
> +
> static struct bus_type spmi_bus_type = {
> .name = "spmi",
> .match = spmi_device_match,
> .probe = spmi_drv_probe,
> .remove = spmi_drv_remove,
> + .uevent = spmi_drv_uevent,
> };
>
> /**
> --
> 2.12.0
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web