Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1676327 > unrolled thread

[PATCH] Staging: unisys: visorbus: Fix coding style warning from checkpatch.pl.

Back to article view | Back to linux.kernel

Contents

  [PATCH] Staging: unisys: visorbus: Fix coding style warning from checkpatch.pl. Quytelda Kahja <quytelda@tamalin.org> - 2017-06-28 04:50 +0200
    Re: [PATCH] Staging: unisys: visorbus: Fix coding style warning from checkpatch.pl. Frans Klaver <fransklaver@gmail.com> - 2017-06-28 10:40 +0200
    Re: [PATCH] Staging: unisys: visorbus: Fix coding style warning from  checkpatch.pl. Greg KH <gregkh@linuxfoundation.org> - 2017-06-29 16:40 +0200

#1676327 — [PATCH] Staging: unisys: visorbus: Fix coding style warning from checkpatch.pl.

Replace the literal function name "visorbus_create_instance" with the format
specifier "%s" so it can be dynamically filled by the __func__ macro.

Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
---
 drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 1c785dd19ddd..1c6dc3a3e64a 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -1030,7 +1030,7 @@ visorbus_create_instance(struct visor_device *dev)
 err_debugfs_dir:
 	debugfs_remove_recursive(dev->debugfs_dir);
 	kfree(hdr_info);
-	dev_err(&dev->device, "visorbus_create_instance failed: %d\n", err);
+	dev_err(&dev->device, "%s failed: %d\n", __func__, err);
 	return err;
 }
 
-- 
2.13.2

[toc] | [next] | [standalone]

#1676445

Hi,

On Wed, Jun 28, 2017 at 4:49 AM, Quytelda Kahja <quytelda@tamalin.org> wrote:
> Replace the literal function name "visorbus_create_instance" with the format
> specifier "%s" so it can be dynamically filled by the __func__ macro.

On a general note, I think the actual change or effect is more import
to mention in the subject than the fact that you "fix some issue
highlighted by checkpatch".

Something like

Subject: [PATCH] staging: unisys: visorbus: use __func__ instead of
function name

Of course you can still mention that checkpatch highlighted the issue
for you in the description.

>
> Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
> index 1c785dd19ddd..1c6dc3a3e64a 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -1030,7 +1030,7 @@ visorbus_create_instance(struct visor_device *dev)
>  err_debugfs_dir:
>         debugfs_remove_recursive(dev->debugfs_dir);
>         kfree(hdr_info);
> -       dev_err(&dev->device, "visorbus_create_instance failed: %d\n", err);
> +       dev_err(&dev->device, "%s failed: %d\n", __func__, err);
>         return err;
>  }

It looks sane, anyway.

Frans

[toc] | [prev] | [next] | [standalone]

#1677825 — Re: [PATCH] Staging: unisys: visorbus: Fix coding style warning from checkpatch.pl.

On Tue, Jun 27, 2017 at 07:49:05PM -0700, Quytelda Kahja wrote:
> Replace the literal function name "visorbus_create_instance" with the format
> specifier "%s" so it can be dynamically filled by the __func__ macro.
> 
> Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

When you make a new version of a patch, always correctly version it, as
the documentation tells you to do.

Please fix that up here and resend.

thanks,

greg k-h

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web