Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1677446 > unrolled thread

[PATCH] nvme: Makefile: remove dead build rule

Started byValentin Rothberg <vrothberg@suse.com>
First post2017-06-29 09:00 +0200
Last post2017-06-29 17:00 +0200
Articles 4 — 4 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] nvme: Makefile: remove dead build rule Valentin Rothberg <vrothberg@suse.com> - 2017-06-29 09:00 +0200
    Re: [PATCH] nvme: Makefile: remove dead build rule Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-29 10:40 +0200
    Re: [PATCH] nvme: Makefile: remove dead build rule Christoph Hellwig <hch@lst.de> - 2017-06-29 16:40 +0200
    Re: [PATCH] nvme: Makefile: remove dead build rule Keith Busch <keith.busch@intel.com> - 2017-06-29 17:00 +0200

#1677446 — [PATCH] nvme: Makefile: remove dead build rule

FromValentin Rothberg <vrothberg@suse.com>
Date2017-06-29 09:00 +0200
Subject[PATCH] nvme: Makefile: remove dead build rule
Message-ID<tXBAK-4e8-3@gated-at.bofh.it>
Remove dead build rule for drivers/nvme/host/scsi.c which has been
removed by commit ("nvme: Remove SCSI translations").

Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
---
 drivers/nvme/host/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/nvme/host/Makefile b/drivers/nvme/host/Makefile
index f1a7d945fbb6..cc0aacb4c8b4 100644
--- a/drivers/nvme/host/Makefile
+++ b/drivers/nvme/host/Makefile
@@ -5,7 +5,6 @@ obj-$(CONFIG_NVME_RDMA)			+= nvme-rdma.o
 obj-$(CONFIG_NVME_FC)			+= nvme-fc.o
 
 nvme-core-y				:= core.o
-nvme-core-$(CONFIG_BLK_DEV_NVME_SCSI)	+= scsi.o
 nvme-core-$(CONFIG_NVM)			+= lightnvm.o
 
 nvme-y					+= pci.o
-- 
2.12.3

[toc] | [next] | [standalone]


#1677523

FromJohannes Thumshirn <jthumshirn@suse.de>
Date2017-06-29 10:40 +0200
Message-ID<tXD9v-5gl-5@gated-at.bofh.it>
In reply to#1677446
On Thu, Jun 29, 2017 at 08:59:07AM +0200, Valentin Rothberg wrote:
> Remove dead build rule for drivers/nvme/host/scsi.c which has been
> removed by commit ("nvme: Remove SCSI translations").
> 
> Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
> ---

Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[toc] | [prev] | [next] | [standalone]


#1677821

FromChristoph Hellwig <hch@lst.de>
Date2017-06-29 16:40 +0200
Message-ID<tXILT-ia-7@gated-at.bofh.it>
In reply to#1677446
Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

[toc] | [prev] | [next] | [standalone]


#1677841

FromKeith Busch <keith.busch@intel.com>
Date2017-06-29 17:00 +0200
Message-ID<tXJ5i-qk-41@gated-at.bofh.it>
In reply to#1677446
On Thu, Jun 29, 2017 at 08:59:07AM +0200, Valentin Rothberg wrote:
> Remove dead build rule for drivers/nvme/host/scsi.c which has been
> removed by commit ("nvme: Remove SCSI translations").
> 
> Signed-off-by: Valentin Rothberg <vrothberg@suse.com>

Oops, thanks for the fix.

Reviewed-by: Keith Busch <keith.busch@intel.com>

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web