Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1670440 > unrolled thread

Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze  if __e1000_shutdown fails Daniel Vetter <daniel@ffwll.ch> - 2017-06-20 11:00 +0200
    Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if  __e1000_shutdown fails Dave Airlie <airlied@gmail.com> - 2017-06-27 21:30 +0200
      Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze  if __e1000_shutdown fails Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2017-06-27 23:00 +0200
        Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if  __e1000_shutdown fails Daniel Vetter <daniel.vetter@ffwll.ch> - 2017-06-28 07:40 +0200

#1670440 — Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

On Wed, Jun 07, 2017 at 01:07:33AM +0000, Brown, Aaron F wrote:
> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf
> > Of Jeff Kirsher
> > Sent: Tuesday, June 6, 2017 1:46 PM
> > To: David Miller <davem@davemloft.net>; Nikula, Jani
> > <jani.nikula@intel.com>
> > Cc: Ursulin, Tvrtko <tvrtko.ursulin@intel.com>; daniel.vetter@ffwll.ch; intel-
> > gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org;
> > jani.nikula@linux.intel.com; chris@chris-wilson.co.uk; Ertman, David M
> > <david.m.ertman@intel.com>; intel-wired-lan@lists.osuosl.org; dri-
> > devel@lists.freedesktop.org; netdev@vger.kernel.org; airlied@gmail.com
> > Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo
> > e1000e_pm_freeze if __e1000_shutdown fails
> > 
> > On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote:
> > > From: Jani Nikula <jani.nikula@intel.com>
> > > Date: Wed, 31 May 2017 18:50:43 +0300
> > >
> > > > From: Chris Wilson <chris@chris-wilson.co.uk>
> > > >
> > > > An error during suspend (e100e_pm_suspend),
> > >
> > >  ...
> > > > lead to complete failure:
> > >
> > >  ...
> > > > The unwind failures stems from commit 2800209994f8 ("e1000e:
> > > > Refactor PM
> > > > flows"), but it may be a later patch that introduced the non-
> > > > recoverable
> > > > behaviour.
> > > >
> > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows")
> > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847
> > > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > > > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > > > Cc: Dave Ertman <davidx.m.ertman@intel.com>
> > > > Cc: Bruce Allan <bruce.w.allan@intel.com>
> > > > Cc: intel-wired-lan@lists.osuosl.org
> > > > Cc: netdev@vger.kernel.org
> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > [Jani: bikeshed repainted]
> > > > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> > >
> > > Jeff, please make sure this gets submitted to me soon.
> > 
> > Expect it later tonight, just finishing up testing.
> 
> Tested-by: Aaron Brown <aaron.f.brown@intel.com>

Hm, I seem to be blind, but I can't find it anywhere in -rc6. Does someone
have the sha1 from Linus' git for this patch?

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

[toc] | [next] | [standalone]

#1676100 — Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

On 20 June 2017 at 18:49, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Jun 07, 2017 at 01:07:33AM +0000, Brown, Aaron F wrote:
>> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org] On Behalf
>> > Of Jeff Kirsher
>> > Sent: Tuesday, June 6, 2017 1:46 PM
>> > To: David Miller <davem@davemloft.net>; Nikula, Jani
>> > <jani.nikula@intel.com>
>> > Cc: Ursulin, Tvrtko <tvrtko.ursulin@intel.com>; daniel.vetter@ffwll.ch; intel-
>> > gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org;
>> > jani.nikula@linux.intel.com; chris@chris-wilson.co.uk; Ertman, David M
>> > <david.m.ertman@intel.com>; intel-wired-lan@lists.osuosl.org; dri-
>> > devel@lists.freedesktop.org; netdev@vger.kernel.org; airlied@gmail.com
>> > Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo
>> > e1000e_pm_freeze if __e1000_shutdown fails
>> >
>> > On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote:
>> > > From: Jani Nikula <jani.nikula@intel.com>
>> > > Date: Wed, 31 May 2017 18:50:43 +0300
>> > >
>> > > > From: Chris Wilson <chris@chris-wilson.co.uk>
>> > > >
>> > > > An error during suspend (e100e_pm_suspend),
>> > >
>> > >  ...
>> > > > lead to complete failure:
>> > >
>> > >  ...
>> > > > The unwind failures stems from commit 2800209994f8 ("e1000e:
>> > > > Refactor PM
>> > > > flows"), but it may be a later patch that introduced the non-
>> > > > recoverable
>> > > > behaviour.
>> > > >
>> > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows")
>> > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847
>> > > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> > > > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>> > > > Cc: Dave Ertman <davidx.m.ertman@intel.com>
>> > > > Cc: Bruce Allan <bruce.w.allan@intel.com>
>> > > > Cc: intel-wired-lan@lists.osuosl.org
>> > > > Cc: netdev@vger.kernel.org
>> > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > > > [Jani: bikeshed repainted]
>> > > > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> > >
>> > > Jeff, please make sure this gets submitted to me soon.
>> >
>> > Expect it later tonight, just finishing up testing.
>>
>> Tested-by: Aaron Brown <aaron.f.brown@intel.com>
>
> Hm, I seem to be blind, but I can't find it anywhere in -rc6. Does someone
> have the sha1 from Linus' git for this patch?

Guys this is a pretty serious regression, just left blowing in the
wind, is anyone responsible for e1000e?

Dave.

[toc] | [prev] | [next] | [standalone]

#1676179

[Multipart message — attachments visible in raw view] — view raw

On Wed, 2017-06-28 at 05:28 +1000, Dave Airlie wrote:
> On 20 June 2017 at 18:49, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Wed, Jun 07, 2017 at 01:07:33AM +0000, Brown, Aaron F wrote:
> > > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@osuosl.org]
> > > > On Behalf
> > > > Of Jeff Kirsher
> > > > Sent: Tuesday, June 6, 2017 1:46 PM
> > > > To: David Miller <davem@davemloft.net>; Nikula, Jani
> > > > <jani.nikula@intel.com>
> > > > Cc: Ursulin, Tvrtko <tvrtko.ursulin@intel.com>; daniel.vetter@ffwll
> > > > .ch; intel-
> > > > gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org;
> > > > jani.nikula@linux.intel.com; chris@chris-wilson.co.uk; Ertman,
> > > > David M
> > > > <david.m.ertman@intel.com>; intel-wired-lan@lists.osuosl.org; dri-
> > > > devel@lists.freedesktop.org; netdev@vger.kernel.org; airlied@gmail.
> > > > com
> > > > Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo
> > > > e1000e_pm_freeze if __e1000_shutdown fails
> > > > 
> > > > On Fri, 2017-06-02 at 14:14 -0400, David Miller wrote:
> > > > > From: Jani Nikula <jani.nikula@intel.com>
> > > > > Date: Wed, 31 May 2017 18:50:43 +0300
> > > > > 
> > > > > > From: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > > 
> > > > > > An error during suspend (e100e_pm_suspend),
> > > > > 
> > > > >  ...
> > > > > > lead to complete failure:
> > > > > 
> > > > >  ...
> > > > > > The unwind failures stems from commit 2800209994f8 ("e1000e:
> > > > > > Refactor PM
> > > > > > flows"), but it may be a later patch that introduced the non-
> > > > > > recoverable
> > > > > > behaviour.
> > > > > > 
> > > > > > Fixes: 2800209994f8 ("e1000e: Refactor PM flows")
> > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99847
> > > > > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > > > > > Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > > > > > Cc: Dave Ertman <davidx.m.ertman@intel.com>
> > > > > > Cc: Bruce Allan <bruce.w.allan@intel.com>
> > > > > > Cc: intel-wired-lan@lists.osuosl.org
> > > > > > Cc: netdev@vger.kernel.org
> > > > > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > > [Jani: bikeshed repainted]
> > > > > > Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> > > > > 
> > > > > Jeff, please make sure this gets submitted to me soon.
> > > > 
> > > > Expect it later tonight, just finishing up testing.
> > > 
> > > Tested-by: Aaron Brown <aaron.f.brown@intel.com>
> > 
> > Hm, I seem to be blind, but I can't find it anywhere in -rc6. Does
> > someone
> > have the sha1 from Linus' git for this patch?
> 
> Guys this is a pretty serious regression, just left blowing in the
> wind, is anyone responsible for e1000e?

This was submitted and accepted into David Miller's net-next tree.  I can
see if Dave can pull it into his net tree.  DOes stable need to pick this
up as well?

[toc] | [prev] | [next] | [standalone]

#1676387 — Re: [Intel-wired-lan] [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

On Tue, Jun 27, 2017 at 10:51 PM, Jeff Kirsher
<jeffrey.t.kirsher@intel.com> wrote:
> This was submitted and accepted into David Miller's net-next tree.  I can
> see if Dave can pull it into his net tree.  DOes stable need to pick this
> up as well?

Nah if it landed somewhere at least I'm happy, we can carry the fixup
for a while longer locally.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web