Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1675906 > unrolled thread

Re: [PATCH v2 00/15] staging: fsl-mc: clean up header files

Started byArnd Bergmann <arnd@arndb.de>
First post2017-06-27 17:40 +0200
Last post2017-06-27 22:30 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v2 00/15] staging: fsl-mc: clean up header files Arnd Bergmann <arnd@arndb.de> - 2017-06-27 17:40 +0200
    Re: [PATCH v2 00/15] staging: fsl-mc: clean up header files gregkh <gregkh@linuxfoundation.org> - 2017-06-27 18:10 +0200
      Re: [PATCH v2 00/15] staging: fsl-mc: clean up header files Arnd Bergmann <arnd@arndb.de> - 2017-06-27 22:30 +0200

#1675906 — Re: [PATCH v2 00/15] staging: fsl-mc: clean up header files

FromArnd Bergmann <arnd@arndb.de>
Date2017-06-27 17:40 +0200
SubjectRe: [PATCH v2 00/15] staging: fsl-mc: clean up header files
Message-ID<tX0KR-2rx-1@gated-at.bofh.it>
On Tue, Jun 27, 2017 at 4:41 PM,  <laurentiu.tudor@nxp.com> wrote:
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>
> This patch series contain mainly clean-ups of the mc-bus header files
> with the final goal of reorganizing them in just 2 files: a public
> and a private one, as per GregKH suggestion [1].
> Here's a summary of the header reorganizing:
>  - existing mc.h used as public header (contained most of the public API)
>  - existing fsl-mc-private.h used for private header
>  - mc-bus.h merged both in public and private header
>  - mc-sys.h and mc-cmd.h merged in public header
>  - dprc.h made private
>  - dpmng.h deleted
>
> [1] https://patchwork.kernel.org/patch/9775683/
>
> version 2 changes
>  - fix compilation issue
>  - reordered a comparison, be consistent when checking strcmp() return
>    (Joe Perches, first two patches)

It looks like v1 was already merged into staging-next, so the changes would
have to be relative to what's already merged, rather than replacing them.

I also just sent a fixup for the Makefile bug, probably others have pointed
that out too.

       Arnd

[toc] | [next] | [standalone]


#1675950

Fromgregkh <gregkh@linuxfoundation.org>
Date2017-06-27 18:10 +0200
Message-ID<tX1dV-2UD-49@gated-at.bofh.it>
In reply to#1675906
On Tue, Jun 27, 2017 at 05:33:21PM +0200, Arnd Bergmann wrote:
> On Tue, Jun 27, 2017 at 4:41 PM,  <laurentiu.tudor@nxp.com> wrote:
> > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> >
> > This patch series contain mainly clean-ups of the mc-bus header files
> > with the final goal of reorganizing them in just 2 files: a public
> > and a private one, as per GregKH suggestion [1].
> > Here's a summary of the header reorganizing:
> >  - existing mc.h used as public header (contained most of the public API)
> >  - existing fsl-mc-private.h used for private header
> >  - mc-bus.h merged both in public and private header
> >  - mc-sys.h and mc-cmd.h merged in public header
> >  - dprc.h made private
> >  - dpmng.h deleted
> >
> > [1] https://patchwork.kernel.org/patch/9775683/
> >
> > version 2 changes
> >  - fix compilation issue
> >  - reordered a comparison, be consistent when checking strcmp() return
> >    (Joe Perches, first two patches)
> 
> It looks like v1 was already merged into staging-next, so the changes would
> have to be relative to what's already merged, rather than replacing them.

No, I had to revert the whole v1 mess, so this is correct...

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]


#1676156

FromArnd Bergmann <arnd@arndb.de>
Date2017-06-27 22:30 +0200
Message-ID<tX5hw-5C4-15@gated-at.bofh.it>
In reply to#1675950
On Tue, Jun 27, 2017 at 6:00 PM, gregkh <gregkh@linuxfoundation.org> wrote:
> On Tue, Jun 27, 2017 at 05:33:21PM +0200, Arnd Bergmann wrote:
>> On Tue, Jun 27, 2017 at 4:41 PM,  <laurentiu.tudor@nxp.com> wrote:
>> > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>> >
>> > This patch series contain mainly clean-ups of the mc-bus header files
>> > with the final goal of reorganizing them in just 2 files: a public
>> > and a private one, as per GregKH suggestion [1].
>> > Here's a summary of the header reorganizing:
>> >  - existing mc.h used as public header (contained most of the public API)
>> >  - existing fsl-mc-private.h used for private header
>> >  - mc-bus.h merged both in public and private header
>> >  - mc-sys.h and mc-cmd.h merged in public header
>> >  - dprc.h made private
>> >  - dpmng.h deleted
>> >
>> > [1] https://patchwork.kernel.org/patch/9775683/
>> >
>> > version 2 changes
>> >  - fix compilation issue
>> >  - reordered a comparison, be consistent when checking strcmp() return
>> >    (Joe Perches, first two patches)
>>
>> It looks like v1 was already merged into staging-next, so the changes would
>> have to be relative to what's already merged, rather than replacing them.
>
> No, I had to revert the whole v1 mess, so this is correct...

Ok, sorry for the confusion on my side then. Obviously you can ignore my fixup
patch too, as that is already part of this series.

       Arnd

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web