Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1675919 > unrolled thread

[PATCH] ras: mark stub functions as 'inline'

Back to article view | Back to linux.kernel

Contents

  [PATCH] ras: mark stub functions as 'inline' Arnd Bergmann <arnd@arndb.de> - 2017-06-27 17:40 +0200
    Re: [PATCH] ras: mark stub functions as 'inline' Borislav Petkov <bp@suse.de> - 2017-06-28 12:30 +0200
      Re: [PATCH] ras: mark stub functions as 'inline' Will Deacon <will.deacon@arm.com> - 2017-06-28 12:30 +0200

#1675919 — [PATCH] ras: mark stub functions as 'inline'

With CONFIG_RAS disabled, we get two harmless warnings about
unused functions:

include/linux/ras.h:37:13: error: 'log_arm_hw_error' defined but not used [-Werror=unused-function]
 static void log_arm_hw_error(struct cper_sec_proc_arm *err) { return; }
include/linux/ras.h:33:13: error: 'log_non_standard_event' defined but not used [-Werror=unused-function]
 static void log_non_standard_event(const guid_t *sec_type,

Clearly these are meant to be 'inline', like the other stubs
in the same header.

Fixes: 297b64c74385 ("ras: acpi / apei: generate trace event for unrecognized CPER section")
Fixes: e9279e83ad1f ("trace, ras: add ARM processor error trace event")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 include/linux/ras.h | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/include/linux/ras.h b/include/linux/ras.h
index 7d61863ff265..be5338a35d57 100644
--- a/include/linux/ras.h
+++ b/include/linux/ras.h
@@ -30,11 +30,13 @@ void log_non_standard_event(const guid_t *sec_type,
 			    const u8 sev, const u8 *err, const u32 len);
 void log_arm_hw_error(struct cper_sec_proc_arm *err);
 #else
-static void log_non_standard_event(const guid_t *sec_type,
-				   const guid_t *fru_id, const char *fru_text,
-				   const u8 sev, const u8 *err,
-				   const u32 len) { return; }
-static void log_arm_hw_error(struct cper_sec_proc_arm *err) { return; }
+static inline void
+log_non_standard_event(const guid_t *sec_type,
+		       const guid_t *fru_id, const char *fru_text,
+		       const u8 sev, const u8 *err, const u32 len)
+{ return; }
+static inline void
+log_arm_hw_error(struct cper_sec_proc_arm *err) { return; }
 #endif
 
 #endif /* __RAS_H__ */
-- 
2.9.0

[toc] | [next] | [standalone]

#1676526

On Tue, Jun 27, 2017 at 05:35:41PM +0200, Arnd Bergmann wrote:
> With CONFIG_RAS disabled, we get two harmless warnings about
> unused functions:
> 
> include/linux/ras.h:37:13: error: 'log_arm_hw_error' defined but not used [-Werror=unused-function]
>  static void log_arm_hw_error(struct cper_sec_proc_arm *err) { return; }
> include/linux/ras.h:33:13: error: 'log_non_standard_event' defined but not used [-Werror=unused-function]
>  static void log_non_standard_event(const guid_t *sec_type,
> 
> Clearly these are meant to be 'inline', like the other stubs
> in the same header.
> 
> Fixes: 297b64c74385 ("ras: acpi / apei: generate trace event for unrecognized CPER section")
> Fixes: e9279e83ad1f ("trace, ras: add ARM processor error trace event")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  include/linux/ras.h | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)

Acked-by: Borislav Petkov <bp@suse.de>

I'm assuming Will is picking this one up along with the rest of the ARM
RAS pile...

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 

[toc] | [prev] | [next] | [standalone]

#1676534

On Wed, Jun 28, 2017 at 12:27:44PM +0200, Borislav Petkov wrote:
> On Tue, Jun 27, 2017 at 05:35:41PM +0200, Arnd Bergmann wrote:
> > With CONFIG_RAS disabled, we get two harmless warnings about
> > unused functions:
> > 
> > include/linux/ras.h:37:13: error: 'log_arm_hw_error' defined but not used [-Werror=unused-function]
> >  static void log_arm_hw_error(struct cper_sec_proc_arm *err) { return; }
> > include/linux/ras.h:33:13: error: 'log_non_standard_event' defined but not used [-Werror=unused-function]
> >  static void log_non_standard_event(const guid_t *sec_type,
> > 
> > Clearly these are meant to be 'inline', like the other stubs
> > in the same header.
> > 
> > Fixes: 297b64c74385 ("ras: acpi / apei: generate trace event for unrecognized CPER section")
> > Fixes: e9279e83ad1f ("trace, ras: add ARM processor error trace event")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  include/linux/ras.h | 12 +++++++-----
> >  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> Acked-by: Borislav Petkov <bp@suse.de>
> 
> I'm assuming Will is picking this one up along with the rest of the ARM
> RAS pile...

Yup, will do. Thanks.

Will

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web