Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1675916 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-06-27 17:40 +0200 |
| Last post | 2017-06-27 18:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] platform/chrome: cros_ec_lightbar - hide unused PM functions Arnd Bergmann <arnd@arndb.de> - 2017-06-27 17:40 +0200
Re: [PATCH] platform/chrome: cros_ec_lightbar - hide unused PM functions Guenter Roeck <groeck@google.com> - 2017-06-27 18:10 +0200
Re: [PATCH] platform/chrome: cros_ec_lightbar - hide unused PM functions Benson Leung <bleung@google.com> - 2017-06-27 18:30 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-06-27 17:40 +0200 |
| Subject | [PATCH] platform/chrome: cros_ec_lightbar - hide unused PM functions |
| Message-ID | <tX0KT-2rx-35@gated-at.bofh.it> |
The only reference to the new functions is inside of an #ifdef,
which now causes a harmless warning when CONFIG_PM_SLEEP is not set:
chrome/cros_ec_dev.c:478:12: error: 'ec_device_resume' defined but not used [-Werror=unused-function]
chrome/cros_ec_dev.c:469:12: error: 'ec_device_suspend' defined but not used [-Werror=unused-function]
This marks the two functions as __maybe_unused so they can get
silently dropped by the compiler.
Fixes: 405c84308c43 ("platform/chrome: cros_ec_lightbar - Control of suspend/resume lightbar sequence")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/platform/chrome/cros_ec_dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
index b9bf086f7569..cf6c4f0846b8 100644
--- a/drivers/platform/chrome/cros_ec_dev.c
+++ b/drivers/platform/chrome/cros_ec_dev.c
@@ -466,7 +466,7 @@ static const struct platform_device_id cros_ec_id[] = {
};
MODULE_DEVICE_TABLE(platform, cros_ec_id);
-static int ec_device_suspend(struct device *dev)
+static __maybe_unused int ec_device_suspend(struct device *dev)
{
struct cros_ec_dev *ec = dev_get_drvdata(dev);
@@ -475,7 +475,7 @@ static int ec_device_suspend(struct device *dev)
return 0;
}
-static int ec_device_resume(struct device *dev)
+static __maybe_unused int ec_device_resume(struct device *dev)
{
struct cros_ec_dev *ec = dev_get_drvdata(dev);
--
2.9.0
[toc] | [next] | [standalone]
| From | Guenter Roeck <groeck@google.com> |
|---|---|
| Date | 2017-06-27 18:10 +0200 |
| Message-ID | <tX1dT-2UD-9@gated-at.bofh.it> |
| In reply to | #1675916 |
On Tue, Jun 27, 2017 at 8:36 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> The only reference to the new functions is inside of an #ifdef,
> which now causes a harmless warning when CONFIG_PM_SLEEP is not set:
>
> chrome/cros_ec_dev.c:478:12: error: 'ec_device_resume' defined but not used [-Werror=unused-function]
> chrome/cros_ec_dev.c:469:12: error: 'ec_device_suspend' defined but not used [-Werror=unused-function]
>
> This marks the two functions as __maybe_unused so they can get
> silently dropped by the compiler.
>
> Fixes: 405c84308c43 ("platform/chrome: cros_ec_lightbar - Control of suspend/resume lightbar sequence")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> ---
> drivers/platform/chrome/cros_ec_dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_dev.c b/drivers/platform/chrome/cros_ec_dev.c
> index b9bf086f7569..cf6c4f0846b8 100644
> --- a/drivers/platform/chrome/cros_ec_dev.c
> +++ b/drivers/platform/chrome/cros_ec_dev.c
> @@ -466,7 +466,7 @@ static const struct platform_device_id cros_ec_id[] = {
> };
> MODULE_DEVICE_TABLE(platform, cros_ec_id);
>
> -static int ec_device_suspend(struct device *dev)
> +static __maybe_unused int ec_device_suspend(struct device *dev)
> {
> struct cros_ec_dev *ec = dev_get_drvdata(dev);
>
> @@ -475,7 +475,7 @@ static int ec_device_suspend(struct device *dev)
> return 0;
> }
>
> -static int ec_device_resume(struct device *dev)
> +static __maybe_unused int ec_device_resume(struct device *dev)
> {
> struct cros_ec_dev *ec = dev_get_drvdata(dev);
>
> --
> 2.9.0
>
[toc] | [prev] | [next] | [standalone]
| From | Benson Leung <bleung@google.com> |
|---|---|
| Date | 2017-06-27 18:30 +0200 |
| Subject | Re: [PATCH] platform/chrome: cros_ec_lightbar - hide unused PM functions |
| Message-ID | <tX1xg-32b-27@gated-at.bofh.it> |
| In reply to | #1675916 |
[Multipart message — attachments visible in raw view] — view raw
Hi Arnd,
On Tue, Jun 27, 2017 at 05:36:36PM +0200, Arnd Bergmann wrote:
> The only reference to the new functions is inside of an #ifdef,
> which now causes a harmless warning when CONFIG_PM_SLEEP is not set:
>
> chrome/cros_ec_dev.c:478:12: error: 'ec_device_resume' defined but not used [-Werror=unused-function]
> chrome/cros_ec_dev.c:469:12: error: 'ec_device_suspend' defined but not used [-Werror=unused-function]
>
> This marks the two functions as __maybe_unused so they can get
> silently dropped by the compiler.
>
> Fixes: 405c84308c43 ("platform/chrome: cros_ec_lightbar - Control of suspend/resume lightbar sequence")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Good catch. Applied. Thanks!
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web