Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673585 > unrolled thread

Re: [PATCH v2 12/29] kselftest.rst: do some adjustments after ReST conversion

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 12/29] kselftest.rst: do some adjustments after ReST  conversion Shuah Khan <shuah@kernel.org> - 2017-06-23 16:10 +0200
    Re: [PATCH v2 12/29] kselftest.rst: do some adjustments after ReST  conversion Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2017-06-23 23:40 +0200
      Re: [PATCH v2 12/29] kselftest.rst: do some adjustments after ReST  conversion Shuah Khan <shuah@kernel.org> - 2017-06-24 02:50 +0200
        Re: [PATCH v2 12/29] kselftest.rst: do some adjustments after ReST  conversion Jonathan Corbet <corbet@lwn.net> - 2017-06-25 21:40 +0200
          Re: [PATCH v2 12/29] kselftest.rst: do some adjustments after ReST  conversion Shuah Khan <shuah@kernel.org> - 2017-06-26 18:40 +0200

#1673585 — Re: [PATCH v2 12/29] kselftest.rst: do some adjustments after ReST conversion

Hi Mauro,

On 06/17/2017 09:26 AM, Mauro Carvalho Chehab wrote:
> Do some minor adjustments after ReST conversion:
> 
> - On most documents, we use prepend a "$ " before
>   command line arguments;
> 
> - Prefer to use :: on the preceding line;
> 
> - Split a multi-paragraph description as such.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

Looks good to me. I can take this through linux-kselftest or here is
my Ack for it to go through the doc tree with the rest in this series.

Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

thanks,
-- Shuah

> ---
>  Documentation/dev-tools/kselftest.rst | 32 ++++++++++++++++----------------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index b3861500c42d..ebd03d11d2c2 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -19,15 +19,15 @@ Running the selftests (hotplug tests are run in limited mode)
>  
>  To build the tests::
>  
> -    make -C tools/testing/selftests
> +  $ make -C tools/testing/selftests
>  
>  To run the tests::
>  
> -    make -C tools/testing/selftests run_tests
> +  $ make -C tools/testing/selftests run_tests
>  
>  To build and run the tests with a single command, use::
>  
> -    make kselftest
> +  $ make kselftest
>  
>  Note that some tests will require root privileges.
>  
> @@ -40,11 +40,11 @@ single test to run, or a list of tests to run.
>  
>  To run only tests targeted for a single subsystem::
>  
> -    make -C tools/testing/selftests TARGETS=ptrace run_tests
> +  $ make -C tools/testing/selftests TARGETS=ptrace run_tests
>  
>  You can specify multiple tests to build and run::
>  
> -    make TARGETS="size timers" kselftest
> +  $  make TARGETS="size timers" kselftest
>  
>  See the top-level tools/testing/selftests/Makefile for the list of all
>  possible targets.
> @@ -55,11 +55,11 @@ Running the full range hotplug selftests
>  
>  To build the hotplug tests::
>  
> -    make -C tools/testing/selftests hotplug
> +  $ make -C tools/testing/selftests hotplug
>  
>  To run the hotplug tests::
>  
> -    make -C tools/testing/selftests run_hotplug
> +  $ make -C tools/testing/selftests run_hotplug
>  
>  Note that some tests will require root privileges.
>  
> @@ -73,13 +73,13 @@ location.
>  
>  To install selftests in default location::
>  
> -    cd tools/testing/selftests
> -    ./kselftest_install.sh
> +   $ cd tools/testing/selftests
> +   $ ./kselftest_install.sh
>  
>  To install selftests in a user specified location::
>  
> -    cd tools/testing/selftests
> -    ./kselftest_install.sh install_dir
> +   $ cd tools/testing/selftests
> +   $ ./kselftest_install.sh install_dir
>  
>  Running installed selftests
>  ===========================
> @@ -88,12 +88,10 @@ Kselftest install as well as the Kselftest tarball provide a script
>  named "run_kselftest.sh" to run the tests.
>  
>  You can simply do the following to run the installed Kselftests. Please
> -note some tests will require root privileges.
> +note some tests will require root privileges::
>  
> -::
> -
> -    cd kselftest
> -    ./run_kselftest.sh
> +   $ cd kselftest
> +   $ ./run_kselftest.sh
>  
>  Contributing new tests
>  ======================
> @@ -114,8 +112,10 @@ Contributing new tests (details)
>  
>   * Use TEST_GEN_XXX if such binaries or files are generated during
>     compiling.
> +
>     TEST_PROGS, TEST_GEN_PROGS mean it is the excutable tested by
>     default.
> +
>     TEST_PROGS_EXTENDED, TEST_GEN_PROGS_EXTENDED mean it is the
>     executable which is not tested by default.
>     TEST_FILES, TEST_GEN_FILES mean it is the file which is used by
> 

[toc] | [next] | [standalone]

#1673890

Em Fri, 23 Jun 2017 08:04:02 -0600
Shuah Khan <shuah@kernel.org> escreveu:

> Hi Mauro,
> 
> On 06/17/2017 09:26 AM, Mauro Carvalho Chehab wrote:
> > Do some minor adjustments after ReST conversion:
> > 
> > - On most documents, we use prepend a "$ " before
> >   command line arguments;
> > 
> > - Prefer to use :: on the preceding line;
> > 
> > - Split a multi-paragraph description as such.
> > 
> > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>  
> 
> Looks good to me. I can take this through linux-kselftest or here is
> my Ack for it to go through the doc tree with the rest in this series.
> 
> Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

Shuah,

Either way works for me. Whatever makes easier for you and Jon.

Regards,
Mauro

[toc] | [prev] | [next] | [standalone]

#1673959

On 06/23/2017 03:32 PM, Mauro Carvalho Chehab wrote:
> Em Fri, 23 Jun 2017 08:04:02 -0600
> Shuah Khan <shuah@kernel.org> escreveu:
> 
>> Hi Mauro,
>>
>> On 06/17/2017 09:26 AM, Mauro Carvalho Chehab wrote:
>>> Do some minor adjustments after ReST conversion:
>>>
>>> - On most documents, we use prepend a "$ " before
>>>   command line arguments;
>>>
>>> - Prefer to use :: on the preceding line;
>>>
>>> - Split a multi-paragraph description as such.
>>>
>>> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>  
>>
>> Looks good to me. I can take this through linux-kselftest or here is
>> my Ack for it to go through the doc tree with the rest in this series.
>>
>> Acked-by: Shuah Khan <shuahkh@osg.samsung.com>
> 
> Shuah,
> 
> Either way works for me. Whatever makes easier for you and Jon.
> 
> Regards,
> Mauro
> 
> 

Hi Jon,

Please let me know if you want me to take this through linux-kselftest
In which case, Ack the patch. If not, you already have my Ack.

thanks,
-- Shuah

[toc] | [prev] | [next] | [standalone]

#1674292

On Fri, 23 Jun 2017 18:47:51 -0600
Shuah Khan <shuah@kernel.org> wrote:

> Please let me know if you want me to take this through linux-kselftest
> In which case, Ack the patch. If not, you already have my Ack.

Go ahead and take it if you want:

	Acked-by: Jonathan Corbet <corbet@lwn.net>

I haven't quite figured out how I'm going to manage this mountain of
patches yet; making it a little smaller can only help :)

jon

[toc] | [prev] | [next] | [standalone]

#1674928

On 06/25/2017 01:35 PM, Jonathan Corbet wrote:
> On Fri, 23 Jun 2017 18:47:51 -0600
> Shuah Khan <shuah@kernel.org> wrote:
> 
>> Please let me know if you want me to take this through linux-kselftest
>> In which case, Ack the patch. If not, you already have my Ack.
> 
> Go ahead and take it if you want:
> 
> 	Acked-by: Jonathan Corbet <corbet@lwn.net>
> 
> I haven't quite figured out how I'm going to manage this mountain of
> patches yet; making it a little smaller can only help :)

Good luck. :)

> 
> jon
> 
> 

Thanks. Applied to linux-kselftest next for 4.13-rc1

-- Shuah

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web