Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1675484 > unrolled thread
| Started by | Roman Storozhenko <romeusmeister@gmail.com> |
|---|---|
| First post | 2017-06-27 12:00 +0200 |
| Last post | 2017-06-27 15:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] KVM: Replaces symbolic permissions with numeric Roman Storozhenko <romeusmeister@gmail.com> - 2017-06-27 12:00 +0200
Re: [PATCH] KVM: Replaces symbolic permissions with numeric Paolo Bonzini <pbonzini@redhat.com> - 2017-06-27 15:10 +0200
| From | Roman Storozhenko <romeusmeister@gmail.com> |
|---|---|
| Date | 2017-06-27 12:00 +0200 |
| Subject | [PATCH] KVM: Replaces symbolic permissions with numeric |
| Message-ID | <tWVrQ-76Y-5@gated-at.bofh.it> |
Replaces "S_IRUGO | S_IWUSR" with 0644. The reason is that symbolic
permissions considered harmful:
https://lwn.net/Articles/696229/
Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
---
virt/kvm/kvm_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index f0fe9d0..3863cf7 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -73,17 +73,17 @@ MODULE_LICENSE("GPL");
/* Architectures should define their poll value according to the halt latency */
unsigned int halt_poll_ns = KVM_HALT_POLL_NS_DEFAULT;
-module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
+module_param(halt_poll_ns, uint, 0644);
EXPORT_SYMBOL_GPL(halt_poll_ns);
/* Default doubles per-vcpu halt_poll_ns. */
unsigned int halt_poll_ns_grow = 2;
-module_param(halt_poll_ns_grow, uint, S_IRUGO | S_IWUSR);
+module_param(halt_poll_ns_grow, uint, 0644);
EXPORT_SYMBOL_GPL(halt_poll_ns_grow);
/* Default resets per-vcpu halt_poll_ns . */
unsigned int halt_poll_ns_shrink;
-module_param(halt_poll_ns_shrink, uint, S_IRUGO | S_IWUSR);
+module_param(halt_poll_ns_shrink, uint, 0644);
EXPORT_SYMBOL_GPL(halt_poll_ns_shrink);
/*
--
2.7.4
[toc] | [next] | [standalone]
| From | Paolo Bonzini <pbonzini@redhat.com> |
|---|---|
| Date | 2017-06-27 15:10 +0200 |
| Message-ID | <tWYpI-WT-23@gated-at.bofh.it> |
| In reply to | #1675484 |
On 27/06/2017 11:51, Roman Storozhenko wrote:
> Replaces "S_IRUGO | S_IWUSR" with 0644. The reason is that symbolic
> permissions considered harmful:
> https://lwn.net/Articles/696229/
>
> Signed-off-by: Roman Storozhenko <romeusmeister@gmail.com>
> ---
> virt/kvm/kvm_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index f0fe9d0..3863cf7 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -73,17 +73,17 @@ MODULE_LICENSE("GPL");
>
> /* Architectures should define their poll value according to the halt latency */
> unsigned int halt_poll_ns = KVM_HALT_POLL_NS_DEFAULT;
> -module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
> +module_param(halt_poll_ns, uint, 0644);
> EXPORT_SYMBOL_GPL(halt_poll_ns);
>
> /* Default doubles per-vcpu halt_poll_ns. */
> unsigned int halt_poll_ns_grow = 2;
> -module_param(halt_poll_ns_grow, uint, S_IRUGO | S_IWUSR);
> +module_param(halt_poll_ns_grow, uint, 0644);
> EXPORT_SYMBOL_GPL(halt_poll_ns_grow);
>
> /* Default resets per-vcpu halt_poll_ns . */
> unsigned int halt_poll_ns_shrink;
> -module_param(halt_poll_ns_shrink, uint, S_IRUGO | S_IWUSR);
> +module_param(halt_poll_ns_shrink, uint, 0644);
> EXPORT_SYMBOL_GPL(halt_poll_ns_shrink);
>
> /*
>
Queued, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web