Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1675436 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-06-27 11:20 +0200 |
| Last post | 2017-07-03 12:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] sparc: kernel: pmc: make of_device_ids const. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-27 11:20 +0200
Re: [PATCH] sparc: kernel: pmc: make of_device_ids const. David Miller <davem@davemloft.net> - 2017-07-03 12:00 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-06-27 11:20 +0200 |
| Subject | [PATCH] sparc: kernel: pmc: make of_device_ids const. |
| Message-ID | <tWUP7-6Rd-1@gated-at.bofh.it> |
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
arch/sparc/kernel/pmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sparc/kernel/pmc.c b/arch/sparc/kernel/pmc.c
index f12b23f..3b26cf6 100644
--- a/arch/sparc/kernel/pmc.c
+++ b/arch/sparc/kernel/pmc.c
@@ -71,7 +71,7 @@ static int pmc_probe(struct platform_device *op)
return 0;
}
-static struct of_device_id pmc_match[] = {
+static const struct of_device_id pmc_match[] = {
{
.name = PMC_OBPNAME,
},
--
1.9.1
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-07-03 12:00 +0200 |
| Message-ID | <tZ6j8-7MN-33@gated-at.bofh.it> |
| In reply to | #1675436 |
From: Arvind Yadav <arvind.yadav.cs@gmail.com> Date: Tue, 27 Jun 2017 14:39:58 +0530 > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by <linux/of.h> work with const > of_device_ids. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web