Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1675316 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-06-27 08:20 +0200 |
| Last post | 2017-06-27 10:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] arm: perf: make of_device_ids const Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-27 08:20 +0200
Re: [PATCH] arm: perf: make of_device_ids const Will Deacon <will.deacon@arm.com> - 2017-06-27 10:50 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-06-27 08:20 +0200 |
| Subject | [PATCH] arm: perf: make of_device_ids const |
| Message-ID | <tWS0W-4W7-5@gated-at.bofh.it> |
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
arch/arm/kernel/perf_event_v6.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/kernel/perf_event_v6.c b/arch/arm/kernel/perf_event_v6.c
index 96b7a47..8226d0b 100644
--- a/arch/arm/kernel/perf_event_v6.c
+++ b/arch/arm/kernel/perf_event_v6.c
@@ -552,7 +552,7 @@ static int armv6mpcore_pmu_init(struct arm_pmu *cpu_pmu)
return 0;
}
-static struct of_device_id armv6_pmu_of_device_ids[] = {
+static const struct of_device_id armv6_pmu_of_device_ids[] = {
{.compatible = "arm,arm11mpcore-pmu", .data = armv6mpcore_pmu_init},
{.compatible = "arm,arm1176-pmu", .data = armv6_1176_pmu_init},
{.compatible = "arm,arm1136-pmu", .data = armv6_1136_pmu_init},
--
1.9.1
[toc] | [next] | [standalone]
| From | Will Deacon <will.deacon@arm.com> |
|---|---|
| Date | 2017-06-27 10:50 +0200 |
| Message-ID | <tWUm5-6qI-3@gated-at.bofh.it> |
| In reply to | #1675316 |
On Tue, Jun 27, 2017 at 11:42:21AM +0530, Arvind Yadav wrote: > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by <linux/of.h> work with const > of_device_ids. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > arch/arm/kernel/perf_event_v6.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This is already queued in -next. Will
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web