Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1675195 > unrolled thread
| Started by | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| First post | 2017-06-27 01:50 +0200 |
| Last post | 2017-06-28 20:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] ath9k: remove useless variable assignment in ath_mci_intr() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-27 01:50 +0200
Re: ath9k: remove useless variable assignment in ath_mci_intr() Kalle Valo <kvalo@qca.qualcomm.com> - 2017-06-28 20:00 +0200
| From | "Gustavo A. R. Silva" <garsilva@embeddedor.com> |
|---|---|
| Date | 2017-06-27 01:50 +0200 |
| Subject | [PATCH] ath9k: remove useless variable assignment in ath_mci_intr() |
| Message-ID | <tWLVv-AA-7@gated-at.bofh.it> |
Value assigned to variable offset at line 551 is overwritten at line 562,
before it can be used. This makes such variable assignment useless.
Addresses-Coverity-ID: 1226941
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/net/wireless/ath/ath9k/mci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/mci.c b/drivers/net/wireless/ath/ath9k/mci.c
index 66596b9..cf23fd8 100644
--- a/drivers/net/wireless/ath/ath9k/mci.c
+++ b/drivers/net/wireless/ath/ath9k/mci.c
@@ -548,7 +548,7 @@ void ath_mci_intr(struct ath_softc *sc)
if (mci_int_rxmsg & AR_MCI_INTERRUPT_RX_MSG_SCHD_INFO) {
mci_int_rxmsg &= ~AR_MCI_INTERRUPT_RX_MSG_SCHD_INFO;
- offset = ar9003_mci_state(ah, MCI_STATE_LAST_SCHD_MSG_OFFSET);
+ ar9003_mci_state(ah, MCI_STATE_LAST_SCHD_MSG_OFFSET);
}
if (mci_int_rxmsg & AR_MCI_INTERRUPT_RX_MSG_GPM) {
--
2.5.0
[toc] | [next] | [standalone]
| From | Kalle Valo <kvalo@qca.qualcomm.com> |
|---|---|
| Date | 2017-06-28 20:00 +0200 |
| Subject | Re: ath9k: remove useless variable assignment in ath_mci_intr() |
| Message-ID | <tXpq6-t5-231@gated-at.bofh.it> |
| In reply to | #1675195 |
"Gustavo A. R. Silva" <garsilva@embeddedor.com> wrote: > Value assigned to variable offset at line 551 is overwritten at line 562, > before it can be used. This makes such variable assignment useless. > > Addresses-Coverity-ID: 1226941 > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. 6788a3832c70 ath9k: remove useless variable assignment in ath_mci_intr() -- https://patchwork.kernel.org/patch/9810609/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web