Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1670338 > unrolled thread

Re: [PATCH v2 1/2] kernel/module.c: Invert add_usage_link and del_usage_link functions

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 1/2] kernel/module.c: Invert add_usage_link and  del_usage_link functions Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-06-20 08:50 +0200
    Re: [PATCH v2 1/2] kernel/module.c: Invert add_usage_link and  del_usage_link functions Jessica Yu <jeyu@redhat.com> - 2017-06-26 15:40 +0200

#1670338 — Re: [PATCH v2 1/2] kernel/module.c: Invert add_usage_link and del_usage_link functions

On Mon, Jun 19, 2017 at 06:26:23PM +0200, Jessica Yu wrote:
> +++ Corentin Labbe [06/06/17 14:17 +0200]:
> >This patch just swap del_usage_link() before add_usage_link().
> >
> >Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> 
> Could you combine this with the 2nd patch? By itself this patch
> doesn't tell us much. Additionally, could you explain in the changelog
> (of the 2nd patch) why they needed to be swapped (i.e., so
> del_usage_links() can be called from add_usage_links()).
> 
> Thanks!
> 
> Jessica
> 

I think that its against the rule of atomic/simple patch.
Perhaps, the first patch miss some "why I do it"

Anyway I will send a new version as you requested
Regards

[toc] | [next] | [standalone]

#1674785

+++ Corentin Labbe [20/06/17 08:45 +0200]:
>On Mon, Jun 19, 2017 at 06:26:23PM +0200, Jessica Yu wrote:
>> +++ Corentin Labbe [06/06/17 14:17 +0200]:
>> >This patch just swap del_usage_link() before add_usage_link().
>> >
>> >Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>>
>> Could you combine this with the 2nd patch? By itself this patch
>> doesn't tell us much. Additionally, could you explain in the changelog
>> (of the 2nd patch) why they needed to be swapped (i.e., so
>> del_usage_links() can be called from add_usage_links()).
>>
>> Thanks!
>>
>> Jessica
>>
>
>I think that its against the rule of atomic/simple patch.
>Perhaps, the first patch miss some "why I do it"
>
>Anyway I will send a new version as you requested

Hi Corentin,

I've folded the first patch with the second and applied them to
modules-next, no need to resend the patchset :)

Thanks!

Jessica

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web