Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673452 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-06-23 12:20 +0200 |
| Last post | 2017-06-23 12:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] irqchip: irq-gic-v3-its-pci-msi: make of_device_ids const Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-23 12:20 +0200
Re: [PATCH] irqchip: irq-gic-v3-its-pci-msi: make of_device_ids const Marc Zyngier <marc.zyngier@arm.com> - 2017-06-23 12:30 +0200
Re: [PATCH] irqchip: irq-gic-v3-its-pci-msi: make of_device_ids const Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-23 12:40 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-06-23 12:20 +0200 |
| Subject | [PATCH] irqchip: irq-gic-v3-its-pci-msi: make of_device_ids const |
| Message-ID | <tVtQZ-Rn-5@gated-at.bofh.it> |
of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/irqchip/irq-gic-v3-its-pci-msi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
index aee1c60..44f80ec 100644
--- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c
+++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
@@ -102,7 +102,7 @@ static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
.chip = &its_msi_irq_chip,
};
-static struct of_device_id its_device_id[] = {
+static const struct of_device_id its_device_id[] = {
{ .compatible = "arm,gic-v3-its", },
{},
};
--
1.9.1
[toc] | [next] | [standalone]
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Date | 2017-06-23 12:30 +0200 |
| Message-ID | <tVu0G-Vv-9@gated-at.bofh.it> |
| In reply to | #1673452 |
On 23/06/17 11:11, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/irqchip/irq-gic-v3-its-pci-msi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
> index aee1c60..44f80ec 100644
> --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c
> +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
> @@ -102,7 +102,7 @@ static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
> .chip = &its_msi_irq_chip,
> };
>
> -static struct of_device_id its_device_id[] = {
> +static const struct of_device_id its_device_id[] = {
> { .compatible = "arm,gic-v3-its", },
> {},
> };
>
I already sent the pull request to Thomas, so this one will have to
wait. In general, it'd be better if you sent these fixes as a series for
a given subsystem rather than one or two patches every other day.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
[toc] | [prev] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-06-23 12:40 +0200 |
| Message-ID | <tVual-YI-5@gated-at.bofh.it> |
| In reply to | #1673457 |
Hi,
Ok, Next time I will push all fixes patch together,
Thanks,
~arvind
On Friday 23 June 2017 03:54 PM, Marc Zyngier wrote:
> On 23/06/17 11:11, Arvind Yadav wrote:
>> of_device_ids are not supposed to change at runtime. All functions
>> working with of_device_ids provided by <linux/of.h> work with const
>> of_device_ids. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> drivers/irqchip/irq-gic-v3-its-pci-msi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
>> index aee1c60..44f80ec 100644
>> --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c
>> +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
>> @@ -102,7 +102,7 @@ static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
>> .chip = &its_msi_irq_chip,
>> };
>>
>> -static struct of_device_id its_device_id[] = {
>> +static const struct of_device_id its_device_id[] = {
>> { .compatible = "arm,gic-v3-its", },
>> {},
>> };
>>
> I already sent the pull request to Thomas, so this one will have to
> wait. In general, it'd be better if you sent these fixes as a series for
> a given subsystem rather than one or two patches every other day.
>
> Thanks,
>
> M.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web