Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673373 > unrolled thread

[PATCH] Bluetooth: hci_serdev: make hci_serdev_client_ops static

Back to article view | Back to linux.kernel

Contents

  [PATCH] Bluetooth: hci_serdev: make hci_serdev_client_ops static Colin King <colin.king@canonical.com> - 2017-06-23 10:40 +0200
    Re: [PATCH] Bluetooth: hci_serdev: make hci_serdev_client_ops static Marcel Holtmann <marcel@holtmann.org> - 2017-06-23 11:00 +0200

#1673373 — [PATCH] Bluetooth: hci_serdev: make hci_serdev_client_ops static

From: Colin Ian King <colin.king@canonical.com>

The structure hci_serdev_client_ops does not need to be in global scope
and is not modified, so make it static.

Cleans up sparse warning:
"symbol 'hci_serdev_client_ops' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/bluetooth/hci_serdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/hci_serdev.c b/drivers/bluetooth/hci_serdev.c
index 7de0edc0ff8c..aea930101dd2 100644
--- a/drivers/bluetooth/hci_serdev.c
+++ b/drivers/bluetooth/hci_serdev.c
@@ -31,7 +31,7 @@
 
 #include "hci_uart.h"
 
-struct serdev_device_ops hci_serdev_client_ops;
+static struct serdev_device_ops hci_serdev_client_ops;
 
 static inline void hci_uart_tx_complete(struct hci_uart *hu, int pkt_type)
 {
@@ -268,7 +268,7 @@ static int hci_uart_receive_buf(struct serdev_device *serdev, const u8 *data,
 	return count;
 }
 
-struct serdev_device_ops hci_serdev_client_ops = {
+static struct serdev_device_ops hci_serdev_client_ops = {
 	.receive_buf = hci_uart_receive_buf,
 	.write_wakeup = hci_uart_write_wakeup,
 };
-- 
2.11.0

[toc] | [next] | [standalone]

#1673396

Hi Colin,

> The structure hci_serdev_client_ops does not need to be in global scope
> and is not modified, so make it static.
> 
> Cleans up sparse warning:
> "symbol 'hci_serdev_client_ops' was not declared. Should it be static?"
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/bluetooth/hci_serdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web