Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673332 > unrolled thread

[PATCH] staging: unisys: visorbus: constify channel_attr_grp and dev_attr_grp

Back to article view | Back to linux.kernel

Contents

  [PATCH] staging: unisys: visorbus: constify channel_attr_grp and dev_attr_grp Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-23 09:40 +0200
    RE: [PATCH] staging: unisys: visorbus: constify channel_attr_grp and  dev_attr_grp "Kershner, David A" <David.Kershner@unisys.com> - 2017-06-27 19:10 +0200

#1673332 — [PATCH] staging: unisys: visorbus: constify channel_attr_grp and dev_attr_grp

File size before:
   text	   data	    bss	    dec	    hex	filename
   6712	    960	    521	   8193	   2001	drivers/staging/unisys/visorbus/visorbus_main.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   6840	    832	    521	   8193	   2001	drivers/staging/unisys/visorbus/visorbus_main.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index a692561..26f9885 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -249,7 +249,7 @@ static ssize_t typename_show(struct device *dev, struct device_attribute *attr,
 		NULL
 };
 
-static struct attribute_group channel_attr_grp = {
+static const struct attribute_group channel_attr_grp = {
 		.name = "channel",
 		.attrs = channel_attrs,
 };
@@ -340,7 +340,7 @@ static ssize_t channel_id_show(struct device *dev,
 		NULL
 };
 
-static struct attribute_group dev_attr_grp = {
+static const struct attribute_group dev_attr_grp = {
 		.attrs = dev_attrs,
 };
 
-- 
1.9.1

[toc] | [next] | [standalone]

#1676009 — RE: [PATCH] staging: unisys: visorbus: constify channel_attr_grp and dev_attr_grp

> -----Original Message-----
> From: Arvind Yadav [mailto:arvind.yadav.cs@gmail.com]
> Sent: Friday, June 23, 2017 3:37 AM
> To: Kershner, David A <David.Kershner@unisys.com>;
> gregkh@linuxfoundation.org; Thompson, Bryan E.
> <bryan.thompson@unisys.com>; Wadgaonkar, Sameer Laxmikant
> <Sameer.Wadgaonkar@unisys.com>; jon.frisch@unisys.com
> Cc: *S-Par-Maintainer <SParMaintainer@unisys.com>;
> devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] staging: unisys: visorbus: constify channel_attr_grp and
> dev_attr_grp
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    6712	    960	    521	   8193	   2001
> 	drivers/staging/unisys/visorbus/visorbus_main.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    6840	    832	    521	   8193	   2001
> 	drivers/staging/unisys/visorbus/visorbus_main.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: David Kershner <david.kershner@unisys.com>

> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index a692561..26f9885 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -249,7 +249,7 @@ static ssize_t typename_show(struct device *dev,
> struct device_attribute *attr,
>  		NULL
>  };
> 
> -static struct attribute_group channel_attr_grp = {
> +static const struct attribute_group channel_attr_grp = {
>  		.name = "channel",
>  		.attrs = channel_attrs,
>  };
> @@ -340,7 +340,7 @@ static ssize_t channel_id_show(struct device *dev,
>  		NULL
>  };
> 
> -static struct attribute_group dev_attr_grp = {
> +static const struct attribute_group dev_attr_grp = {
>  		.attrs = dev_attrs,
>  };
> 
> --
> 1.9.1

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web