Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1672997 > unrolled thread

[PATCH 1/2] edac: pnd2_edac: add code comment for clarification

Started by"Gustavo A. R. Silva" <garsilva@embeddedor.com>
First post2017-06-22 21:30 +0200
Last post2017-06-23 10:00 +0200
Articles 6 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] edac: pnd2_edac: add code comment for clarification "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-22 21:30 +0200
    [PATCH 2/2] edac: pnd2_edac: remove useless variable assignment "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-22 21:40 +0200
      Re: [PATCH 2/2] edac: pnd2_edac: remove useless variable assignment Borislav Petkov <bp@alien8.de> - 2017-06-22 23:10 +0200
        Re: [PATCH 2/2] edac: pnd2_edac: remove useless variable assignment "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-22 23:50 +0200
          [PATCH] edac: pnd2_edac: add code comment for clarification and  update variable assignment "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-23 00:10 +0200
            Re: [PATCH] edac: pnd2_edac: add code comment for clarification and  update variable assignment Borislav Petkov <bp@alien8.de> - 2017-06-23 10:00 +0200

#1672997 — [PATCH 1/2] edac: pnd2_edac: add code comment for clarification

From"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date2017-06-22 21:30 +0200
Subject[PATCH 1/2] edac: pnd2_edac: add code comment for clarification
Message-ID<tVfXH-uK-11@gated-at.bofh.it>
Add code comment to make it clear that the fall-through is intentional.

Addresses-Coverity-ID: 1403728
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/edac/pnd2_edac.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index 1cad5a9..c51ec73 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -174,6 +174,7 @@ static int apl_rd_reg(int port, int off, int op, void *data, size_t sz, char *na
 	switch (sz) {
 	case 8:
 		ret = sbi_send(port, off + 4, op, (u32 *)(data + 4));
+		/* fall through */
 	case 4:
 		ret = sbi_send(port, off, op, (u32 *)data);
 		pnd2_printk(KERN_DEBUG, "%s=%x%08x ret=%d\n", name,
-- 
2.5.0

[toc] | [next] | [standalone]

#1673006 — [PATCH 2/2] edac: pnd2_edac: remove useless variable assignment

From"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date2017-06-22 21:40 +0200
Subject[PATCH 2/2] edac: pnd2_edac: remove useless variable assignment
Message-ID<tVg7p-xW-31@gated-at.bofh.it>
In reply to#1672997
Value assigned to variable _ret_ at line 176 is overwritten
a few lines below before it can be used. This makes such
variable assignment useless.

Addresses-Coverity-ID: 1403730
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/edac/pnd2_edac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index c51ec73..d1de53e 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -173,7 +173,7 @@ static int apl_rd_reg(int port, int off, int op, void *data, size_t sz, char *na
 	edac_dbg(2, "Read %s port=%x off=%x op=%x\n", name, port, off, op);
 	switch (sz) {
 	case 8:
-		ret = sbi_send(port, off + 4, op, (u32 *)(data + 4));
+		sbi_send(port, off + 4, op, (u32 *)(data + 4));
 		/* fall through */
 	case 4:
 		ret = sbi_send(port, off, op, (u32 *)data);
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1673044 — Re: [PATCH 2/2] edac: pnd2_edac: remove useless variable assignment

FromBorislav Petkov <bp@alien8.de>
Date2017-06-22 23:10 +0200
SubjectRe: [PATCH 2/2] edac: pnd2_edac: remove useless variable assignment
Message-ID<tVhwt-1xP-5@gated-at.bofh.it>
In reply to#1673006
On Thu, Jun 22, 2017 at 02:30:10PM -0500, Gustavo A. R. Silva wrote:
> Value assigned to variable _ret_ at line 176 is overwritten
> a few lines below before it can be used. This makes such
> variable assignment useless.
> 
> Addresses-Coverity-ID: 1403730

Get rid of this tag...

> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/edac/pnd2_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
> index c51ec73..d1de53e 100644
> --- a/drivers/edac/pnd2_edac.c
> +++ b/drivers/edac/pnd2_edac.c
> @@ -173,7 +173,7 @@ static int apl_rd_reg(int port, int off, int op, void *data, size_t sz, char *na
>  	edac_dbg(2, "Read %s port=%x off=%x op=%x\n", name, port, off, op);
>  	switch (sz) {
>  	case 8:
> -		ret = sbi_send(port, off + 4, op, (u32 *)(data + 4));
> +		sbi_send(port, off + 4, op, (u32 *)(data + 4));

... keep ret but OR it in with its previous value:

        case 8:
                ret  = sbi_send(port, off + 4, op, (u32 *)(data + 4));
		/* fall through */
        case 4:
                ret |= sbi_send(port, off, op, (u32 *)data);

>  		/* fall through */
>  	case 4:
>  		ret = sbi_send(port, off, op, (u32 *)data);

... and merge both into a single patch.

Thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

[toc] | [prev] | [next] | [standalone]

#1673074 — Re: [PATCH 2/2] edac: pnd2_edac: remove useless variable assignment

From"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date2017-06-22 23:50 +0200
SubjectRe: [PATCH 2/2] edac: pnd2_edac: remove useless variable assignment
Message-ID<tVi9c-1Mr-5@gated-at.bofh.it>
In reply to#1673044
Hi Borislav,

Quoting Borislav Petkov <bp@alien8.de>:

> On Thu, Jun 22, 2017 at 02:30:10PM -0500, Gustavo A. R. Silva wrote:
>> Value assigned to variable _ret_ at line 176 is overwritten
>> a few lines below before it can be used. This makes such
>> variable assignment useless.
>>
>> Addresses-Coverity-ID: 1403730
>
> Get rid of this tag...
>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>>  drivers/edac/pnd2_edac.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
>> index c51ec73..d1de53e 100644
>> --- a/drivers/edac/pnd2_edac.c
>> +++ b/drivers/edac/pnd2_edac.c
>> @@ -173,7 +173,7 @@ static int apl_rd_reg(int port, int off, int  
>> op, void *data, size_t sz, char *na
>>  	edac_dbg(2, "Read %s port=%x off=%x op=%x\n", name, port, off, op);
>>  	switch (sz) {
>>  	case 8:
>> -		ret = sbi_send(port, off + 4, op, (u32 *)(data + 4));
>> +		sbi_send(port, off + 4, op, (u32 *)(data + 4));
>
> ... keep ret but OR it in with its previous value:
>
>         case 8:
>                 ret  = sbi_send(port, off + 4, op, (u32 *)(data + 4));
> 		/* fall through */
>         case 4:
>                 ret |= sbi_send(port, off, op, (u32 *)data);
>
>>  		/* fall through */
>>  	case 4:
>>  		ret = sbi_send(port, off, op, (u32 *)data);
>
> ... and merge both into a single patch.
>

I got it. I'll send a new patch shortly.

Thanks!
--
Gustavo A. R. Silva

[toc] | [prev] | [next] | [standalone]

#1673084 — [PATCH] edac: pnd2_edac: add code comment for clarification and update variable assignment

From"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date2017-06-23 00:10 +0200
Subject[PATCH] edac: pnd2_edac: add code comment for clarification and update variable assignment
Message-ID<tVisy-27Z-13@gated-at.bofh.it>
In reply to#1673074
Add code comment to make it clear that the fall-through is intentional and,
OR ret with its previous value to avoid overwriting it.

Cc: Borislav Petkov <bp@alien8.de>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/edac/pnd2_edac.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index 1cad5a9..63cb323 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -174,8 +174,9 @@ static int apl_rd_reg(int port, int off, int op, void *data, size_t sz, char *na
 	switch (sz) {
 	case 8:
 		ret = sbi_send(port, off + 4, op, (u32 *)(data + 4));
+		/* fall through */
 	case 4:
-		ret = sbi_send(port, off, op, (u32 *)data);
+		ret |= sbi_send(port, off, op, (u32 *)data);
 		pnd2_printk(KERN_DEBUG, "%s=%x%08x ret=%d\n", name,
 					sz == 8 ? *((u32 *)(data + 4)) : 0, *((u32 *)data), ret);
 		break;
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1673340 — Re: [PATCH] edac: pnd2_edac: add code comment for clarification and update variable assignment

FromBorislav Petkov <bp@alien8.de>
Date2017-06-23 10:00 +0200
SubjectRe: [PATCH] edac: pnd2_edac: add code comment for clarification and update variable assignment
Message-ID<tVrFv-7Pz-11@gated-at.bofh.it>
In reply to#1673084
On Thu, Jun 22, 2017 at 05:05:35PM -0500, Gustavo A. R. Silva wrote:
> Add code comment to make it clear that the fall-through is intentional and,
> OR ret with its previous value to avoid overwriting it.
> 
> Cc: Borislav Petkov <bp@alien8.de>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/edac/pnd2_edac.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web