Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1672646 > unrolled thread
| Started by | Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> |
|---|---|
| First post | 2017-06-22 15:50 +0200 |
| Last post | 2017-06-22 23:10 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT subtable Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-06-22 15:50 +0200
RE: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT subtable "Moore, Robert" <robert.moore@intel.com> - 2017-06-22 16:20 +0200
Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT subtable "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2017-06-22 16:40 +0200
Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT subtable Ganapatrao Kulkarni <gpkulkarni@gmail.com> - 2017-06-22 18:30 +0200
Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT subtable Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-06-22 23:10 +0200
| From | Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> |
|---|---|
| Date | 2017-06-22 15:50 +0200 |
| Subject | Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT subtable |
| Message-ID | <tVaEG-5pO-21@gated-at.bofh.it> |
Hi Rafael, Lv, Robert,
On Thu, Jun 22, 2017 at 11:40:11AM +0530, Ganapatrao Kulkarni wrote:
> Add GIC ITS Affinity (ACPI 6.2) subtable to SRAT table.
>
> ACPICA commit 5bc67f63918da249bfe279ee461d152bb3e6f55b
> Link: https://github.com/acpica/acpica/commit/5bc67f6
>
> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> ---
> include/acpi/actbl1.h | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
This patch is fine to me but it is up to you or who sends the ACPICA
pull request to send it upstream or give us an ACK so that it can go
via irqchip.
We need to know how this commit (and other ACPICA changes) will be sent
upstream to handle trees dependencies, please advise it is a bit urgent,
thank you.
Lorenzo
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> index b4ce55c..253c9db 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
> @@ -1192,7 +1192,8 @@ enum acpi_srat_type {
> ACPI_SRAT_TYPE_MEMORY_AFFINITY = 1,
> ACPI_SRAT_TYPE_X2APIC_CPU_AFFINITY = 2,
> ACPI_SRAT_TYPE_GICC_AFFINITY = 3,
> - ACPI_SRAT_TYPE_RESERVED = 4 /* 4 and greater are reserved */
> + ACPI_SRAT_TYPE_GIC_ITS_AFFINITY = 4, /* ACPI 6.2 */
> + ACPI_SRAT_TYPE_RESERVED = 5 /* 5 and greater are reserved */
> };
>
> /*
> @@ -1260,6 +1261,15 @@ struct acpi_srat_gicc_affinity {
> u32 clock_domain;
> };
>
> +/* 4: GIC ITS Affinity (ACPI 6.2) */
> +
> +struct acpi_srat_its_affinity {
> + struct acpi_subtable_header header;
> + u32 proximity_domain;
> + u16 reserved;
> + u32 its_id;
> +};
> +
> /* Flags for struct acpi_srat_gicc_affinity */
>
> #define ACPI_SRAT_GICC_ENABLED (1) /* 00: Use affinity structure */
> --
> 1.8.1.4
>
[toc] | [next] | [standalone]
| From | "Moore, Robert" <robert.moore@intel.com> |
|---|---|
| Date | 2017-06-22 16:20 +0200 |
| Message-ID | <tVb7I-5Qr-33@gated-at.bofh.it> |
| In reply to | #1672646 |
This support is already in the ACPICA code base, but I can't speak to when it will be upstreamed to Linux. Lv would know this.
Bob
> -----Original Message-----
> From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com]
> Sent: Thursday, June 22, 2017 6:43 AM
> To: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>; Zheng, Lv
> <lv.zheng@intel.com>; Moore, Robert <robert.moore@intel.com>; Rafael J.
> Wysocki <rjw@rjwysocki.net>
> Cc: linux-acpi@vger.kernel.org; devel@acpica.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> marc.zyngier@arm.com; catalin.marinas@arm.com; will.deacon@arm.com;
> hanjun.guo@linaro.org; tglx@linutronix.de; jason@lakedaemon.net;
> jnair@caviumnetworks.com; gpkulkarni@gmail.com
> Subject: Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT
> subtable
>
> Hi Rafael, Lv, Robert,
>
> On Thu, Jun 22, 2017 at 11:40:11AM +0530, Ganapatrao Kulkarni wrote:
> > Add GIC ITS Affinity (ACPI 6.2) subtable to SRAT table.
> >
> > ACPICA commit 5bc67f63918da249bfe279ee461d152bb3e6f55b
> > Link: https://github.com/acpica/acpica/commit/5bc67f6
> >
> > Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> > ---
> > include/acpi/actbl1.h | 12 +++++++++++-
> > 1 file changed, 11 insertions(+), 1 deletion(-)
>
> This patch is fine to me but it is up to you or who sends the ACPICA
> pull request to send it upstream or give us an ACK so that it can go via
> irqchip.
>
> We need to know how this commit (and other ACPICA changes) will be sent
> upstream to handle trees dependencies, please advise it is a bit urgent,
> thank you.
>
> Lorenzo
>
> > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
> > b4ce55c..253c9db 100644
> > --- a/include/acpi/actbl1.h
> > +++ b/include/acpi/actbl1.h
> > @@ -1192,7 +1192,8 @@ enum acpi_srat_type {
> > ACPI_SRAT_TYPE_MEMORY_AFFINITY = 1,
> > ACPI_SRAT_TYPE_X2APIC_CPU_AFFINITY = 2,
> > ACPI_SRAT_TYPE_GICC_AFFINITY = 3,
> > - ACPI_SRAT_TYPE_RESERVED = 4 /* 4 and greater are reserved */
> > + ACPI_SRAT_TYPE_GIC_ITS_AFFINITY = 4, /* ACPI 6.2 */
> > + ACPI_SRAT_TYPE_RESERVED = 5 /* 5 and greater are reserved */
> > };
> >
> > /*
> > @@ -1260,6 +1261,15 @@ struct acpi_srat_gicc_affinity {
> > u32 clock_domain;
> > };
> >
> > +/* 4: GIC ITS Affinity (ACPI 6.2) */
> > +
> > +struct acpi_srat_its_affinity {
> > + struct acpi_subtable_header header;
> > + u32 proximity_domain;
> > + u16 reserved;
> > + u32 its_id;
> > +};
> > +
> > /* Flags for struct acpi_srat_gicc_affinity */
> >
> > #define ACPI_SRAT_GICC_ENABLED (1) /* 00: Use affinity structure
> */
> > --
> > 1.8.1.4
> >
[toc] | [prev] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2017-06-22 16:40 +0200 |
| Subject | Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT subtable |
| Message-ID | <tVbr3-5Yi-11@gated-at.bofh.it> |
| In reply to | #1672668 |
On Thursday, June 22, 2017 02:13:18 PM Moore, Robert wrote:
> This support is already in the ACPICA code base, but I can't speak to when it will be upstreamed to Linux. Lv would know this.
It should be there in linux-next already AFAICS.
Lorenzo, can you please double check?
Thanks,
Rafael
> > -----Original Message-----
> > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com]
> > Sent: Thursday, June 22, 2017 6:43 AM
> > To: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>; Zheng, Lv
> > <lv.zheng@intel.com>; Moore, Robert <robert.moore@intel.com>; Rafael J.
> > Wysocki <rjw@rjwysocki.net>
> > Cc: linux-acpi@vger.kernel.org; devel@acpica.org; linux-
> > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > marc.zyngier@arm.com; catalin.marinas@arm.com; will.deacon@arm.com;
> > hanjun.guo@linaro.org; tglx@linutronix.de; jason@lakedaemon.net;
> > jnair@caviumnetworks.com; gpkulkarni@gmail.com
> > Subject: Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT
> > subtable
> >
> > Hi Rafael, Lv, Robert,
> >
> > On Thu, Jun 22, 2017 at 11:40:11AM +0530, Ganapatrao Kulkarni wrote:
> > > Add GIC ITS Affinity (ACPI 6.2) subtable to SRAT table.
> > >
> > > ACPICA commit 5bc67f63918da249bfe279ee461d152bb3e6f55b
> > > Link: https://github.com/acpica/acpica/commit/5bc67f6
> > >
> > > Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> > > ---
> > > include/acpi/actbl1.h | 12 +++++++++++-
> > > 1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > This patch is fine to me but it is up to you or who sends the ACPICA
> > pull request to send it upstream or give us an ACK so that it can go via
> > irqchip.
> >
> > We need to know how this commit (and other ACPICA changes) will be sent
> > upstream to handle trees dependencies, please advise it is a bit urgent,
> > thank you.
> >
> > Lorenzo
> >
> > > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
> > > b4ce55c..253c9db 100644
> > > --- a/include/acpi/actbl1.h
> > > +++ b/include/acpi/actbl1.h
> > > @@ -1192,7 +1192,8 @@ enum acpi_srat_type {
> > > ACPI_SRAT_TYPE_MEMORY_AFFINITY = 1,
> > > ACPI_SRAT_TYPE_X2APIC_CPU_AFFINITY = 2,
> > > ACPI_SRAT_TYPE_GICC_AFFINITY = 3,
> > > - ACPI_SRAT_TYPE_RESERVED = 4 /* 4 and greater are reserved */
> > > + ACPI_SRAT_TYPE_GIC_ITS_AFFINITY = 4, /* ACPI 6.2 */
> > > + ACPI_SRAT_TYPE_RESERVED = 5 /* 5 and greater are reserved */
> > > };
> > >
> > > /*
> > > @@ -1260,6 +1261,15 @@ struct acpi_srat_gicc_affinity {
> > > u32 clock_domain;
> > > };
> > >
> > > +/* 4: GIC ITS Affinity (ACPI 6.2) */
> > > +
> > > +struct acpi_srat_its_affinity {
> > > + struct acpi_subtable_header header;
> > > + u32 proximity_domain;
> > > + u16 reserved;
> > > + u32 its_id;
> > > +};
> > > +
> > > /* Flags for struct acpi_srat_gicc_affinity */
> > >
> > > #define ACPI_SRAT_GICC_ENABLED (1) /* 00: Use affinity structure
> > */
> > > --
> > > 1.8.1.4
> > >
[toc] | [prev] | [next] | [standalone]
| From | Ganapatrao Kulkarni <gpkulkarni@gmail.com> |
|---|---|
| Date | 2017-06-22 18:30 +0200 |
| Subject | Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT subtable |
| Message-ID | <tVd9v-7bb-1@gated-at.bofh.it> |
| In reply to | #1672693 |
On Thu, Jun 22, 2017 at 7:57 PM, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> On Thursday, June 22, 2017 02:13:18 PM Moore, Robert wrote:
>> This support is already in the ACPICA code base, but I can't speak to when it will be upstreamed to Linux. Lv would know this.
>
> It should be there in linux-next already AFAICS.
>
> Lorenzo, can you please double check?
thanks Rafael, this is added to linux-next on june12 [1].
When i sent my first version i.e on June 6, it was not there, hence i
have added to this series.
my bad, i have not checked when i sent subsequent versions.
this patch can be dropped.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/include/acpi/actbl1.h?id=a618c7f89a02f3c67a8f200855cff398855e3888
>
> Thanks,
> Rafael
>
>
>> > -----Original Message-----
>> > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com]
>> > Sent: Thursday, June 22, 2017 6:43 AM
>> > To: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>; Zheng, Lv
>> > <lv.zheng@intel.com>; Moore, Robert <robert.moore@intel.com>; Rafael J.
>> > Wysocki <rjw@rjwysocki.net>
>> > Cc: linux-acpi@vger.kernel.org; devel@acpica.org; linux-
>> > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
>> > marc.zyngier@arm.com; catalin.marinas@arm.com; will.deacon@arm.com;
>> > hanjun.guo@linaro.org; tglx@linutronix.de; jason@lakedaemon.net;
>> > jnair@caviumnetworks.com; gpkulkarni@gmail.com
>> > Subject: Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT
>> > subtable
>> >
>> > Hi Rafael, Lv, Robert,
>> >
>> > On Thu, Jun 22, 2017 at 11:40:11AM +0530, Ganapatrao Kulkarni wrote:
>> > > Add GIC ITS Affinity (ACPI 6.2) subtable to SRAT table.
>> > >
>> > > ACPICA commit 5bc67f63918da249bfe279ee461d152bb3e6f55b
>> > > Link: https://github.com/acpica/acpica/commit/5bc67f6
>> > >
>> > > Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
>> > > ---
>> > > include/acpi/actbl1.h | 12 +++++++++++-
>> > > 1 file changed, 11 insertions(+), 1 deletion(-)
>> >
>> > This patch is fine to me but it is up to you or who sends the ACPICA
>> > pull request to send it upstream or give us an ACK so that it can go via
>> > irqchip.
>> >
>> > We need to know how this commit (and other ACPICA changes) will be sent
>> > upstream to handle trees dependencies, please advise it is a bit urgent,
>> > thank you.
>> >
>> > Lorenzo
>> >
>> > > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
>> > > b4ce55c..253c9db 100644
>> > > --- a/include/acpi/actbl1.h
>> > > +++ b/include/acpi/actbl1.h
>> > > @@ -1192,7 +1192,8 @@ enum acpi_srat_type {
>> > > ACPI_SRAT_TYPE_MEMORY_AFFINITY = 1,
>> > > ACPI_SRAT_TYPE_X2APIC_CPU_AFFINITY = 2,
>> > > ACPI_SRAT_TYPE_GICC_AFFINITY = 3,
>> > > - ACPI_SRAT_TYPE_RESERVED = 4 /* 4 and greater are reserved */
>> > > + ACPI_SRAT_TYPE_GIC_ITS_AFFINITY = 4, /* ACPI 6.2 */
>> > > + ACPI_SRAT_TYPE_RESERVED = 5 /* 5 and greater are reserved */
>> > > };
>> > >
>> > > /*
>> > > @@ -1260,6 +1261,15 @@ struct acpi_srat_gicc_affinity {
>> > > u32 clock_domain;
>> > > };
>> > >
>> > > +/* 4: GIC ITS Affinity (ACPI 6.2) */
>> > > +
>> > > +struct acpi_srat_its_affinity {
>> > > + struct acpi_subtable_header header;
>> > > + u32 proximity_domain;
>> > > + u16 reserved;
>> > > + u32 its_id;
>> > > +};
>> > > +
>> > > /* Flags for struct acpi_srat_gicc_affinity */
>> > >
>> > > #define ACPI_SRAT_GICC_ENABLED (1) /* 00: Use affinity structure
>> > */
>> > > --
>> > > 1.8.1.4
>> > >
>
thanks
Ganapat
[toc] | [prev] | [next] | [standalone]
| From | Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> |
|---|---|
| Date | 2017-06-22 23:10 +0200 |
| Message-ID | <tVhwu-1xP-27@gated-at.bofh.it> |
| In reply to | #1672693 |
On Thu, Jun 22, 2017 at 04:27:18PM +0200, Rafael J. Wysocki wrote:
> On Thursday, June 22, 2017 02:13:18 PM Moore, Robert wrote:
> > This support is already in the ACPICA code base, but I can't speak to when it will be upstreamed to Linux. Lv would know this.
>
> It should be there in linux-next already AFAICS.
>
> Lorenzo, can you please double check?
Yes, it is all fine, thank you Rafael for taking the ACPICA changes.
Thanks !
Lorenzo
> Thanks,
> Rafael
>
>
> > > -----Original Message-----
> > > From: Lorenzo Pieralisi [mailto:lorenzo.pieralisi@arm.com]
> > > Sent: Thursday, June 22, 2017 6:43 AM
> > > To: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>; Zheng, Lv
> > > <lv.zheng@intel.com>; Moore, Robert <robert.moore@intel.com>; Rafael J.
> > > Wysocki <rjw@rjwysocki.net>
> > > Cc: linux-acpi@vger.kernel.org; devel@acpica.org; linux-
> > > kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > > marc.zyngier@arm.com; catalin.marinas@arm.com; will.deacon@arm.com;
> > > hanjun.guo@linaro.org; tglx@linutronix.de; jason@lakedaemon.net;
> > > jnair@caviumnetworks.com; gpkulkarni@gmail.com
> > > Subject: Re: [PATCH v4 1/2] ACPICA: ACPI 6.2: Add support for new SRAT
> > > subtable
> > >
> > > Hi Rafael, Lv, Robert,
> > >
> > > On Thu, Jun 22, 2017 at 11:40:11AM +0530, Ganapatrao Kulkarni wrote:
> > > > Add GIC ITS Affinity (ACPI 6.2) subtable to SRAT table.
> > > >
> > > > ACPICA commit 5bc67f63918da249bfe279ee461d152bb3e6f55b
> > > > Link: https://github.com/acpica/acpica/commit/5bc67f6
> > > >
> > > > Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com>
> > > > ---
> > > > include/acpi/actbl1.h | 12 +++++++++++-
> > > > 1 file changed, 11 insertions(+), 1 deletion(-)
> > >
> > > This patch is fine to me but it is up to you or who sends the ACPICA
> > > pull request to send it upstream or give us an ACK so that it can go via
> > > irqchip.
> > >
> > > We need to know how this commit (and other ACPICA changes) will be sent
> > > upstream to handle trees dependencies, please advise it is a bit urgent,
> > > thank you.
> > >
> > > Lorenzo
> > >
> > > > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
> > > > b4ce55c..253c9db 100644
> > > > --- a/include/acpi/actbl1.h
> > > > +++ b/include/acpi/actbl1.h
> > > > @@ -1192,7 +1192,8 @@ enum acpi_srat_type {
> > > > ACPI_SRAT_TYPE_MEMORY_AFFINITY = 1,
> > > > ACPI_SRAT_TYPE_X2APIC_CPU_AFFINITY = 2,
> > > > ACPI_SRAT_TYPE_GICC_AFFINITY = 3,
> > > > - ACPI_SRAT_TYPE_RESERVED = 4 /* 4 and greater are reserved */
> > > > + ACPI_SRAT_TYPE_GIC_ITS_AFFINITY = 4, /* ACPI 6.2 */
> > > > + ACPI_SRAT_TYPE_RESERVED = 5 /* 5 and greater are reserved */
> > > > };
> > > >
> > > > /*
> > > > @@ -1260,6 +1261,15 @@ struct acpi_srat_gicc_affinity {
> > > > u32 clock_domain;
> > > > };
> > > >
> > > > +/* 4: GIC ITS Affinity (ACPI 6.2) */
> > > > +
> > > > +struct acpi_srat_its_affinity {
> > > > + struct acpi_subtable_header header;
> > > > + u32 proximity_domain;
> > > > + u16 reserved;
> > > > + u32 its_id;
> > > > +};
> > > > +
> > > > /* Flags for struct acpi_srat_gicc_affinity */
> > > >
> > > > #define ACPI_SRAT_GICC_ENABLED (1) /* 00: Use affinity structure
> > > */
> > > > --
> > > > 1.8.1.4
> > > >
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web