Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1672775 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-06-22 18:00 +0200 |
| Last post | 2017-06-26 19:40 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] scsi: hptiop: make function hptiop_iop_request_callback_itl static Colin King <colin.king@canonical.com> - 2017-06-22 18:00 +0200
Re: [PATCH] scsi: hptiop: make function hptiop_iop_request_callback_itl static "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-06-26 19:40 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-06-22 18:00 +0200 |
| Subject | [PATCH] scsi: hptiop: make function hptiop_iop_request_callback_itl static |
| Message-ID | <tVcGu-6LO-33@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The function hptiop_iop_request_callback_itl does not need to be in
global scope, so make it static.
Cleans up sparse warning:
"symbol 'hptiop_iop_request_callback_itl' was not declared. Should it
be static?"
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/hptiop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hptiop.c b/drivers/scsi/hptiop.c
index db17ad15b0c1..7226226f7383 100644
--- a/drivers/scsi/hptiop.c
+++ b/drivers/scsi/hptiop.c
@@ -800,7 +800,7 @@ static void hptiop_host_request_callback_itl(struct hptiop_hba *hba, u32 _tag)
hptiop_finish_scsi_req(hba, tag, req);
}
-void hptiop_iop_request_callback_itl(struct hptiop_hba *hba, u32 tag)
+static void hptiop_iop_request_callback_itl(struct hptiop_hba *hba, u32 tag)
{
struct hpt_iop_request_header __iomem *req;
struct hpt_iop_request_ioctl_command __iomem *p;
--
2.11.0
[toc] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2017-06-26 19:40 +0200 |
| Message-ID | <tWG9s-5iW-19@gated-at.bofh.it> |
| In reply to | #1672775 |
Colin, > The function hptiop_iop_request_callback_itl does not need to be in > global scope, so make it static. > > Cleans up sparse warning: > "symbol 'hptiop_iop_request_callback_itl' was not declared. Should it > be static?" Applied to 4.13/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web