Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1672597 > unrolled thread

Re: [PATCH] mm: larger stack guard gap, between vmas

Started byWilly Tarreau <w@1wt.eu>
First post2017-06-22 14:50 +0200
Last post2017-06-22 23:30 +0200
Articles 11 — 6 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] mm: larger stack guard gap, between vmas Willy Tarreau <w@1wt.eu> - 2017-06-22 14:50 +0200
    Re: [PATCH] mm: larger stack guard gap, between vmas Ben Hutchings <ben@decadent.org.uk> - 2017-06-22 15:10 +0200
      Re: [PATCH] mm: larger stack guard gap, between vmas Willy Tarreau <w@1wt.eu> - 2017-06-22 15:20 +0200
        Re: [PATCH] mm: larger stack guard gap, between vmas Willy Tarreau <w@1wt.eu> - 2017-06-22 15:30 +0200
      Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas Levente Polyak <anthraxx@archlinux.org> - 2017-06-22 16:00 +0200
        Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas Willy Tarreau <w@1wt.eu> - 2017-06-22 16:10 +0200
          Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas Ben Hutchings <ben@decadent.org.uk> - 2017-06-22 16:20 +0200
            Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas Willy Tarreau <w@1wt.eu> - 2017-06-22 16:40 +0200
              Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas Andy Lutomirski <luto@kernel.org> - 2017-06-23 05:20 +0200
                Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas Linus Torvalds <torvalds@linux-foundation.org> - 2017-06-23 06:50 +0200
            Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas Helge Deller <deller@gmx.de> - 2017-06-22 23:30 +0200

#1672597 — Re: [PATCH] mm: larger stack guard gap, between vmas

FromWilly Tarreau <w@1wt.eu>
Date2017-06-22 14:50 +0200
SubjectRe: [PATCH] mm: larger stack guard gap, between vmas
Message-ID<tV9IB-4Lr-3@gated-at.bofh.it>
On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote:
> Here's my attempt at a backport to 3.2.  This is only tested on
> x86_64 and I think I should introduce local variables for
> vma_start_gap() in a few places.  I had to cherry-pick commit
> 09884964335e "mm: do not grow the stack vma just because of an overrun
> on preceding vma" before this one (which was a clean cherry-pick).

Ben, I can't apply it on top of 3.2.89 + the patch above, do you have
any other patch in your local branch ? For example the patch tries to
modify a hunk starting at line 183 of arch/arm/mm/mmap.c while the one
I'm having here ends at line 159.

Willy

[toc] | [next] | [standalone]

#1672614

FromBen Hutchings <ben@decadent.org.uk>
Date2017-06-22 15:10 +0200
Message-ID<tVa1Y-5aF-29@gated-at.bofh.it>
In reply to#1672597

[Multipart message — attachments visible in raw view] — view raw

On Thu, 2017-06-22 at 14:46 +0200, Willy Tarreau wrote:
> On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote:
> > Here's my attempt at a backport to 3.2.  This is only tested on
> > x86_64 and I think I should introduce local variables for
> > vma_start_gap() in a few places.  I had to cherry-pick commit
> > 09884964335e "mm: do not grow the stack vma just because of an overrun
> > on preceding vma" before this one (which was a clean cherry-pick).
> 
> Ben, I can't apply it on top of 3.2.89 + the patch above, do you have
> any other patch in your local branch ? For example the patch tries to
> modify a hunk starting at line 183 of arch/arm/mm/mmap.c while the one
> I'm having here ends at line 159.

Sorry, yes, I did this on top of the Debian 3.2 branch and that *does*
have a patch to arch/arm/mm/mmap.c that I had forgotten about (commit
7dbaa466780a "ARM: 7169/1: topdown mmap support").  I think you can
just drop the changes in ARM's arch_get_unmapped_area_topdown().

Ben.

-- 
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.

[toc] | [prev] | [next] | [standalone]

#1672618

FromWilly Tarreau <w@1wt.eu>
Date2017-06-22 15:20 +0200
Message-ID<tVabE-5es-13@gated-at.bofh.it>
In reply to#1672614
On Thu, Jun 22, 2017 at 01:58:11PM +0100, Ben Hutchings wrote:
> On Thu, 2017-06-22 at 14:46 +0200, Willy Tarreau wrote:
> > On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote:
> > > Here's my attempt at a backport to 3.2.  This is only tested on
> > > x86_64 and I think I should introduce local variables for
> > > vma_start_gap() in a few places.  I had to cherry-pick commit
> > > 09884964335e "mm: do not grow the stack vma just because of an overrun
> > > on preceding vma" before this one (which was a clean cherry-pick).
> > 
> > Ben, I can't apply it on top of 3.2.89 + the patch above, do you have
> > any other patch in your local branch ? For example the patch tries to
> > modify a hunk starting at line 183 of arch/arm/mm/mmap.c while the one
> > I'm having here ends at line 159.
> 
> Sorry, yes, I did this on top of the Debian 3.2 branch and that *does*
> have a patch to arch/arm/mm/mmap.c that I had forgotten about (commit
> 7dbaa466780a "ARM: 7169/1: topdown mmap support").  I think you can
> just drop the changes in ARM's arch_get_unmapped_area_topdown().

Thanks, I've just applied this one and it's building now. I'll run the
same checks I did for 3.10.

Willy

[toc] | [prev] | [next] | [standalone]

#1672620

FromWilly Tarreau <w@1wt.eu>
Date2017-06-22 15:30 +0200
Message-ID<tValj-5i5-7@gated-at.bofh.it>
In reply to#1672618
On Thu, Jun 22, 2017 at 03:10:34PM +0200, Willy Tarreau wrote:
> On Thu, Jun 22, 2017 at 01:58:11PM +0100, Ben Hutchings wrote:
> > On Thu, 2017-06-22 at 14:46 +0200, Willy Tarreau wrote:
> > > On Thu, Jun 22, 2017 at 01:30:45PM +0100, Ben Hutchings wrote:
> > > > Here's my attempt at a backport to 3.2.  This is only tested on
> > > > x86_64 and I think I should introduce local variables for
> > > > vma_start_gap() in a few places.  I had to cherry-pick commit
> > > > 09884964335e "mm: do not grow the stack vma just because of an overrun
> > > > on preceding vma" before this one (which was a clean cherry-pick).
> > > 
> > > Ben, I can't apply it on top of 3.2.89 + the patch above, do you have
> > > any other patch in your local branch ? For example the patch tries to
> > > modify a hunk starting at line 183 of arch/arm/mm/mmap.c while the one
> > > I'm having here ends at line 159.
> > 
> > Sorry, yes, I did this on top of the Debian 3.2 branch and that *does*
> > have a patch to arch/arm/mm/mmap.c that I had forgotten about (commit
> > 7dbaa466780a "ARM: 7169/1: topdown mmap support").  I think you can
> > just drop the changes in ARM's arch_get_unmapped_area_topdown().
> 
> Thanks, I've just applied this one and it's building now. I'll run the
> same checks I did for 3.10.

So I tested this with gap.c on an i386 VM running 2G/2G split memory, all
went fine. It properly stopped the stack growth before colliding with anon
pages.

I noticed that you included Hugh's last fix in it (mm: fix new crash in
unmapped_area_topdown). You'll also need Helge's fix bd726c90b ("Allow
stack to grow up to address space limit"), which applies without issues
on top of your patch.

I would have happily tested on an ARM board but I don't seem to have
3.2-compatible ARM boards with 2G of RAM :-/

Willy

[toc] | [prev] | [next] | [standalone]

#1672652 — Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

FromLevente Polyak <anthraxx@archlinux.org>
Date2017-06-22 16:00 +0200
SubjectRe: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas
Message-ID<tVaOm-5tA-11@gated-at.bofh.it>
In reply to#1672614

[Could not decode multipart message] — view raw

This is an OpenPGP/MIME encrypted message (RFC 4880 and 3156)
--T1TVwOPoljC8iq9VdeXRjSNdqXRclbJfg
Content-Type: application/pgp-encrypted
Content-Description: PGP/MIME version identification

Version: 1

--T1TVwOPoljC8iq9VdeXRjSNdqXRclbJfg
Content-Type: application/octet-stream; name="encrypted.asc"
Content-Description: OpenPGP encrypted message
Content-Disposition: inline; filename="encrypted.asc"

-----BEGIN PGP MESSAGE-----

hQIMA88EaVITV8PXAQ/+NuymxttGGakCR2x0OtTPkg9H4T1/8gbResaqROUfWshg
i7j5vBxdMy2pkbDTyA1/IA9hznJqPIyFx376RoGg65lFG5Z4Qjv0z8H6gT75CeB5
8KHPXXysuuBQpwWgE+DL8zRS36xPd/4B2MlhUudHrpZ72PjBPj5EhE//Hy689/gT
8Eji3cskXjSIi12qau/crLVgWIBaGeG4UZ3RxrV9dxbqw7Q8U6H2B/2S049hsPKh
NTxBNaTW0kgBvM3HM5F0V8Lib7OT+vnUucLtHV6UNXfEOvciJVL47ScpKBpF1Esx
VHggwzZ7WxsRLpF5EyKe0WcIrZLtRGxYwXIsCfDJVWc8n/uI6rInlKLt+MDUNoAz
a+1Bv6H5rZfu52BhbxEC/jAZRvHM1XBPV+KixcR5qCK1KXPYgZs00JzV1g3qAoO/
QHLmV5B078+mHdM+lyr3qEZL03P/dZRIoaiM4mzu1CANMxMulE+PesoJvcZwgFue
o6DntxD+GhG52Ra62gx7xoGfNEgwcsOme/pwJK8fw4U5n1IY5Ufy4gWva9FO6tHN
A+EA8xq0Op8iMOhPp6iWGyVEPL89i4aTozyvtJvoCO/nd/R/rwnzojRUYXAF7Y7N
J6MLckNmj4R0PXfa1kiewMvRzkTQNv9nXSdUamDNosceUJPkb+WRFPn2WNR1T4qF
AgwD84FT4nbVR0kBD/kBtX7toV1ByWWdKwFN/0I1Wc4OkTiZlQBp3m+uhKXaPOGf
3wzh76iN6iGogCcZcohE26TTJLkkrWdqMpi6PT9YHhEysBXsB+yjeh0kfUKRlTWx
VEdnmx1LylXlC8qR+ATlVelGvJ/JmYM3u98kWbgB4jniZRm6KxWrPP2bEuC9PGyy
AFYGhnupRd8RtZG+b6i8thEMBjSFNvOgMwzvz2OKAhz3ftsg1zDd5fWLlOUNCC7t
1u2Y6FE1lGjl4sh+hJavt971zF8Mikl+Dgxwm7BPDGEnDqvey3X1noDHXiTFSpBw
NbmdbNnjSSM19Jk7HGf4UuJrlOpx5X8sCdDrCRkfj/o2Nti0n5N8+ml0JB6JdrQ+
szFo0rdRiWZuUzcSoedDeH8ek//kAyHfGiWvVec6BvU0iX0cU8Kq1JvivCZ7Rxop
I0tRu3rv5AfQ8uDV0tIWOAhIKFQP2GvN4ZRNSQDSdxWW+ucc4LCLF6LrrGVfc/qy
9XXgybpwsB/sy9NnQC6Jp8VCEeAqQD2GuvA4T7yl7B+pZ/+OeeLfZgP7t1LwpkcY
qz63vNyOw6T7hIU23jIwlA0aB88V1IYwq6ZTa26Ei4/wht2Nv+sQUZ2VUjKe5BPa
vbWYXoppWmwzBCwOQu+wnIsGMMbZZd+AOFFBUBq9u//GtLQfUz+cw97Ut1kqvYUB
DAPIaYv7kYzkhwEH/2mlpG29YVtpfQQSZyI9cXAD81nwo2aqXo+9tg4rsaPV6+e8
Mz7m+yGnwUF3vs7T9/9zCUdkYKC4ALV7WW++AjxQdWHcSmxAqYWmpny5o9elSxuc
PeZ9HFzdWv/crrExFGCOGOdGPJfV1U0Ju4KEcyXVP1j6QWHXCGXGqHfmCG0OurCT
kBMt9eXXAueKZHuelo2rHleHwcmYD346nYMKtj4/WpQz7aJxRTrgYL4CFV33v9SO
wXngz8opx9L5+Do4b1wgpQnBpA0+YU5Xzb26VSEkrxv0IQcaLH0gkeZmZaAvWitj
6nGcY+9yvUfxL0cKeEQNTRr+b/7RWctogM4YnL+FAgwD0cjmsFTz96UBD/kBW5v6
8Blnarp6wJGTGNL0j8E5ibuFUs1zNLrmQotpszlJ8K+QAZTCYM4ecklNTK5+1Y58
K6YnAjG7bxhfEsjgKumHJz4p6m6RN1RDfPrk2KkOqTiwN3WTT7ZvZ10F981oILzt
3aIeQKN+OFb8Cm1eOSD4gUl2nDbdMvc1qNOjF0rYqTgFDBhqirIrLaayk9FrdrYv
O3Lis5NcIAWonqFpoFdSYXXAzSG/RYRzfanGcIDxbp7h0XeKMn8hBPpXEt1h0Uqs
TSqTw0xNoqmTLkdM8r4vXSil8T/vj+dwXpE6ecu1aH0nbu4MGseCG3CPxFERjqkL
tSoFZYYkOhnDUqXZDUhfrFwHgopOYrkytaYE8/fLdT3+09ueuzL+Db660EtnxNjt
4wcOKP3JNpG6GA3nUd9uTgmK+GnIihrqqF9dnIYMJwGt93JzyoO84zUfu/uaLlVc
jEGZbqvn1F0MFEzJ8yIjwLtu10GJxehr8F88klq/c6AUaLSFQI9MEz9+XSZBJYOk
Ylx+F61b/58mxxpTAvzQAtLdBupTiEh4PMJp/Mxo1jq2c1VUTimOZL0Jnvi+tvyO
IaXeWhANnjA9oQhRUQ20XqhU4lDZWBZK5P1y6fYKd4IFmJUYu9kqsaEwgJs9eNNM
s7hSQkCE4uyljMmGSXvIZhthUPywVqxDKHnihYUCDAPU96ld+x77fwEP+wX7GF01
ryrP/yg90iGMGUUwJCEYnYgxHhLIrjI0sOMCjRtIRbQ9pT91V7zf6fn2QVClqwtk
YK0ZksD+C72hPeiy9XGO1LV2JOR7SCJBxuVz45XL+IfMR7pixMIgoEp90QE1dlr9
Vk0vh3GOdfsguMCPrsln9tz/XkpCj+jTHlMy4v8BbCDzW4jf/9i/L/bgekntSaq7
W3hcFCvtzSQEvUIn7BSBcZVAxtEkCfhDwLTQ2KofNLHQXc9inPvgND6FwlveSJh/
E8HjfT5ZPZr+3JUpIFvSn5PmnVVWJdqXaTemaXe1C32Xshky7qPBDjI+493gGAaW
dqeGpQJiLl8UpVQbCXhlzM5Gy4/yJ26mPVT5qumnSnb0PSgreJz2UndfnJ2UcuHi
Cj3VKMoyOUANS8CqUSULMA9D785yFfNDynNwHxFloWmP/BI0IMG4Qo5IPY1vJF8z
+mAnc0cbaYxCtVVGmEXWXbAuTb3rva/kM0nqfRohXIFmhHaHRCtJsBChf7IVSwxO
isvCaysR5As2rKzmWCmX3c2gg1UZUCPK059+2vbTeoXM9uveqxKvNU5dyMR9Z5X4
e7jGxQ3TlwRsip2GJcmlUfPkG8Q4TCJzJI09iOCqOpk7kUUNnoMBfcFJUfFa7ZYt
drjU5zM1kVmoNON8WTGsbY9e7FxOAMRddYHUhQIMA4UjGzlrlWntAQ//Xt44PgXj
K2HUgY+gSJE1b4vwuI3Tw6rdysrQIsBoZVRWvsIpRJwejDn5vDBjmaJA1ceMY64f
zReqz0cKfDg21SqY8D37DoNCz5eKcbLrWttcvLYpG77xR1wNnl4iafYidrUiv9Rm
+L06Hv8TWiqL4symFjBmDd1F3o+Ve84eW1OeC4L17onqs+3nfJru+tbOwM4Y7xJZ
fmWLZt/tPtRDsGPD7OTaTDXvIX8ULm/hgNfjWRRvP0rwLROOIUq/s+cYT6qlGhme
+1Geys46Z58m/pUFlupnCFvc+QuVzs5f7zRf/nNLNMb1p3zSb79YTN9zOUNYQIqE
qlP3yP2OwxYhp7hqFyfLRQRb+EG1AFjTMqKv3iR9wlzSgsuUesx+hJB4EwsuL6/U
OuKR2aPFmOWlsWd5m/xrRyWTG7DfSHlgCwQy/DRWOMtdkqKyKhRUlyygbBzw3hU/
sbMOHgNMv/iIvU1HHGb0tBJvNBbqqwG82JfARs7SAVURDAAKcoz6WlutbNS2eSfr
2OLc00fS08sEltuLuKOU93xFW8fbotNgiM3oSb44kPDBLKH9jevXKtnDqjA9j56q
kLfpARYnq9nXPic6QIhSC8RXjtdfMXOGWe+YRa6xMTT/h5R5pk5HGeiOsWsskXQ4
F7/w3zYf2iaYgGhcJY0nWKc/o8Sl71O71rmFAQwDrgYmfVN6vWwBB/0YMeEIABY8
F5hCruTefe76qtvIaYr7LrzLIGxoBFoY01ylI+cwoUrxdoWsBVc1pcCgjNW1e6k8
jW8NNB9sPVRyRAruz1176xdRGT3zZtq3RIPN9ZX/D2aUj8MKauIeE0E/WCL24XHZ
lofFyiSRESa/koPC0U3DTaqBe+eqnQw55X+qPaiHvPM6uGTX0xgO0yR27wUq+lmG
wcDITe/W2z1BfsxkrqNSfWg09fO1P2V+0NkoSDSOvyqn+y5CG7PZn7V6MO2GBGjR
JBeOVgbG2l7XAv9SCMyaJzY5Qon7+ZWFfoBl3BH8gQXLU5jCNffPkt6byfgcVscm
gHZmGv6qefIohQEMA4i86A8BL1TKAQf/aUa5wR4KJ9429hX/v8SzuM8mCVz2fNQb
1Cd0E2h9Xih9pItx3wQhbTMtUiEIYutSvBlHroe+PWD3Lv2bR4js/S+Kc5X68fNT
VQCZI5Z//DiBoyjVSoe0MwOsh/WLfaEVb+0HT6BIPTnPCeLJCysN2ohDO02A3OBm
ExGC5zY72L3czBKWoR+bWxuNicP4st9MY8fK6FxyEmsmyGiSaebap4ONmzNNYMVC
LAkaw4edPySBynOfEP2hPdJzXyhiDceJXHLF4iDMTeQyAY8X19wNAo4GBSKZFBO4
1B49KI+8Ya1WVBjJZ3YtkUKFEZhNUzY9ZUqTU+Z8edhT+diNw+SPdYUCDAPGz82c
fsM5pAEP/0sFKpDVAAdV+FhQYCh2keMvk8Eb4WfcJTDVGtyrYhOcWRdYy6vukzKA
XAdwp7o5pjZGzlXdxGKdzd/G2/f2fS5925y2DC5yCCoT5EhLnCkEFGcL4Q7D9h3O
tDmtx1VudyjeHvuJdrRZdI8F1q9DLDd+i0qiyO5T57lN5z68gAA0waAwEhHMl9gg
ojoX1zGSHXJM0cS7JJOjG2sOUeaAEojmlZgCHGjtMi0FbEIY6Xnz8RraxCugAKyy
TJ3oJAGwFyKUtVFQQO5h/Vjd3tUC4x0YDufC1Uvjmfg/I2M6C+bmjQrZs+AXRPN8
E4ps7WTnYNJDuiZHFNsPcAArxHn39mzYdbTv68NPjX6AfIbkQXMtZAWtX264elpJ
Wy/a2N403Rs2rKgQXeN1fImqXd1XlqDY3nWjuXNT4YR1IMTAp3Wwmlt60dXSYEDt
0j9VP988byol0t0If05aA42UZXtJVNlQr1u9IWCPX5fTCr7CG724VaYFhUwvqKNe
Q0THyxJWH3ybuQo5QiC2gSvQ95UQtQZMvjPLTPzO5Oac2/ShOrhxhoK8E1AwS0s6
CBBkVhD/URrtgz/kS3CVwH6swYHo+14i9gc4N6zlbPopvj3bj/jSkmM4raRRx4Hl
1Rh7OQuzB+cVrC4Zalon3Daq0G5YVRuweaZk7exBJVmKseyn4uNLhQEMA4+NHejH
OKLjAQf/afruaLlsfkENEQ6nvJjdm6kxmtA9efLe+VzGdjjEj6cFMW3mtfXJph09
iUNMLeHqbcYo/3WeUkssUu+MvIZotxRvyTzbfH2spBymVHCAiEIsdQ1+ZF8Ep5Eq
sCFMbrrLl6SLXPHaeWX4imxsJvVqcRjNdf0EbwwvtO5HW5mWd43MIG0JcupIc/9G
3gsc8qmohvVOi2T6AjhKwL9CwmppHUvmOPV/UDtXc5OO9QBAysgS0EYGtIA3v/P/
jMNQ4EkXXtbC0DjB+f7L5NFQfj5rg0SajmckjTVUqRi1sDs8VkAPfitSBo3QPvoW
ziJzQXlo5B5pz1gPqqYr7UhPAXKrFYUBDANOWUsxHzLm1wEH/A5FEaVO6TsoujUh
vYS7kYxQQ5CP8GI9fiSmRmvPIsY1SRoHlyrUIkU24pM+EQpjt0rdi6Q6bjs96jfp
dQjIMq9wcFLiEb/e861jDUNf9d3gUA+AkOICmd0VIvz1E57X56m9vynxvzRDGDqc
ukfDBxnzMURO47aN6dUY2MPKs8VRl/Kuqf87SjYnjV6jGov0BXRMUM6vKTdokOqz
PMwVDqSxBeZGeuJN8MR9abOhj1SbdqxQnwbuCcyk+6uZ3BeXRGfnxS+9LKtgWyLt
w94Cjx4rKfHJRMpG3LTkjXr0nwHLr/ZAtg1a7z+oQZj2vMeMYxDl4xaiTcXKa23v
mvqjwZyFAQwD2ypt/39wdbQBCAC2uqzBz7hxN8NvJ/QvMI3gTT1S+uhsVMZVd+Ur
iFFydWVdjKeezkyqJcO7lmD66kV+hYh2Wy6f/2swy0wkUcH0sUYQ6cWJXJqogEsH
P/emCz4tygqYqaUDKCgmc5UV9Iaws3jODvIBg0LMGWRZwJGKDK108hRENMiw+J4s
Cuf9mz4JSeC0wjxUacrjH33IXFbG1+V7SXA3uEJKTGElpf9Xwbxy4AGBLLa05wxN
mNzXi39VeqivEO8tvd7VPrFxGp/A2O1d1zHck3vg+wOj8w2D+UnDMdPJLAJ0iJj2
9+LwrBlUN7YHAqspkTqWAlU+ADwESAPI2KPNKTEYksP0ouFjhQIMA0GDcp9eHiJn
AQ/9HLCGXx8Yc1wq4bJhlVvFdLUIiSWt7+S1uKbuJRcqIj1d/y1k2x2OIOP/Vv0S
4nJELw2O4cvywM9qKrPN6AWxFf/bWDi7LO7FLuSmClL5KLmT5f5cSNXRzCUH/fd+
Y2qiAkt8nc50HsvOCYskoOXk9wMq1e6Z3lu5PssVqUxPotc7zbrFeOrXlq80P78M
meDp2S7ykgzeGhgbaZhi7zPrbtFR329uzje0S+wtpfx+BQpYC7YoZ+tqhlUlFt4r
QmJ776Z86EiC71PEjT+bdEQqBw/4ul3R+gm4RW2SGljrVTySSDS0eSXhFgGJe9Ci
k1A1yk40GBz5vOZSEp8kabHuzht1RYXVvL5RVOIWNvPqrPlsQAEFCxaUpPYdqcfG
LHnfE36W56e/ZCT3l5LZOzjK2v+qtj3huNU/cxMmRI9y4ea5C3M3EqLr4jQ4vLEJ
tgbgW07nkEtyknzyYhSIrkxBojVPpymB7Df8UYW4NWbMfwLuuj/IQ/yaZTzpkWGg
lX5pXUN0+b1J3xieDAMauFN6qgkw0VgogkjtAL4QpQpwjpz2SA1R9DEMQV/pIEbX
HIHqv0kgwufISVGefWHTX1oDckwOT6w/+Xpx2yHfuFFbtDmrn3Ooam1MDc77USem
jiBPKBFHQhEkKNqvPU9QwHMKVX9cXWi+cRSqGWF4uBt4L8eFAgwDAUGAx+hBlnIB
D/9cLHLHqm1P/Y+zReina8884siueZFhPgy+8OHTbqkI/KgXtyXUVipd6DWrsYBY
uLfxcxD5SpoPhnxg1+Gip3gDXqFfqPsOffffZI1zGD+JNQ0WLsXVZK1/sYht4zRH
HynwNoTx/yFuOc2GkvdR8mHMhsWa/sOCpG/vwYVs3ZSAkUAJrwYzmlXuFpm/3p4v
Pegi8y/DdIBtkZsZyqa6zP5+z/UoAGzCy99sIin0M6oMWiyRTSRmcCE0dIFr1DXs
XGp3VeRzACKHUD1Wi8UbRDGnt6SNL742Exs5t+HKIs/X7TnAx2XEHAzE5kQEGoPL
txBtBuZJfbxjON1eZU2LyyMOw0+ms0rrOXQ2i02dJy6r5zSR8njXgxVVijKci5y4
gwlozdrjxdNK3cHGvE6vneof6KbERcjnUnV09MdBgt3vmhmlNnc+PVq5C6BdQOrt
ny5gV4B0xXHdyj7QB6wkkKFBNmnI27gnw5BivUiR0E4NcbGZMU3egFlhQKaoZ/+A
hyFAQ4IhTNiyoLMaMxAgbYUg6ljVNXslxAhWFLJLgVwZOj699fsOl7SA1TxEMffg
mLI/YYxvQA/vKesBaSI2dIS68+/77DamuZaBOceGQreguaFLGPLauXTylCkq6VOS
PUWyZLgXjbNJT+aaTH875ptvBWBzUh00eImp0lh4eEEitYUCDAOtBVSAQddkyAEP
+wckrdyE+eB8VfgGZpmalm2babpzeFiOoS4Q4O59/mWI6Sigy5K6/uo/NXwimWAe
j5tUNamAdl13/QVS4bpft5nPcN8C8pCuxAqOGl79FxmqsluzQKg4u3M1ERB9+umJ
jM3yuDNguVA4ZW3MmmHpc82R4OS+f2uv0IVs3qwcteBV2ZvLwKOpcZN4ZmEFfwyO
9e73tmbp+0cHz3B8mg5m8ERTcG/mEaMfQ0vAskJC3jX9JRSQg6ei8SHGGp+Lkbus
y2lnJNJlmeznZFQ5nFIUrGVw/g/K6pB11GW8Onbdk4zSLtWWV9ulH/SUABRXI3yG
uks/Gg5q8dDNoQDL8DZB/kGzVRmVFMc8/wNvWmHZ6KJlEr/WUuimTAtiw9zROyKc
tKfT5HzE1l8LZKu+Uw7GQfMufiVC56o7EDMMsPOpw/cvLtQMLs2mB/mgNhtqUIAK
SHht1x7rmgiByECAi735eo2L5Cu+3pQz5Kao3QExyscrBaTK+N3w9mZY5SusDAKS
tqj5w7ITlzH6SQ+9kPhGKxIUWzBZAB8nYhKkJ3uuN2QUofq0JVA7F7lJRMuObjJL
gpCkNe0p4SpmKTNS3cYzd80ccdmbdlLOHtEOeOt+GKUZU079vYWiykXBZyN5X1AM
lZMO/59inP9qg1WTVHv2XwVX6BP/MQ9VsQT2L++7uL1R0usBneKzTJLEkk13wPja
YK4OvhaPgPOMfHtSBPo4mYGCXxaecucpLNRFjxNdWCi/E7z/lxuppiaHcbbBHrIJ
l+AO1Jz83S73rOHzJawJSdboPUjUXAcs3jzkvPqOoDB+7Vmj9XqgIQLk6yOplmPv
Z9faR/YKOuM9JLMf/2SwkGADv/moCqfD6rmNqUsYi/mZh0+z/wvm1SdtnczKA/jn
lRlTIKwO9zpmjcuzoa+BQnRJ1bLV/ZOc6It55nwe9HbaqwXnyrfs10n3TKOJCcI3
hjSKRjl34v7wRxIuG2BEUhJg0I7pDvxAXjEidyrNgF+qvM7aL5QG6IkAkRfnUvmg
MlT824AUQrVivCOjqh6SLz3ocXNqOv2aRQ4+Xw2oSS8z2yIMnhrq/TP7QMhsTh0/
iF7OruUpsSFJQ4syBZccnTq3kF91SABW+WoPcx9lCPNjllT6dSZhxompAkGAVdc6
o0NzDS7A0TisjCWR5vdpuzZv5YT7tPSxBqzOre8catnJjZodWFiRLmCgJtmoPqKv
wPA2mkXbBONIftZpyC3ur38ukMkd2yAOWS3Ggr8FsMK0qpyBq8MUJ+OBS097OJLf
jP+ifpy+7blBEmQMuYKNofLz/MNcMMgfgE2/dgXUcI/FCoJIC8t+tWp7Onr/fwHF
3lkIO2EEW5k/83SqAdV+fu0V0AL+FiTKvfDAmyE7oSScBd1C4fEMcdB4Gsh/vNcJ
inSR4U6Zdc2lcQ+ZXEGM1kr1qjy5sA1f6r0bkhDX7GvUp5GYlfJNRbIcsfAGxNJs
HwRmFK/Mj9S9l+38Zlm3bld4zJNsW3Gxczm1lYmj/hgKPUvOXnV1qSk0E1Gq87EE
bC97TL9sK/QbCbwlmBECmMwcZaV3pmrs9w5w2op+Ig4N68j9kMHkGLqo9eEE30yJ
0p8F0nLZGwI2MNb1oGnHGzf5O9S7ENCBWknK38XEvqzsJwcSJpueKX9EGSVlGJ8O
YU5DqcJ37X+5f6Ra3Tmkn1P/TJmMWOEhf7t8j9RX55wHGFNnlACmWUMFLM0nj/Nq
mZEkE0xvJz3iZBp/H0/suuf80GFS9UxukChnaYVo5NSvaWlqZl/9tF68cfBPQ982
RoyestG1pKi7h5vXY4C8hbzqhvIuDs4MoPLZHYtI9Bkcsob7Y0dywZZ6fUYPJ+q2
IpRU2riSPUV+fNTJQH9LHFbycPV2u6UySfomF/P0zOVis23YQq1WvoScjFt867Vy
Z8nZIlm7UxK2AcXORo9SYSHy/13Xf3wpVnbYdE0Ji9agwY0BTefS/HMCYtA+5BF+
3RcXPqjCSWOd/7zdItHi26gTsB/QUL/iDB5S1p7rnjRf9ZEzP6gMWwPxUZQy//0O
7lnJoeWxe5Nm9bIvezEq1i6RF2EFWdAC1i0XFbz7lWkY4pz0RKbv5wugROVYZamn
YylSs6CsaGXvG7WlfqJ+ndNbUPA3d50dsHT912SrWem5PCDJvCfZnp9VFlcm5QL7
ZWJJ7oNhXVWSrNr+rh/fjMe2KMdJkeRxWNTIGPKTycFp0STfrrcpE/AR6BQgze8t
WwMvaarUrjXp3+LTXT+du1f2RA28Quo+W2v5rDNLDNR7jkhwM7lIakHewHJOEHS0
qwPn8zQFjBCM8Q/xrjfKIEaxFri6b/ueRISmokRJTAH8zeCSxptV9O7rmJM4cnav
nTHu5RKfBwbdyHi71uNaxscjnukJP1YDMjMf/hb/pSi6RwUmDXbEtBNE5bbizMru
h1vs4ZyPzXV6Awk90E7kOUYTqXTGkPfBJuPCatWh/BRXJAYD2HsrqEn2iOzY5lGp
XGzMzOyZdusPK21V5OyhVJRBp++IQVLymgADIZ//j23X5kwL0b38KBj4jFK+VV+A
Zj1r87g6bpN19qPJhONO/hOq9NxHQDwqXg7JIx177VvJa6UM7Xw9SztGAc0WEPDB
YFV+QGDSOEYAuDxraJYJ68lK3jqD2IxiS3le1wlplEHd2cYnmFpKHcRU0QpY5yrY
3wJoS1quKDFlxNIfDSRePSXr9tFYpy8kZnX7H1jdOgE5KOBzWiyxbsipWBAFP8eF
QMl0fI+aZ/1icIw4tQnTIwSsXeUc1dQRGW3OeGWql0Zxpd8puilLZ7HVJmmmByaB
QinTwjpDA4dYVQmBvMIFRUnMwbdE7n6VUKdytHvX7zMSvCG528AXHYoS7RFmgpxK
AZyJayl95A+cgp8UaBptMmMwF65LPVog0wV/qu0C2s1QySe1PA06F1Z+wihgvloJ
tnDSx7xtS/phj/M/lMXcx/aoQ3evec+tUJ2ZwcVpGJqGVFJtsOi0ohtNdawJwvsL
hA/zt9yaOhpRfnIN6q7N9llly2JCGo6WVaUvM2Er2Ow+5QsDOTlNtdEs8oN60lMb
0ZQrhmKob8bnFObU9ZrFKEhBOzFHAdHmSAH3FPiq5muRiT4fwEN355fU+r5Qy1N8
eTDc59pUlg5OC9AXqVGLXHhr0bNHYfDV0tIbU8N9J2xKVvmV5MrLbBAT43TbJQjc
CTTEO5QQzFTHMu17C4AKh0jBUYYP47RjjIbUOrkL+L4QQqgvtuiWs8EHlV2CW+hK
kmvWmMpR7QLQKRKr1x9V6KBTIYCxyK0FoZUBNmTSBbql5ggvVe771vVhM6HhlH8i
Tc+6lYUzH18oQdBkiVjMW6sCdF/xcvVjjAxiYgZ08KTkhPEEB4/fXhR0O9AiEI+n
B3I/8umWnsUSDxPzWh0gr0rL8MEfk4ujIVmLlREjBOMGK43nbOGu0K74dbDkNqR4
JF+0GbqLTyy+dSj/EizOGT4+zqLkItJVjTFeNaL+EWu242Mc8mtSAFsa7+BdZgrJ
ENX/2UAmRVp9QezAFWRaD0785y6zG4qGUozR6HaskGENp/+XJdAFH3v1txs8hZ6u
mWEZwEMGyJH3t9crq2s+DOakFp/2trCD+Qop9NMGtNY350Q9CAeR4uQ3lqCdUjWy
E2tTmQeFJsx4fWpiHIBI9hHj1Sz2zYUCE02Vkl1a98/8gwuSUPM4Nnm7SaobKd87
woHhVzmpjZ6NpGRzanCsbvrOOs0tzEzirqjRPEFaOg4fkygwDBXu6CYzvt53/Lcf
6gsMkhWdgV9DV2eHpyzCKa63U+IaAM/g0RcCrPc6pjouteWBX1kU2rxTm8pcb3ss
JpM9gqxRRaLtMqAhZacxWmGGKXwzOqcrpJrAW/Wx+v9Z1gsB+EwLKH47zqG3vqxD
+7k6E+serevKu55eZmtYUfEigQey4gxPOXGsLECjGXvwfCqJo3EtPRrVyMWEY30x
N8SIAAs/edzt70uBByeaCJw66yNs/06MaWcgTGDpXc/OM3yKZDAMv5GS3IWKO4mY
xgIxA6mZNvoJBtc0ya8NQ+vEY0Y=
=Jf8L
-----END PGP MESSAGE-----

--T1TVwOPoljC8iq9VdeXRjSNdqXRclbJfg--

[toc] | [prev] | [next] | [standalone]

#1672656 — Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

FromWilly Tarreau <w@1wt.eu>
Date2017-06-22 16:10 +0200
SubjectRe: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas
Message-ID<tVaY2-5Mw-27@gated-at.bofh.it>
In reply to#1672652
Hi,

On Thu, Jun 22, 2017 at 03:15:51PM +0200, Levente Polyak wrote:
> Just a side note, but i think its worth mentioning to also have look at
> these fixup patches:
> 
> 
> -- mm: fix new crash in unmapped_area_topdown()
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f4cb767d76cf7ee72f97dd76f6cfa6c76a5edc89

As I mentionned in another mail (this thread starts to be huge), this
one seems to have already been included in Ben's backport.

> -- Allow stack to grow up to address space limit
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bd726c90b6b8ce87602208701b208a208e6d5600

This one cleanly applies after, but I think Ben is currently looking
for feedback on the validity of his backport which was a difficult task.

Regards,
Willy

[toc] | [prev] | [next] | [standalone]

#1672669 — Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

FromBen Hutchings <ben@decadent.org.uk>
Date2017-06-22 16:20 +0200
SubjectRe: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas
Message-ID<tVb7I-5Qr-29@gated-at.bofh.it>
In reply to#1672656

[Multipart message — attachments visible in raw view] — view raw

On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote:
> Hi,
> 
> On Thu, Jun 22, 2017 at 03:15:51PM +0200, Levente Polyak wrote:
> > Just a side note, but i think its worth mentioning to also have
> > look at
> > these fixup patches:
> > 
> > 
> > -- mm: fix new crash in unmapped_area_topdown()
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
> > commit/?id=f4cb767d76cf7ee72f97dd76f6cfa6c76a5edc89
> 
> As I mentionned in another mail (this thread starts to be huge), this
> one seems to have already been included in Ben's backport.

That code was completely replaced due to the lack of an rbtree for gaps
in 3.2, so the fix was not needed.

> > -- Allow stack to grow up to address space limit
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
> > commit/?id=bd726c90b6b8ce87602208701b208a208e6d5600
> 
> This one cleanly applies after, but I think Ben is currently looking
> for feedback on the validity of his backport which was a difficult
> task.

Right.

Ben.

-- 
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.

[toc] | [prev] | [next] | [standalone]

#1672690 — Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

FromWilly Tarreau <w@1wt.eu>
Date2017-06-22 16:40 +0200
SubjectRe: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas
Message-ID<tVbr3-5Yi-1@gated-at.bofh.it>
In reply to#1672669
On Thu, Jun 22, 2017 at 03:14:00PM +0100, Ben Hutchings wrote:
> On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote:
> > but I think Ben is currently looking
> > for feedback on the validity of his backport which was a difficult
> > task.
> 
> Right.

Ben, barring more feedback, I think your should put your patch to your
stable queue so that Guenter can run his build+boot tests. They managed
to spot a few issues in my patches and that will make you more confident
regarding the whole architectures coverage.

Just my 2c,
Willy

[toc] | [prev] | [next] | [standalone]

#1673189 — Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

FromAndy Lutomirski <luto@kernel.org>
Date2017-06-23 05:20 +0200
SubjectRe: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas
Message-ID<tVnix-5cE-3@gated-at.bofh.it>
In reply to#1672690
On Thu, Jun 22, 2017 at 7:34 AM, Willy Tarreau <w@1wt.eu> wrote:
> On Thu, Jun 22, 2017 at 03:14:00PM +0100, Ben Hutchings wrote:
>> On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote:
>> > but I think Ben is currently looking
>> > for feedback on the validity of his backport which was a difficult
>> > task.
>>
>> Right.
>
> Ben, barring more feedback, I think your should put your patch to your
> stable queue so that Guenter can run his build+boot tests. They managed
> to spot a few issues in my patches and that will make you more confident
> regarding the whole architectures coverage.
>

Has anyone checked how grsecurity deals with this?  I think they have
a large stack guard gap.

--Andy

[toc] | [prev] | [next] | [standalone]

#1673242 — Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

FromLinus Torvalds <torvalds@linux-foundation.org>
Date2017-06-23 06:50 +0200
SubjectRe: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas
Message-ID<tVoHD-5Z8-11@gated-at.bofh.it>
In reply to#1673189
On Thu, Jun 22, 2017 at 8:10 PM, Andy Lutomirski <luto@kernel.org> wrote:
>
> Has anyone checked how grsecurity deals with this?  I think they have
> a large stack guard gap.

Don't bother with grsecurity.

Their approach has always been "we don't care if we break anything,
we'll just claim it's because we're extra secure".

The thing is a joke, and they are clowns. When they started talking
about people taking advantage of them, I stopped trying to be polite
about their bullshit.

Their patches are pure garbage.

                  Linus

[toc] | [prev] | [next] | [standalone]

#1673065 — Re: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas

FromHelge Deller <deller@gmx.de>
Date2017-06-22 23:30 +0200
SubjectRe: [vs-plain] Re: [PATCH] mm: larger stack guard gap, between vmas
Message-ID<tVhPQ-1Gi-25@gated-at.bofh.it>
In reply to#1672669
On 22.06.2017 16:14, Ben Hutchings wrote:
> On Thu, 2017-06-22 at 15:59 +0200, Willy Tarreau wrote:
>>> -- Allow stack to grow up to address space limit
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/
>>> commit/?id=bd726c90b6b8ce87602208701b208a208e6d5600
>>
>> This one cleanly applies after, but I think Ben is currently looking
>> for feedback on the validity of his backport which was a difficult
>> task.
> 
> Right.

Ben,
I might be able to give it a try, but I'm not sure if I'm able to boot
that kernel on my parisc box. Kernel 3.9 was basically the first one
which was run basically stable on parisc, but since then we had
some ABI changes in userspace (reduced SIGRTMIN, made
EWOULDBLOCK == EAGAIN) which might prevent me to boot that
kernel with current glibc.
Anyway, can you point me to your patches ?

Helge

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web