Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1674049 > unrolled thread

[PATCH] f2fs: avoid redundant f2fs_flush after remount

Back to article view | Back to linux.kernel

Contents

  [PATCH] f2fs: avoid redundant f2fs_flush after remount Yunlong Song <yunlong.song@huawei.com> - 2017-06-24 10:00 +0200
    Re: [PATCH] f2fs: avoid redundant f2fs_flush after remount Chao Yu <chao@kernel.org> - 2017-06-24 17:10 +0200

#1674049 — [PATCH] f2fs: avoid redundant f2fs_flush after remount

create_flush_cmd_control will create redundant issue_flush_thread after each
remount with flush_merge option.

Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
---
 fs/f2fs/segment.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index a6d7738..57f9edc 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -555,6 +555,8 @@ int create_flush_cmd_control(struct f2fs_sb_info *sbi)
 
 	if (SM_I(sbi)->fcc_info) {
 		fcc = SM_I(sbi)->fcc_info;
+		if (fcc->f2fs_issue_flush)
+			return err;
 		goto init_thread;
 	}
 
-- 
1.8.5.2

[toc] | [next] | [standalone]

#1674095

On 2017/6/24 15:57, Yunlong Song wrote:
> create_flush_cmd_control will create redundant issue_flush_thread after each
> remount with flush_merge option.
> 
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

> ---
>  fs/f2fs/segment.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index a6d7738..57f9edc 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -555,6 +555,8 @@ int create_flush_cmd_control(struct f2fs_sb_info *sbi)
>  
>  	if (SM_I(sbi)->fcc_info) {
>  		fcc = SM_I(sbi)->fcc_info;
> +		if (fcc->f2fs_issue_flush)
> +			return err;
>  		goto init_thread;
>  	}
>  
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web