Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673842 > unrolled thread

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c:  Fixed alignment to match open parenthesis Greg KH <gregkh@linuxfoundation.org> - 2017-06-23 22:30 +0200
    Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c:  Fixed alignment to match open parenthesis srishti sharma <srishtishar@gmail.com> - 2017-06-24 04:50 +0200
      Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c:  Fixed alignment to match open parenthesis srishti sharma <srishtishar@gmail.com> - 2017-06-24 05:40 +0200

#1673842 — Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis

On Thu, Jun 15, 2017 at 01:04:55AM +0530, srishti sharma wrote:
> Fixed alignment so that it matched open parenthesis.
> 
> Signed-off-by: srishti sharma <srishtishar@gmail.com>
> ---
>  .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c  | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)

What differs from your previous patch?  Always properly version your
patch so we know what to take.

Please fix and resend.

thanks,

greg k-h

[toc] | [next] | [standalone]

#1673983

On Fri, Jun 23, 2017 at 9:50 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Thu, Jun 15, 2017 at 01:04:55AM +0530, srishti sharma wrote:
>> Fixed alignment so that it matched open parenthesis.
>>
>> Signed-off-by: srishti sharma <srishtishar@gmail.com>
>> ---
>>  .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c  | 18 +++++++++---------
>>  1 file changed, 9 insertions(+), 9 deletions(-)
>
> What differs from your previous patch?

The previous patch had only one check fixed , this has all checks of
the type = parenthesis_alignment in the file bcm2835-ctl.c fixed .
Also there was a typo in the description of the previous patch so I
corrected that .

   Always properly version your
> patch so we know what to take.
>
> Please fix and resend.
>
> thanks,
>
> greg k-h

Regards,
Srishti

[toc] | [prev] | [next] | [standalone]

#1673991

On Sat, Jun 24, 2017 at 8:11 AM, srishti sharma <srishtishar@gmail.com> wrote:
> On Fri, Jun 23, 2017 at 9:50 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> On Thu, Jun 15, 2017 at 01:04:55AM +0530, srishti sharma wrote:
>>> Fixed alignment so that it matched open parenthesis.
>>>
>>> Signed-off-by: srishti sharma <srishtishar@gmail.com>
>>> ---
>>>  .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c  | 18 +++++++++---------
>>>  1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> What differs from your previous patch?
>
> The previous patch had only one check fixed , this has all checks of
> the type = parenthesis_alignment in the file bcm2835-ctl.c fixed .
> Also there was a typo in the description of the previous patch so I
> corrected that .
>
>    Always properly version your
>> patch so we know what to take.
>>
>> Please fix and resend.

I have re-sent version 2 .
>>
>> thanks,
>>
>> greg k-h
>

Regards,
Srishti

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web