Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1672503 > unrolled thread
| Started by | Jaya Durga <rjdurga@gmail.com> |
|---|---|
| First post | 2017-06-22 12:20 +0200 |
| Last post | 2017-06-23 22:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 2/2] Staging: rtl8712 : os_intfs.c: use octal Jaya Durga <rjdurga@gmail.com> - 2017-06-22 12:20 +0200
Re: [PATCH 2/2] Staging: rtl8712 : os_intfs.c: use octal Greg KH <gregkh@linuxfoundation.org> - 2017-06-23 22:30 +0200
| From | Jaya Durga <rjdurga@gmail.com> |
|---|---|
| Date | 2017-06-22 12:20 +0200 |
| Subject | [PATCH 2/2] Staging: rtl8712 : os_intfs.c: use octal |
| Message-ID | <tV7ns-3hH-27@gated-at.bofh.it> |
Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.Consider using octal permissions '0644'. Signed-off-by: Jaya Durga <jayad@cdac.in> --6 --- drivers/staging/rtl8712/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c index 8836b31..e698f6e 100644 --- a/drivers/staging/rtl8712/os_intfs.c +++ b/drivers/staging/rtl8712/os_intfs.c @@ -93,7 +93,7 @@ */ static int wifi_test; -module_param_string(ifname, ifname, sizeof(ifname), S_IRUGO | S_IWUSR); +module_param_string(ifname, ifname, sizeof(ifname), 0644); module_param(wifi_test, int, 0644); module_param(initmac, charp, 0644); module_param(video_mode, int, 0644); -- 1.9.1
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-06-23 22:30 +0200 |
| Message-ID | <tVDnj-6P1-9@gated-at.bofh.it> |
| In reply to | #1672503 |
On Thu, Jun 22, 2017 at 03:42:35PM +0530, Jaya Durga wrote: > Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' > are not preferred.Consider using octal permissions '0644'. > > Signed-off-by: Jaya Durga <jayad@cdac.in> > --6 What is this last line for? Please fix up and resend. thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web