Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673401 > unrolled thread

[PATCH][mtd-next] mtd: parser: print hex size_t value using correct %zx printk format specifier

Back to article view | Back to linux.kernel

Contents

  [PATCH][mtd-next] mtd: parser: print hex size_t value using correct %zx printk format specifier Colin King <colin.king@canonical.com> - 2017-06-23 11:10 +0200
    Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using  correct %zx printk format specifier Rafał Miłecki <rafal@milecki.pl> - 2017-06-23 14:40 +0200
      Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using  correct %zx printk format specifier Brian Norris <computersforpeace@gmail.com> - 2017-06-23 20:00 +0200
        Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using  correct %zx printk format specifier Colin Ian King <colin.king@canonical.com> - 2017-06-23 20:10 +0200
          Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using  correct %zx printk format specifier Brian Norris <computersforpeace@gmail.com> - 2017-06-23 20:20 +0200
            Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using  correct %zx printk format specifier Colin Ian King <colin.king@canonical.com> - 2017-06-23 20:30 +0200

#1673401 — [PATCH][mtd-next] mtd: parser: print hex size_t value using correct %zx printk format specifier

From: Colin Ian King <colin.king@canonical.com>

Use %zx instead of %X for size_t variable offset, fixes build warning:

warning: format '%X' expects argument of type 'unsigned int', but argument
2 has type 'size_t {aka long unsigned int}' [-Wformat=]

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/mtd/parsers/parser_trx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/parsers/parser_trx.c b/drivers/mtd/parsers/parser_trx.c
index e805108afd31..c0539555fac3 100644
--- a/drivers/mtd/parsers/parser_trx.c
+++ b/drivers/mtd/parsers/parser_trx.c
@@ -39,7 +39,7 @@ static const char *parser_trx_data_part_name(struct mtd_info *master,
 	err  = mtd_read(master, offset, sizeof(buf), &bytes_read,
 			(uint8_t *)&buf);
 	if (err && !mtd_is_bitflip(err)) {
-		pr_err("mtd_read error while parsing (offset: 0x%X): %d\n",
+		pr_err("mtd_read error while parsing (offset: 0x%zx): %d\n",
 			offset, err);
 		goto out_default;
 	}
-- 
2.11.0

[toc] | [next] | [standalone]

#1673512 — Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using correct %zx printk format specifier

On 2017-06-23 11:00, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Use %zx instead of %X for size_t variable offset, fixes build warning:
> 
> warning: format '%X' expects argument of type 'unsigned int', but 
> argument
> 2 has type 'size_t {aka long unsigned int}' [-Wformat=]
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

I sent similar patch few hours earlier:
[PATCH] mtd: parsers: trx: fix pr_err format for printing offset
https://patchwork.ozlabs.org/patch/779789/

Brian: you may pick the one with nicer commit message, whichever one you
prefer :)

[toc] | [prev] | [next] | [standalone]

#1673745 — Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using correct %zx printk format specifier

On Fri, Jun 23, 2017 at 12:02:34PM +0200, Rafał Miłecki wrote:
> On 2017-06-23 11:00, Colin King wrote:
> >From: Colin Ian King <colin.king@canonical.com>
> >
> >Use %zx instead of %X for size_t variable offset, fixes build warning:
> >
> >warning: format '%X' expects argument of type 'unsigned int', but
> >argument
> >2 has type 'size_t {aka long unsigned int}' [-Wformat=]
> >
> >Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> I sent similar patch few hours earlier:
> [PATCH] mtd: parsers: trx: fix pr_err format for printing offset
> https://patchwork.ozlabs.org/patch/779789/
> 
> Brian: you may pick the one with nicer commit message, whichever one you
> prefer :)

I'll go with:
(a) the earlier one and
(b) the one that doesn't change 'X' to 'x'

That means Rafał, you're our lucky winner today! Thanks for playing,
Colin.

Regards,
Brian

[toc] | [prev] | [next] | [standalone]

#1673747 — Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using correct %zx printk format specifier

On 23/06/17 18:51, Brian Norris wrote:
> On Fri, Jun 23, 2017 at 12:02:34PM +0200, Rafał Miłecki wrote:
>> On 2017-06-23 11:00, Colin King wrote:
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> Use %zx instead of %X for size_t variable offset, fixes build warning:
>>>
>>> warning: format '%X' expects argument of type 'unsigned int', but
>>> argument
>>> 2 has type 'size_t {aka long unsigned int}' [-Wformat=]
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>
>> I sent similar patch few hours earlier:
>> [PATCH] mtd: parsers: trx: fix pr_err format for printing offset
>> https://patchwork.ozlabs.org/patch/779789/
>>
>> Brian: you may pick the one with nicer commit message, whichever one you
>> prefer :)
> 
> I'll go with:
> (a) the earlier one and
> (b) the one that doesn't change 'X' to 'x'
> 
> That means Rafał, you're our lucky winner today! Thanks for playing,
> Colin.

FYI, I used %zx rather than %zX as couldn't find any instances of it in
the kernel and I wasn't 100% sure if it was supported or not.

linux-next:

$ git grep "%zx" | wc -l
161

$ git grep "%zX" | wc -l

0

Colin

> 
> Regards,
> Brian
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[toc] | [prev] | [next] | [standalone]

#1673754 — Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using correct %zx printk format specifier

On Fri, Jun 23, 2017 at 07:03:11PM +0100, Colin Ian King wrote:
> On 23/06/17 18:51, Brian Norris wrote:
> > On Fri, Jun 23, 2017 at 12:02:34PM +0200, Rafał Miłecki wrote:
> >> On 2017-06-23 11:00, Colin King wrote:
> >>> From: Colin Ian King <colin.king@canonical.com>
> >>>
> >>> Use %zx instead of %X for size_t variable offset, fixes build warning:
> >>>
> >>> warning: format '%X' expects argument of type 'unsigned int', but
> >>> argument
> >>> 2 has type 'size_t {aka long unsigned int}' [-Wformat=]
> >>>
> >>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >>
> >> I sent similar patch few hours earlier:
> >> [PATCH] mtd: parsers: trx: fix pr_err format for printing offset
> >> https://patchwork.ozlabs.org/patch/779789/
> >>
> >> Brian: you may pick the one with nicer commit message, whichever one you
> >> prefer :)
> > 
> > I'll go with:
> > (a) the earlier one and
> > (b) the one that doesn't change 'X' to 'x'
> > 
> > That means Rafał, you're our lucky winner today! Thanks for playing,
> > Colin.
> 
> FYI, I used %zx rather than %zX as couldn't find any instances of it in
> the kernel and I wasn't 100% sure if it was supported or not.

'x' and 'X' are handled nearly identically in lib/vsprintf.c. Don't see
why it wouldn't be.

> linux-next:
> 
> $ git grep "%zx" | wc -l
> 161
> 
> $ git grep "%zX" | wc -l
> 0

Yay, we're unique!

Seriously though: I don't really care which one is used (though I guess
I'm personally more used to lower-case hex). I just figured the less
churn the better.

Brian

[toc] | [prev] | [next] | [standalone]

#1673761 — Re: [PATCH][mtd-next] mtd: parser: print hex size_t value using correct %zx printk format specifier

On 23/06/17 19:15, Brian Norris wrote:
> On Fri, Jun 23, 2017 at 07:03:11PM +0100, Colin Ian King wrote:
>> On 23/06/17 18:51, Brian Norris wrote:
>>> On Fri, Jun 23, 2017 at 12:02:34PM +0200, Rafał Miłecki wrote:
>>>> On 2017-06-23 11:00, Colin King wrote:
>>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>>
>>>>> Use %zx instead of %X for size_t variable offset, fixes build warning:
>>>>>
>>>>> warning: format '%X' expects argument of type 'unsigned int', but
>>>>> argument
>>>>> 2 has type 'size_t {aka long unsigned int}' [-Wformat=]
>>>>>
>>>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>>>
>>>> I sent similar patch few hours earlier:
>>>> [PATCH] mtd: parsers: trx: fix pr_err format for printing offset
>>>> https://patchwork.ozlabs.org/patch/779789/
>>>>
>>>> Brian: you may pick the one with nicer commit message, whichever one you
>>>> prefer :)
>>>
>>> I'll go with:
>>> (a) the earlier one and
>>> (b) the one that doesn't change 'X' to 'x'
>>>
>>> That means Rafał, you're our lucky winner today! Thanks for playing,
>>> Colin.
>>
>> FYI, I used %zx rather than %zX as couldn't find any instances of it in
>> the kernel and I wasn't 100% sure if it was supported or not.
> 
> 'x' and 'X' are handled nearly identically in lib/vsprintf.c. Don't see
> why it wouldn't be.
> 
>> linux-next:
>>
>> $ git grep "%zx" | wc -l
>> 161
>>
>> $ git grep "%zX" | wc -l
>> 0
> 
> Yay, we're unique!
> 
> Seriously though: I don't really care which one is used (though I guess
> I'm personally more used to lower-case hex). I just figured the less
> churn the better.

That's fine by me too.
> 
> Brian
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web