Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1672469 > unrolled thread

[PATCH] ASoC: max9867: make array ni_div static const

Back to article view | Back to linux.kernel

Contents

  [PATCH] ASoC: max9867: make array ni_div static const Colin King <colin.king@canonical.com> - 2017-06-22 11:40 +0200
    Re: [alsa-devel] [PATCH] ASoC: max9867: make array ni_div static  const Vinod Koul <vinod.koul@intel.com> - 2017-06-22 12:30 +0200
    Applied "ASoC: max9867: make array ni_div static const" to the asoc tree Mark Brown <broonie@kernel.org> - 2017-06-22 16:20 +0200

#1672469 — [PATCH] ASoC: max9867: make array ni_div static const

From: Colin Ian King <colin.king@canonical.com>

The array ni_div does not need to be in global scope and is not
modified, so make it static const.

Cleans up sparse warning:
"symbol 'ni_div' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 sound/soc/codecs/max9867.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c
index 0247edc9c84e..2a40a69a7513 100644
--- a/sound/soc/codecs/max9867.c
+++ b/sound/soc/codecs/max9867.c
@@ -132,7 +132,7 @@ enum rates {
 	pcm_rate_48, max_pcm_rate,
 };
 
-struct ni_div_rates {
+static const struct ni_div_rates {
 	u32 mclk;
 	u16 ni[max_pcm_rate];
 } ni_div[] = {
-- 
2.11.0

[toc] | [next] | [standalone]

#1672507 — Re: [alsa-devel] [PATCH] ASoC: max9867: make array ni_div static const

On Thu, Jun 22, 2017 at 10:32:31AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The array ni_div does not need to be in global scope and is not
> modified, so make it static const.
> 
> Cleans up sparse warning:
> "symbol 'ni_div' was not declared. Should it be static?"

Acked-By: Vinod Koul <vinod.koul@intel.com>

-- 
~Vinod

[toc] | [prev] | [next] | [standalone]

#1672664 — Applied "ASoC: max9867: make array ni_div static const" to the asoc tree

The patch

   ASoC: max9867: make array ni_div static const

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

From 1943b0661184a5d17f31624dc8ac2c02a086c998 Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.king@canonical.com>
Date: Thu, 22 Jun 2017 10:32:31 +0100
Subject: [PATCH] ASoC: max9867: make array ni_div static const

The array ni_div does not need to be in global scope and is not
modified, so make it static const.

Cleans up sparse warning:
"symbol 'ni_div' was not declared. Should it be static?"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-By: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/max9867.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c
index 0247edc9c84e..2a40a69a7513 100644
--- a/sound/soc/codecs/max9867.c
+++ b/sound/soc/codecs/max9867.c
@@ -132,7 +132,7 @@ enum rates {
 	pcm_rate_48, max_pcm_rate,
 };
 
-struct ni_div_rates {
+static const struct ni_div_rates {
 	u32 mclk;
 	u16 ni[max_pcm_rate];
 } ni_div[] = {
-- 
2.11.0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web